* [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static
@ 2020-07-14 14:25 Wei Yongjun
2020-07-14 14:58 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-14 14:25 UTC (permalink / raw
To: Hulk Robot, Masami Hiramatsu, Steven Rostedt (VMware),
Andrew Morton, Kees Cook, Arvind Sankar, Dominik Brodowski,
Vlastimil Babka, glider@google.com
Cc: Wei Yongjun, linux-kernel
Fix sparse build warning:
init/main.c:305:6: warning:
symbol 'xbc_namebuf' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index 9127b240fd26..6a24981c727f 100644
--- a/init/main.c
+++ b/init/main.c
@@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
#ifdef CONFIG_BOOT_CONFIG
-char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
+static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
#define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static
2020-07-14 14:25 [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static Wei Yongjun
@ 2020-07-14 14:58 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2020-07-14 14:58 UTC (permalink / raw
To: Wei Yongjun
Cc: Hulk Robot, Steven Rostedt (VMware), Andrew Morton, Kees Cook,
Arvind Sankar, Dominik Brodowski, Vlastimil Babka,
glider@google.com, linux-kernel
On Tue, 14 Jul 2020 22:25:04 +0800
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fix sparse build warning:
>
> init/main.c:305:6: warning:
> symbol 'xbc_namebuf' was not declared. Should it be static?
Good catch!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index 9127b240fd26..6a24981c727f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
>
> #ifdef CONFIG_BOOT_CONFIG
>
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>
> #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-14 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-14 14:25 [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static Wei Yongjun
2020-07-14 14:58 ` Masami Hiramatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.