* [PATCH] runqemu: Check gtk or sdl option is passed together with gl or gl-es options.
@ 2020-08-17 12:18 Vasyl Vavrychuk
2020-08-17 13:43 ` [poky] " Alexander Kanavin
0 siblings, 1 reply; 3+ messages in thread
From: Vasyl Vavrychuk @ 2020-08-17 12:18 UTC (permalink / raw
To: poky; +Cc: Vasyl Vavrychuk
runqemu help reports that gtk or sdl option is needed with gl or gl-es
option. But if user forgot to add gtk or sdl option, then gl or gl-es
options were silently skipped.
Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
---
scripts/runqemu | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 310d79fdc5..398f0a0910 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -454,7 +454,8 @@ class BaseConfig(object):
self.qemu_opt_script += ' -display gtk'
elif arg == 'gl' or arg == 'gl-es':
# These args are handled inside sdl or gtk blocks above
- pass
+ if ('gtk' not in sys.argv) and ('sdl' not in sys.argv):
+ raise RunQemuError('Option %s also needs gtk or sdl option.' % (arg))
elif arg == 'egl-headless':
self.qemu_opt_script += ' -vga virtio -display egl-headless'
# As runqemu can be run within bitbake (when using testimage, for example),
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [poky] [PATCH] runqemu: Check gtk or sdl option is passed together with gl or gl-es options.
2020-08-17 12:18 [PATCH] runqemu: Check gtk or sdl option is passed together with gl or gl-es options Vasyl Vavrychuk
@ 2020-08-17 13:43 ` Alexander Kanavin
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Kanavin @ 2020-08-17 13:43 UTC (permalink / raw
To: Vasyl Vavrychuk; +Cc: poky
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
Thank you for the patch - it needs to go to
openemebedded-core@lists.openembedded.org
Alex
On Mon, 17 Aug 2020 at 14:18, Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:
> runqemu help reports that gtk or sdl option is needed with gl or gl-es
> option. But if user forgot to add gtk or sdl option, then gl or gl-es
> options were silently skipped.
>
> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> ---
> scripts/runqemu | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 310d79fdc5..398f0a0910 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -454,7 +454,8 @@ class BaseConfig(object):
> self.qemu_opt_script += ' -display gtk'
> elif arg == 'gl' or arg == 'gl-es':
> # These args are handled inside sdl or gtk blocks above
> - pass
> + if ('gtk' not in sys.argv) and ('sdl' not in sys.argv):
> + raise RunQemuError('Option %s also needs gtk or sdl
> option.' % (arg))
> elif arg == 'egl-headless':
> self.qemu_opt_script += ' -vga virtio -display
> egl-headless'
> # As runqemu can be run within bitbake (when using
> testimage, for example),
> --
> 2.23.0
>
>
>
[-- Attachment #2: Type: text/html, Size: 1967 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] runqemu: Check gtk or sdl option is passed together with gl or gl-es options.
@ 2020-08-17 13:57 Vasyl Vavrychuk
0 siblings, 0 replies; 3+ messages in thread
From: Vasyl Vavrychuk @ 2020-08-17 13:57 UTC (permalink / raw
To: openembedded-core; +Cc: Vasyl Vavrychuk
runqemu help reports that gtk or sdl option is needed with gl or gl-es
option. But if user forgot to add gtk or sdl option, then gl or gl-es
options were silently skipped.
Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
---
scripts/runqemu | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index c40acc4a86..7fb5f7db57 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -478,7 +478,8 @@ class BaseConfig(object):
self.qemu_opt_script += ' -display gtk,show-cursor=on'
elif arg == 'gl' or arg == 'gl-es':
# These args are handled inside sdl or gtk blocks above
- pass
+ if ('gtk' not in sys.argv) and ('sdl' not in sys.argv):
+ raise RunQemuError('Option %s also needs gtk or sdl option.' % (arg))
elif arg == 'egl-headless':
self.set_dri_path()
self.qemu_opt_script += ' -vga virtio -display egl-headless,show-cursor=on'
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-17 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-17 12:18 [PATCH] runqemu: Check gtk or sdl option is passed together with gl or gl-es options Vasyl Vavrychuk
2020-08-17 13:43 ` [poky] " Alexander Kanavin
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 13:57 Vasyl Vavrychuk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.