* [PATCH] arm: trusted-firmware-a variable name misuse
@ 2020-08-25 2:32 Jon Mason
2020-08-25 2:32 ` [PATCH] arm-bsp: redundant entry in FVP TF-A Jon Mason
2020-08-25 20:11 ` [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
0 siblings, 2 replies; 6+ messages in thread
From: Jon Mason @ 2020-08-25 2:32 UTC (permalink / raw
To: meta-arm; +Cc: nd
"processes" should be "processed" in trusted-firmware-a.inc, as it
signifies if the relevant part has been installed/processed.
Change-Id: I2d1ffbb0c6d14d280b6f9c9cc45c04c7c32409a7
Signed-off-by: Jon Mason <jon.mason@arm.com>
---
.../trusted-firmware-a/trusted-firmware-a.inc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
index 4956c4f..e1cffdf 100644
--- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
+++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
@@ -136,7 +136,7 @@ do_compile_append_aarch64_qemuall() {
do_install() {
install -d -m 755 ${D}/firmware
for atfbin in ${TFA_INSTALL_TARGET}; do
- processes="0"
+ processed="0"
if [ "$atfbin" = "all" ]; then
# Target all is not handled by default
bberror "all as TFA_INSTALL_TARGET is not handled by do_install"
@@ -150,32 +150,32 @@ do_install() {
install -m 0644 ${BUILD_DIR}/$atfbin.bin \
${D}/firmware/$atfbin-${TFA_PLATFORM}.bin
ln -sf $atfbin-${TFA_PLATFORM}.bin ${D}/firmware/$atfbin.bin
- processes="1"
+ processed="1"
fi
if [ -f ${BUILD_DIR}/$atfbin/$atfbin.elf ]; then
echo "Install $atfbin.elf"
install -m 0644 ${BUILD_DIR}/$atfbin/$atfbin.elf \
${D}/firmware/$atfbin-${TFA_PLATFORM}.elf
ln -sf $atfbin-${TFA_PLATFORM}.elf ${D}/firmware/$atfbin.elf
- processes="1"
+ processed="1"
fi
if [ -f ${BUILD_DIR}/$atfbin ]; then
echo "Install $atfbin"
install -m 0644 ${BUILD_DIR}/$atfbin \
${D}/firmware/$atfbin-${TFA_PLATFORM}
ln -sf $atfbin-${TFA_PLATFORM} ${D}/firmware/$atfbin
- processes="1"
+ processed="1"
fi
if [ -f ${BUILD_DIR}/fdts/$atfbin.dtb ]; then
echo "Install $atfbin.dtb"
install -m 0644 "${BUILD_DIR}/fdts/$atfbin.dtb" \
"${D}/firmware/$atfbin.dtb"
- processes="1"
+ processed="1"
elif [ "$atfbin" = "dtbs" ]; then
echo "dtbs install, skipped: set dtbs in TFA_INSTALL_TARGET"
elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
echo "Tools $atfbin install, skipped"
- elif [ "$processes" = "0" ]; then
+ elif [ "$processed" = "0" ]; then
bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
exit 1
fi
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm-bsp: redundant entry in FVP TF-A
2020-08-25 2:32 [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
@ 2020-08-25 2:32 ` Jon Mason
2020-08-25 20:12 ` [meta-arm] " Jon Mason
2020-08-25 20:11 ` [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
1 sibling, 1 reply; 6+ messages in thread
From: Jon Mason @ 2020-08-25 2:32 UTC (permalink / raw
To: meta-arm; +Cc: nd
bl1 is specified twice in the FVP Arm32 include file, which seems
erroneous.
Change-Id: Ib2fc91b547151acfc28f57679e99f649bd0f49ab
Signed-off-by: Jon Mason <jon.mason@arm.com>
---
.../trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc
index 5684802..117c25f 100644
--- a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc
+++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc
@@ -3,7 +3,7 @@
COMPATIBLE_MACHINE = "fvp-base-arm32"
TFA_PLATFORM = "fvp"
TFA_UBOOT = "1"
-TFA_BUILD_TARGET = "dtbs bl1 bl1 bl32 fip"
+TFA_BUILD_TARGET = "dtbs bl1 bl32 fip"
EXTRA_OEMAKE_append = " \
ARCH=aarch32 \
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse
2020-08-25 2:32 [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
2020-08-25 2:32 ` [PATCH] arm-bsp: redundant entry in FVP TF-A Jon Mason
@ 2020-08-25 20:11 ` Jon Mason
2020-08-25 21:10 ` Denys Dmytriyenko
1 sibling, 1 reply; 6+ messages in thread
From: Jon Mason @ 2020-08-25 20:11 UTC (permalink / raw
To: Jon Mason; +Cc: meta-arm, nd
On Mon, Aug 24, 2020 at 10:32:19PM -0400, Jon Mason wrote:
> "processes" should be "processed" in trusted-firmware-a.inc, as it
> signifies if the relevant part has been installed/processed.
>
> Change-Id: I2d1ffbb0c6d14d280b6f9c9cc45c04c7c32409a7
> Signed-off-by: Jon Mason <jon.mason@arm.com>
Pulled into master.
Thanks,
Jon
> ---
> .../trusted-firmware-a/trusted-firmware-a.inc | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> index 4956c4f..e1cffdf 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> @@ -136,7 +136,7 @@ do_compile_append_aarch64_qemuall() {
> do_install() {
> install -d -m 755 ${D}/firmware
> for atfbin in ${TFA_INSTALL_TARGET}; do
> - processes="0"
> + processed="0"
> if [ "$atfbin" = "all" ]; then
> # Target all is not handled by default
> bberror "all as TFA_INSTALL_TARGET is not handled by do_install"
> @@ -150,32 +150,32 @@ do_install() {
> install -m 0644 ${BUILD_DIR}/$atfbin.bin \
> ${D}/firmware/$atfbin-${TFA_PLATFORM}.bin
> ln -sf $atfbin-${TFA_PLATFORM}.bin ${D}/firmware/$atfbin.bin
> - processes="1"
> + processed="1"
> fi
> if [ -f ${BUILD_DIR}/$atfbin/$atfbin.elf ]; then
> echo "Install $atfbin.elf"
> install -m 0644 ${BUILD_DIR}/$atfbin/$atfbin.elf \
> ${D}/firmware/$atfbin-${TFA_PLATFORM}.elf
> ln -sf $atfbin-${TFA_PLATFORM}.elf ${D}/firmware/$atfbin.elf
> - processes="1"
> + processed="1"
> fi
> if [ -f ${BUILD_DIR}/$atfbin ]; then
> echo "Install $atfbin"
> install -m 0644 ${BUILD_DIR}/$atfbin \
> ${D}/firmware/$atfbin-${TFA_PLATFORM}
> ln -sf $atfbin-${TFA_PLATFORM} ${D}/firmware/$atfbin
> - processes="1"
> + processed="1"
> fi
> if [ -f ${BUILD_DIR}/fdts/$atfbin.dtb ]; then
> echo "Install $atfbin.dtb"
> install -m 0644 "${BUILD_DIR}/fdts/$atfbin.dtb" \
> "${D}/firmware/$atfbin.dtb"
> - processes="1"
> + processed="1"
> elif [ "$atfbin" = "dtbs" ]; then
> echo "dtbs install, skipped: set dtbs in TFA_INSTALL_TARGET"
> elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
> echo "Tools $atfbin install, skipped"
> - elif [ "$processes" = "0" ]; then
> + elif [ "$processed" = "0" ]; then
> bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
> exit 1
> fi
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm-bsp: redundant entry in FVP TF-A
2020-08-25 2:32 ` [PATCH] arm-bsp: redundant entry in FVP TF-A Jon Mason
@ 2020-08-25 20:12 ` Jon Mason
0 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2020-08-25 20:12 UTC (permalink / raw
To: Jon Mason; +Cc: meta-arm, nd
On Mon, Aug 24, 2020 at 10:32:20PM -0400, Jon Mason wrote:
> bl1 is specified twice in the FVP Arm32 include file, which seems
> erroneous.
>
> Change-Id: Ib2fc91b547151acfc28f57679e99f649bd0f49ab
> Signed-off-by: Jon Mason <jon.mason@arm.com>
Pulled into master.
Thanks,
Jon
> ---
> .../trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc
> index 5684802..117c25f 100644
> --- a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc
> +++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-fvp-arm32.inc
> @@ -3,7 +3,7 @@
> COMPATIBLE_MACHINE = "fvp-base-arm32"
> TFA_PLATFORM = "fvp"
> TFA_UBOOT = "1"
> -TFA_BUILD_TARGET = "dtbs bl1 bl1 bl32 fip"
> +TFA_BUILD_TARGET = "dtbs bl1 bl32 fip"
>
> EXTRA_OEMAKE_append = " \
> ARCH=aarch32 \
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse
2020-08-25 20:11 ` [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
@ 2020-08-25 21:10 ` Denys Dmytriyenko
2020-08-31 20:24 ` Jon Mason
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-08-25 21:10 UTC (permalink / raw
To: Jon Mason; +Cc: Jon Mason, meta-arm, nd
On Tue, Aug 25, 2020 at 04:11:41PM -0400, Jon Mason wrote:
> On Mon, Aug 24, 2020 at 10:32:19PM -0400, Jon Mason wrote:
> > "processes" should be "processed" in trusted-firmware-a.inc, as it
> > signifies if the relevant part has been installed/processed.
> >
> > Change-Id: I2d1ffbb0c6d14d280b6f9c9cc45c04c7c32409a7
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
>
> Pulled into master.
Thanks! Again, sorry for making this typo in the first place :)
Do you want to backport this to dunfell?
> Thanks,
> Jon
>
> > ---
> > .../trusted-firmware-a/trusted-firmware-a.inc | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > index 4956c4f..e1cffdf 100644
> > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > @@ -136,7 +136,7 @@ do_compile_append_aarch64_qemuall() {
> > do_install() {
> > install -d -m 755 ${D}/firmware
> > for atfbin in ${TFA_INSTALL_TARGET}; do
> > - processes="0"
> > + processed="0"
> > if [ "$atfbin" = "all" ]; then
> > # Target all is not handled by default
> > bberror "all as TFA_INSTALL_TARGET is not handled by do_install"
> > @@ -150,32 +150,32 @@ do_install() {
> > install -m 0644 ${BUILD_DIR}/$atfbin.bin \
> > ${D}/firmware/$atfbin-${TFA_PLATFORM}.bin
> > ln -sf $atfbin-${TFA_PLATFORM}.bin ${D}/firmware/$atfbin.bin
> > - processes="1"
> > + processed="1"
> > fi
> > if [ -f ${BUILD_DIR}/$atfbin/$atfbin.elf ]; then
> > echo "Install $atfbin.elf"
> > install -m 0644 ${BUILD_DIR}/$atfbin/$atfbin.elf \
> > ${D}/firmware/$atfbin-${TFA_PLATFORM}.elf
> > ln -sf $atfbin-${TFA_PLATFORM}.elf ${D}/firmware/$atfbin.elf
> > - processes="1"
> > + processed="1"
> > fi
> > if [ -f ${BUILD_DIR}/$atfbin ]; then
> > echo "Install $atfbin"
> > install -m 0644 ${BUILD_DIR}/$atfbin \
> > ${D}/firmware/$atfbin-${TFA_PLATFORM}
> > ln -sf $atfbin-${TFA_PLATFORM} ${D}/firmware/$atfbin
> > - processes="1"
> > + processed="1"
> > fi
> > if [ -f ${BUILD_DIR}/fdts/$atfbin.dtb ]; then
> > echo "Install $atfbin.dtb"
> > install -m 0644 "${BUILD_DIR}/fdts/$atfbin.dtb" \
> > "${D}/firmware/$atfbin.dtb"
> > - processes="1"
> > + processed="1"
> > elif [ "$atfbin" = "dtbs" ]; then
> > echo "dtbs install, skipped: set dtbs in TFA_INSTALL_TARGET"
> > elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
> > echo "Tools $atfbin install, skipped"
> > - elif [ "$processes" = "0" ]; then
> > + elif [ "$processed" = "0" ]; then
> > bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
> > exit 1
> > fi
> > --
> > 2.17.1
> >
>
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse
2020-08-25 21:10 ` Denys Dmytriyenko
@ 2020-08-31 20:24 ` Jon Mason
0 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2020-08-31 20:24 UTC (permalink / raw
To: Denys Dmytriyenko; +Cc: Jon Mason, meta-arm, nd
On Tue, Aug 25, 2020 at 05:10:33PM -0400, Denys Dmytriyenko wrote:
> On Tue, Aug 25, 2020 at 04:11:41PM -0400, Jon Mason wrote:
> > On Mon, Aug 24, 2020 at 10:32:19PM -0400, Jon Mason wrote:
> > > "processes" should be "processed" in trusted-firmware-a.inc, as it
> > > signifies if the relevant part has been installed/processed.
> > >
> > > Change-Id: I2d1ffbb0c6d14d280b6f9c9cc45c04c7c32409a7
> > > Signed-off-by: Jon Mason <jon.mason@arm.com>
> >
> > Pulled into master.
>
> Thanks! Again, sorry for making this typo in the first place :)
> Do you want to backport this to dunfell?
Done. Also, I pulled back all of Ross's TF-A build race fixes to dunfell.
Thanks,
Jon
>
>
> > Thanks,
> > Jon
> >
> > > ---
> > > .../trusted-firmware-a/trusted-firmware-a.inc | 12 ++++++------
> > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > index 4956c4f..e1cffdf 100644
> > > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > @@ -136,7 +136,7 @@ do_compile_append_aarch64_qemuall() {
> > > do_install() {
> > > install -d -m 755 ${D}/firmware
> > > for atfbin in ${TFA_INSTALL_TARGET}; do
> > > - processes="0"
> > > + processed="0"
> > > if [ "$atfbin" = "all" ]; then
> > > # Target all is not handled by default
> > > bberror "all as TFA_INSTALL_TARGET is not handled by do_install"
> > > @@ -150,32 +150,32 @@ do_install() {
> > > install -m 0644 ${BUILD_DIR}/$atfbin.bin \
> > > ${D}/firmware/$atfbin-${TFA_PLATFORM}.bin
> > > ln -sf $atfbin-${TFA_PLATFORM}.bin ${D}/firmware/$atfbin.bin
> > > - processes="1"
> > > + processed="1"
> > > fi
> > > if [ -f ${BUILD_DIR}/$atfbin/$atfbin.elf ]; then
> > > echo "Install $atfbin.elf"
> > > install -m 0644 ${BUILD_DIR}/$atfbin/$atfbin.elf \
> > > ${D}/firmware/$atfbin-${TFA_PLATFORM}.elf
> > > ln -sf $atfbin-${TFA_PLATFORM}.elf ${D}/firmware/$atfbin.elf
> > > - processes="1"
> > > + processed="1"
> > > fi
> > > if [ -f ${BUILD_DIR}/$atfbin ]; then
> > > echo "Install $atfbin"
> > > install -m 0644 ${BUILD_DIR}/$atfbin \
> > > ${D}/firmware/$atfbin-${TFA_PLATFORM}
> > > ln -sf $atfbin-${TFA_PLATFORM} ${D}/firmware/$atfbin
> > > - processes="1"
> > > + processed="1"
> > > fi
> > > if [ -f ${BUILD_DIR}/fdts/$atfbin.dtb ]; then
> > > echo "Install $atfbin.dtb"
> > > install -m 0644 "${BUILD_DIR}/fdts/$atfbin.dtb" \
> > > "${D}/firmware/$atfbin.dtb"
> > > - processes="1"
> > > + processed="1"
> > > elif [ "$atfbin" = "dtbs" ]; then
> > > echo "dtbs install, skipped: set dtbs in TFA_INSTALL_TARGET"
> > > elif [ -f ${B}/tools/$atfbin/$atfbin ]; then
> > > echo "Tools $atfbin install, skipped"
> > > - elif [ "$processes" = "0" ]; then
> > > + elif [ "$processed" = "0" ]; then
> > > bberror "Unsupported TFA_INSTALL_TARGET target $atfbin"
> > > exit 1
> > > fi
> > > --
> > > 2.17.1
> > >
> >
> > >
> >
>
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-31 20:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-25 2:32 [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
2020-08-25 2:32 ` [PATCH] arm-bsp: redundant entry in FVP TF-A Jon Mason
2020-08-25 20:12 ` [meta-arm] " Jon Mason
2020-08-25 20:11 ` [meta-arm] [PATCH] arm: trusted-firmware-a variable name misuse Jon Mason
2020-08-25 21:10 ` Denys Dmytriyenko
2020-08-31 20:24 ` Jon Mason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.