* [Intel-gfx] [RESEND PATCH 0/2] drm/i915: kernel-doc fixes for new DP helpers
@ 2020-09-22 17:53 Lyude Paul
2020-09-22 17:53 ` Lyude Paul
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx; +Cc: Mauro Carvalho Chehab
Note that none of the code that this touches is in i915, however at the
time I posted this patch all of the DP helpers that concern these
patches were added through drm-intel-next-queued, not drm-misc-next, so
it makes more sense to merge it through drm-intel-next-queued. As such,
I'm just sending this onto intel-gfx so that it gets a patch ID.
This should introduce no functional changes, and is already reviewed by
me.
Mauro Carvalho Chehab (2):
drm/dp: fix kernel-doc warnings at drm_dp_helper.c
drm/dp: fix a kernel-doc issue at drm_edid.c
drivers/gpu/drm/drm_dp_helper.c | 5 +++++
drivers/gpu/drm/drm_edid.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND PATCH 1/2] drm/dp: fix kernel-doc warnings at drm_dp_helper.c
2020-09-22 17:53 [Intel-gfx] [RESEND PATCH 0/2] drm/i915: kernel-doc fixes for new DP helpers Lyude Paul
2020-09-22 17:53 ` Lyude Paul
@ 2020-09-22 17:53 ` Lyude Paul
2020-09-22 18:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: kernel-doc fixes for new DP helpers Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx
Cc: Mauro Carvalho Chehab, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Ville Syrjälä, open list:DRM DRIVERS, open list
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
As warned by kernel-doc:
./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or member 'type' not described in 'drm_dp_downstream_is_type'
./drivers/gpu/drm/drm_dp_helper.c:886: warning: Function parameter or member 'dev' not described in 'drm_dp_downstream_mode'
Some function parameters weren't documented.
Fixes: 38784f6f8805 ("drm/dp: Add helpers to identify downstream facing port types")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/drm_dp_helper.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 90807a6b415c..478dd51f738d 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -374,6 +374,10 @@ static bool is_edid_digital_input_dp(const struct edid *edid)
* drm_dp_downstream_is_type() - is the downstream facing port of certain type?
* @dpcd: DisplayPort configuration data
* @port_cap: port capabilities
+ * @type: port type to be checked. Can be:
+ * %DP_DS_PORT_TYPE_DP, %DP_DS_PORT_TYPE_VGA, %DP_DS_PORT_TYPE_DVI,
+ * %DP_DS_PORT_TYPE_HDMI, %DP_DS_PORT_TYPE_NON_EDID,
+ * %DP_DS_PORT_TYPE_DP_DUALMODE or %DP_DS_PORT_TYPE_WIRELESS.
*
* Caveat: Only works with DPCD 1.1+ port caps.
*
@@ -870,6 +874,7 @@ EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion);
/**
* drm_dp_downstream_mode() - return a mode for downstream facing port
+ * @dev: DRM device
* @dpcd: DisplayPort configuration data
* @port_cap: port capabilities
*
--
2.26.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND PATCH 1/2] drm/dp: fix kernel-doc warnings at drm_dp_helper.c
@ 2020-09-22 17:53 ` Lyude Paul
0 siblings, 0 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx
Cc: Thomas Zimmermann, Mauro Carvalho Chehab, open list, David Airlie,
open list:DRM DRIVERS
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
As warned by kernel-doc:
./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or member 'type' not described in 'drm_dp_downstream_is_type'
./drivers/gpu/drm/drm_dp_helper.c:886: warning: Function parameter or member 'dev' not described in 'drm_dp_downstream_mode'
Some function parameters weren't documented.
Fixes: 38784f6f8805 ("drm/dp: Add helpers to identify downstream facing port types")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/drm_dp_helper.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 90807a6b415c..478dd51f738d 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -374,6 +374,10 @@ static bool is_edid_digital_input_dp(const struct edid *edid)
* drm_dp_downstream_is_type() - is the downstream facing port of certain type?
* @dpcd: DisplayPort configuration data
* @port_cap: port capabilities
+ * @type: port type to be checked. Can be:
+ * %DP_DS_PORT_TYPE_DP, %DP_DS_PORT_TYPE_VGA, %DP_DS_PORT_TYPE_DVI,
+ * %DP_DS_PORT_TYPE_HDMI, %DP_DS_PORT_TYPE_NON_EDID,
+ * %DP_DS_PORT_TYPE_DP_DUALMODE or %DP_DS_PORT_TYPE_WIRELESS.
*
* Caveat: Only works with DPCD 1.1+ port caps.
*
@@ -870,6 +874,7 @@ EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion);
/**
* drm_dp_downstream_mode() - return a mode for downstream facing port
+ * @dev: DRM device
* @dpcd: DisplayPort configuration data
* @port_cap: port capabilities
*
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [RESEND PATCH 1/2] drm/dp: fix kernel-doc warnings at drm_dp_helper.c
@ 2020-09-22 17:53 ` Lyude Paul
0 siblings, 0 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx
Cc: Thomas Zimmermann, Mauro Carvalho Chehab, open list,
Maxime Ripard, David Airlie, open list:DRM DRIVERS
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
As warned by kernel-doc:
./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or member 'type' not described in 'drm_dp_downstream_is_type'
./drivers/gpu/drm/drm_dp_helper.c:886: warning: Function parameter or member 'dev' not described in 'drm_dp_downstream_mode'
Some function parameters weren't documented.
Fixes: 38784f6f8805 ("drm/dp: Add helpers to identify downstream facing port types")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/drm_dp_helper.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 90807a6b415c..478dd51f738d 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -374,6 +374,10 @@ static bool is_edid_digital_input_dp(const struct edid *edid)
* drm_dp_downstream_is_type() - is the downstream facing port of certain type?
* @dpcd: DisplayPort configuration data
* @port_cap: port capabilities
+ * @type: port type to be checked. Can be:
+ * %DP_DS_PORT_TYPE_DP, %DP_DS_PORT_TYPE_VGA, %DP_DS_PORT_TYPE_DVI,
+ * %DP_DS_PORT_TYPE_HDMI, %DP_DS_PORT_TYPE_NON_EDID,
+ * %DP_DS_PORT_TYPE_DP_DUALMODE or %DP_DS_PORT_TYPE_WIRELESS.
*
* Caveat: Only works with DPCD 1.1+ port caps.
*
@@ -870,6 +874,7 @@ EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion);
/**
* drm_dp_downstream_mode() - return a mode for downstream facing port
+ * @dev: DRM device
* @dpcd: DisplayPort configuration data
* @port_cap: port capabilities
*
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND PATCH 2/2] drm/dp: fix a kernel-doc issue at drm_edid.c
2020-09-22 17:53 [Intel-gfx] [RESEND PATCH 0/2] drm/i915: kernel-doc fixes for new DP helpers Lyude Paul
2020-09-22 17:53 ` Lyude Paul
@ 2020-09-22 17:53 ` Lyude Paul
2020-09-22 18:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: kernel-doc fixes for new DP helpers Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx
Cc: Mauro Carvalho Chehab, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Ville Syrjälä, open list:DRM DRIVERS, open list
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic'
./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a82f37d44258..631125b46e04 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd)
/**
* drm_display_mode_from_cea_vic() - return a mode for CEA VIC
* @dev: DRM device
- * @vic: CEA VIC of the mode
+ * @video_code: CEA VIC of the mode
*
* Creates a new mode matching the specified CEA VIC.
*
--
2.26.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND PATCH 2/2] drm/dp: fix a kernel-doc issue at drm_edid.c
@ 2020-09-22 17:53 ` Lyude Paul
0 siblings, 0 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx
Cc: Thomas Zimmermann, Mauro Carvalho Chehab, open list, David Airlie,
open list:DRM DRIVERS
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic'
./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a82f37d44258..631125b46e04 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd)
/**
* drm_display_mode_from_cea_vic() - return a mode for CEA VIC
* @dev: DRM device
- * @vic: CEA VIC of the mode
+ * @video_code: CEA VIC of the mode
*
* Creates a new mode matching the specified CEA VIC.
*
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [RESEND PATCH 2/2] drm/dp: fix a kernel-doc issue at drm_edid.c
@ 2020-09-22 17:53 ` Lyude Paul
0 siblings, 0 replies; 8+ messages in thread
From: Lyude Paul @ 2020-09-22 17:53 UTC (permalink / raw
To: intel-gfx
Cc: Thomas Zimmermann, Mauro Carvalho Chehab, open list,
Maxime Ripard, David Airlie, open list:DRM DRIVERS
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic'
./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a82f37d44258..631125b46e04 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd)
/**
* drm_display_mode_from_cea_vic() - return a mode for CEA VIC
* @dev: DRM device
- * @vic: CEA VIC of the mode
+ * @video_code: CEA VIC of the mode
*
* Creates a new mode matching the specified CEA VIC.
*
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: kernel-doc fixes for new DP helpers
2020-09-22 17:53 [Intel-gfx] [RESEND PATCH 0/2] drm/i915: kernel-doc fixes for new DP helpers Lyude Paul
2020-09-22 17:53 ` Lyude Paul
2020-09-22 17:53 ` Lyude Paul
@ 2020-09-22 18:52 ` Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-09-22 18:52 UTC (permalink / raw
To: Lyude Paul; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 611 bytes --]
== Series Details ==
Series: drm/i915: kernel-doc fixes for new DP helpers
URL : https://patchwork.freedesktop.org/series/81985/
State : failure
== Summary ==
Applying: drm/dp: fix kernel-doc warnings at drm_dp_helper.c
Using index info to reconstruct a base tree...
M drivers/gpu/drm/drm_dp_helper.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: drm/dp: fix a kernel-doc issue at drm_edid.c
Using index info to reconstruct a base tree...
M drivers/gpu/drm/drm_edid.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
[-- Attachment #1.2: Type: text/html, Size: 1137 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-22 18:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-22 17:53 [Intel-gfx] [RESEND PATCH 0/2] drm/i915: kernel-doc fixes for new DP helpers Lyude Paul
2020-09-22 17:53 ` [RESEND PATCH 1/2] drm/dp: fix kernel-doc warnings at drm_dp_helper.c Lyude Paul
2020-09-22 17:53 ` [Intel-gfx] " Lyude Paul
2020-09-22 17:53 ` Lyude Paul
2020-09-22 17:53 ` [RESEND PATCH 2/2] drm/dp: fix a kernel-doc issue at drm_edid.c Lyude Paul
2020-09-22 17:53 ` [Intel-gfx] " Lyude Paul
2020-09-22 17:53 ` Lyude Paul
2020-09-22 18:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: kernel-doc fixes for new DP helpers Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.