* Re: [PATCH v3 2/8] staging: qlge: Initialize devlink health dump framework
@ 2020-10-16 18:28 kernel test robot
2020-10-16 18:28 ` [PATCH] staging: qlge: fix odd_ptr_err.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-10-16 18:28 UTC (permalink / raw
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201016115407.170821-3-coiby.xu@gmail.com>
References: <20201016115407.170821-3-coiby.xu@gmail.com>
TO: Coiby Xu <coiby.xu@gmail.com>
TO: devel(a)driverdev.osuosl.org
CC: Benjamin Poirier <benjamin.poirier@gmail.com>
CC: Dan Carpenter <error27@gmail.com>
CC: "Shung-Hsi Yu" <shung-hsi.yu@suse.com>
CC: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
CC: Manish Chopra <manishc@marvell.com>
CC: "(supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER)" <GR-Linux-NIC-Dev(a)marvell.com
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: linux-kernel(a)vger.kernel.org
CC: netdev(a)vger.kernel.org
Hi Coiby,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20201016]
[cannot apply to staging/staging-testing v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201016-201456
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9ff9b0d392ea08090cd1780fb196f36dbb586529
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: i386-randconfig-c001-20201016 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/staging/qlge/qlge_devlink.c:27:5-11: inconsistent IS_ERR and PTR_ERR on line 30.
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35215 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] staging: qlge: fix odd_ptr_err.cocci warnings
2020-10-16 18:28 [PATCH v3 2/8] staging: qlge: Initialize devlink health dump framework kernel test robot
@ 2020-10-16 18:28 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-10-16 18:28 UTC (permalink / raw
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201016115407.170821-3-coiby.xu@gmail.com>
References: <20201016115407.170821-3-coiby.xu@gmail.com>
TO: Coiby Xu <coiby.xu@gmail.com>
TO: devel(a)driverdev.osuosl.org
CC: Benjamin Poirier <benjamin.poirier@gmail.com>
CC: Dan Carpenter <error27@gmail.com>
CC: "Shung-Hsi Yu" <shung-hsi.yu@suse.com>
CC: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
CC: Manish Chopra <manishc@marvell.com>
CC: "(supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER)" <GR-Linux-NIC-Dev(a)marvell.com
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: linux-kernel(a)vger.kernel.org
CC: netdev(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/staging/qlge/qlge_devlink.c:27:5-11: inconsistent IS_ERR and PTR_ERR on line 30.
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call to
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201016-201456
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9ff9b0d392ea08090cd1780fb196f36dbb586529
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
Please take the patch only if it's a positive warning. Thanks!
qlge_devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/qlge/qlge_devlink.c
+++ b/drivers/staging/qlge/qlge_devlink.c
@@ -27,5 +27,5 @@ void qlge_health_create_reporters(struct
if (IS_ERR(priv->reporter))
netdev_warn(priv->ndev,
"Failed to create reporter, err = %ld\n",
- PTR_ERR(reporter));
+ PTR_ERR(priv->reporter));
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-16 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-16 18:28 [PATCH v3 2/8] staging: qlge: Initialize devlink health dump framework kernel test robot
2020-10-16 18:28 ` [PATCH] staging: qlge: fix odd_ptr_err.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.