* [PATCH 0/4] ASoC: SOF: Kconfig corrections
@ 2020-11-11 21:35 Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 1/4] ASoC: SOF: imx: fix Kconfig punctuation Pierre-Louis Bossart
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-11-11 21:35 UTC (permalink / raw
To: alsa-devel; +Cc: tiwai, broonie, Pierre-Louis Bossart
Three cosmetic patches and a fix for a randconfig issue.
Pierre-Louis Bossart (1):
ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG
Randy Dunlap (3):
ASoC: SOF: imx: fix Kconfig punctuation
ASoC: SOF: Kconfig: fix Kconfig punctuation and wording
ASoC: SOF: Intel: fix Kconfig punctuation and wording
sound/soc/sof/Kconfig | 42 ++++++++++++------------
sound/soc/sof/imx/Kconfig | 10 +++---
sound/soc/sof/intel/Kconfig | 64 ++++++++++++++++++-------------------
3 files changed, 58 insertions(+), 58 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/4] ASoC: SOF: imx: fix Kconfig punctuation
2020-11-11 21:35 [PATCH 0/4] ASoC: SOF: Kconfig corrections Pierre-Louis Bossart
@ 2020-11-11 21:35 ` Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 2/4] ASoC: SOF: Kconfig: fix Kconfig punctuation and wording Pierre-Louis Bossart
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-11-11 21:35 UTC (permalink / raw
To: alsa-devel
Cc: Guennadi Liakhovetski, tiwai, Randy Dunlap, Ranjani Sridharan,
Pierre-Louis Bossart, broonie, Rander Wang
From: Randy Dunlap <rdunlap@infradead.org>
Add periods at the end of sentences in help text.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
sound/soc/sof/imx/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
index 48f998a19ddb..49d605cb09a5 100644
--- a/sound/soc/sof/imx/Kconfig
+++ b/sound/soc/sof/imx/Kconfig
@@ -17,7 +17,7 @@ config SND_SOC_SOF_IMX_OF
select SND_SOC_SOF_IMX8M if SND_SOC_SOF_IMX8M_SUPPORT
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_IMX_COMMON
tristate
@@ -30,7 +30,7 @@ config SND_SOC_SOF_IMX8_SUPPORT
depends on IMX_SCU=y || IMX_SCU=SND_SOC_SOF_IMX_OF
depends on IMX_DSP=y || IMX_DSP=SND_SOC_SOF_IMX_OF
help
- This adds support for Sound Open Firmware for NXP i.MX8 platforms
+ This adds support for Sound Open Firmware for NXP i.MX8 platforms.
Say Y if you have such a device.
If unsure select "N".
@@ -40,13 +40,13 @@ config SND_SOC_SOF_IMX8
select SND_SOC_SOF_XTENSA
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_IMX8M_SUPPORT
bool "SOF support for i.MX8M"
depends on IMX_DSP=y || IMX_DSP=SND_SOC_SOF_OF
help
- This adds support for Sound Open Firmware for NXP i.MX8M platforms
+ This adds support for Sound Open Firmware for NXP i.MX8M platforms.
Say Y if you have such a device.
If unsure select "N".
@@ -56,6 +56,6 @@ config SND_SOC_SOF_IMX8M
select SND_SOC_SOF_XTENSA
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
endif ## SND_SOC_SOF_IMX_IMX_TOPLEVEL
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/4] ASoC: SOF: Kconfig: fix Kconfig punctuation and wording
2020-11-11 21:35 [PATCH 0/4] ASoC: SOF: Kconfig corrections Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 1/4] ASoC: SOF: imx: fix Kconfig punctuation Pierre-Louis Bossart
@ 2020-11-11 21:35 ` Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 3/4] ASoC: SOF: Intel: " Pierre-Louis Bossart
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-11-11 21:35 UTC (permalink / raw
To: alsa-devel
Cc: Guennadi Liakhovetski, tiwai, Randy Dunlap, Ranjani Sridharan,
Pierre-Louis Bossart, broonie, Rander Wang
From: Randy Dunlap <rdunlap@infradead.org>
Add periods at the end of sentences in help text.
Drop "a" in one place where it is not needed.
Fix a verb.
Add some capitalization.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
sound/soc/sof/Kconfig | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
index 8c1f0829de40..031dad5fc4c7 100644
--- a/sound/soc/sof/Kconfig
+++ b/sound/soc/sof/Kconfig
@@ -2,7 +2,7 @@
config SND_SOC_SOF_TOPLEVEL
bool "Sound Open Firmware Support"
help
- This adds support for Sound Open Firmware (SOF). SOF is a free and
+ This adds support for Sound Open Firmware (SOF). SOF is free and
generic open source audio DSP firmware for multiple devices.
Say Y if you have such a device that is supported by SOF.
If unsure select "N".
@@ -16,8 +16,8 @@ config SND_SOC_SOF_PCI
select SND_SOC_ACPI if ACPI
help
This adds support for PCI enumeration. This option is
- required to enable Intel Skylake+ devices
- Say Y if you need this option
+ required to enable Intel Skylake+ devices.
+ Say Y if you need this option.
If unsure select "N".
config SND_SOC_SOF_ACPI
@@ -28,8 +28,8 @@ config SND_SOC_SOF_ACPI
select IOSF_MBI if X86 && PCI
help
This adds support for ACPI enumeration. This option is required
- to enable Intel Broadwell/Baytrail/Cherrytrail devices
- Say Y if you need this option
+ to enable Intel Broadwell/Baytrail/Cherrytrail devices.
+ Say Y if you need this option.
If unsure select "N".
config SND_SOC_SOF_OF
@@ -54,12 +54,12 @@ config SND_SOC_SOF_DEVELOPER_SUPPORT
bool "SOF developer options support"
depends on EXPERT
help
- This option unlock SOF developer options for debug/performance/
+ This option unlocks SOF developer options for debug/performance/
code hardening.
Distributions should not select this option, only SOF development
teams should select it.
- Say Y if you are involved in SOF development and need this option
- If not, select N
+ Say Y if you are involved in SOF development and need this option.
+ If not, select N.
if SND_SOC_SOF_DEVELOPER_SUPPORT
@@ -72,13 +72,13 @@ config SND_SOC_SOF_NOCODEC_SUPPORT
This adds support for a dummy/nocodec machine driver fallback
option if no known codec is detected. This is typically only
enabled for developers or devices where the sound card is
- controlled externally
- This option is mutually exclusive with the Intel HDAudio support,
- selecting it may have negative impacts and prevent e.g. microphone
+ controlled externally.
+ This option is mutually exclusive with the Intel HDAudio support.
+ Selecting it may have negative impacts and prevent e.g. microphone
functionality from being enabled on Intel CoffeeLake and later
platforms.
Distributions should not select this option!
- Say Y if you need this nocodec fallback option
+ Say Y if you need this nocodec fallback option.
If unsure select "N".
config SND_SOC_SOF_STRICT_ABI_CHECKS
@@ -92,8 +92,8 @@ config SND_SOC_SOF_STRICT_ABI_CHECKS
is invoked.
This option will stop topology creation and firmware load upfront.
It is intended for SOF CI/releases and not for users or distros.
- Say Y if you want strict ABI checks for an SOF release
- If you are not involved in SOF releases and CI development
+ Say Y if you want strict ABI checks for an SOF release.
+ If you are not involved in SOF releases and CI development,
select "N".
config SND_SOC_SOF_DEBUG
@@ -114,8 +114,8 @@ config SND_SOC_SOF_FORCE_NOCODEC_MODE
though there is a codec detected on the real platform. This is
typically only enabled for developers for debug purposes, before
codec/machine driver is ready, or to exclude the impact of those
- drivers
- Say Y if you need this force nocodec mode option
+ drivers.
+ Say Y if you need this force nocodec mode option.
If unsure select "N".
config SND_SOC_SOF_DEBUG_XRUN_STOP
@@ -137,12 +137,12 @@ config SND_SOC_SOF_DEBUG_VERBOSE_IPC
config SND_SOC_SOF_DEBUG_FORCE_IPC_POSITION
bool "SOF force to use IPC for position update on SKL+"
help
- This option force to handle stream position update IPCs and run pcm
+ This option forces to handle stream position update IPCs and run PCM
elapse to inform ALSA about that, on platforms (e.g. Intel SKL+) that
with other approach (e.g. HDAC DPIB/posbuf) to elapse PCM.
On platforms (e.g. Intel SKL-) where position update IPC is the only
one choice, this setting won't impact anything.
- if you are trying to debug pointer update with position IPCs or where
+ If you are trying to debug pointer update with position IPCs or where
DPIB/posbuf is not ready, select "Y".
If unsure select "N".
@@ -161,7 +161,7 @@ config SND_SOC_SOF_DEBUG_ENABLE_FIRMWARE_TRACE
help
The firmware trace can be enabled either at build-time with
this option, or dynamically by setting flags in the SOF core
- module parameter (similar to dynamic debug)
+ module parameter (similar to dynamic debug).
If unsure, select "N".
config SND_SOC_SOF_DEBUG_IPC_FLOOD_TEST
@@ -190,7 +190,7 @@ config SND_SOC_SOF
select SND_SOC_SOF_NOCODEC if SND_SOC_SOF_NOCODEC_SUPPORT
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
The selection is made at the top level and does not exactly follow
module dependencies but since the module or built-in type is decided
at the top level it doesn't matter.
@@ -199,7 +199,7 @@ config SND_SOC_SOF_PROBE_WORK_QUEUE
bool
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
When selected, the probe is handled in two steps, for example to
avoid lockdeps if request_module is used in the probe.
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/4] ASoC: SOF: Intel: fix Kconfig punctuation and wording
2020-11-11 21:35 [PATCH 0/4] ASoC: SOF: Kconfig corrections Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 1/4] ASoC: SOF: imx: fix Kconfig punctuation Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 2/4] ASoC: SOF: Kconfig: fix Kconfig punctuation and wording Pierre-Louis Bossart
@ 2020-11-11 21:35 ` Pierre-Louis Bossart
2020-11-12 15:07 ` Mark Brown
2020-11-11 21:35 ` [PATCH 4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG Pierre-Louis Bossart
2020-11-12 19:39 ` [PATCH 0/4] ASoC: SOF: Kconfig corrections Mark Brown
4 siblings, 1 reply; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-11-11 21:35 UTC (permalink / raw
To: alsa-devel
Cc: Guennadi Liakhovetski, tiwai, Randy Dunlap, Ranjani Sridharan,
Pierre-Louis Bossart, broonie, Rander Wang
From: Randy Dunlap <rdunlap@infradead.org>
Add periods at the end of sentences in help text.
Insert a "not" in one place.
Fix help text indentation.
Remove a duplicate "Intel(R)" in one place.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
sound/soc/sof/intel/Kconfig | 62 ++++++++++++++++++-------------------
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index d44acbabda5f..720dce5d7d1e 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -15,7 +15,7 @@ config SND_SOC_SOF_INTEL_ACPI
select SND_SOC_SOF_BROADWELL if SND_SOC_SOF_BROADWELL_SUPPORT
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_INTEL_PCI
def_tristate SND_SOC_SOF_PCI
@@ -32,13 +32,13 @@ config SND_SOC_SOF_INTEL_PCI
select SND_SOC_SOF_ALDERLAKE if SND_SOC_SOF_ALDERLAKE_SUPPORT
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_INTEL_HIFI_EP_IPC
tristate
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_INTEL_ATOM_HIFI_EP
tristate
@@ -46,7 +46,7 @@ config SND_SOC_SOF_INTEL_ATOM_HIFI_EP
select SND_SOC_SOF_INTEL_HIFI_EP_IPC
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_INTEL_COMMON
tristate
@@ -56,7 +56,7 @@ config SND_SOC_SOF_INTEL_COMMON
select SND_SOC_ACPI if ACPI
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
if SND_SOC_SOF_INTEL_ACPI
@@ -73,7 +73,7 @@ config SND_SOC_SOF_BAYTRAIL_SUPPORT
recommended for distros. At some point all legacy drivers will be
deprecated but not before all userspace firmware/topology/UCM files
are made available to downstream distros.
- Say Y if you want to enable SOF on Baytrail/Cherrytrail
+ Say Y if you want to enable SOF on Baytrail/Cherrytrail.
If unsure select "N".
config SND_SOC_SOF_BAYTRAIL
@@ -81,7 +81,7 @@ config SND_SOC_SOF_BAYTRAIL
select SND_SOC_SOF_INTEL_ATOM_HIFI_EP
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_BROADWELL_SUPPORT
bool "SOF support for Broadwell"
@@ -92,11 +92,11 @@ config SND_SOC_SOF_BROADWELL_SUPPORT
This option is mutually exclusive with the Haswell/Broadwell legacy
driver. If you want to enable SOF on Broadwell you need to deselect
the legacy driver first.
- SOF does fully support Broadwell yet, so this option is not
+ SOF does not fully support Broadwell yet, so this option is not
recommended for distros. At some point all legacy drivers will be
deprecated but not before all userspace firmware/topology/UCM files
are made available to downstream distros.
- Say Y if you want to enable SOF on Broadwell
+ Say Y if you want to enable SOF on Broadwell.
If unsure select "N".
config SND_SOC_SOF_BROADWELL
@@ -105,7 +105,7 @@ config SND_SOC_SOF_BROADWELL
select SND_SOC_SOF_INTEL_HIFI_EP_IPC
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
endif ## SND_SOC_SOF_INTEL_ACPI
@@ -124,7 +124,7 @@ config SND_SOC_SOF_MERRIFIELD
select SND_SOC_SOF_INTEL_ATOM_HIFI_EP
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_APOLLOLAKE_SUPPORT
bool "SOF support for Apollolake"
@@ -139,7 +139,7 @@ config SND_SOC_SOF_APOLLOLAKE
select SND_SOC_SOF_HDA_COMMON
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_GEMINILAKE_SUPPORT
bool "SOF support for GeminiLake"
@@ -154,7 +154,7 @@ config SND_SOC_SOF_GEMINILAKE
select SND_SOC_SOF_HDA_COMMON
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_CANNONLAKE_SUPPORT
bool "SOF support for Cannonlake"
@@ -170,7 +170,7 @@ config SND_SOC_SOF_CANNONLAKE
select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_COFFEELAKE_SUPPORT
bool "SOF support for CoffeeLake"
@@ -186,7 +186,7 @@ config SND_SOC_SOF_COFFEELAKE
select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_ICELAKE_SUPPORT
bool "SOF support for Icelake"
@@ -202,7 +202,7 @@ config SND_SOC_SOF_ICELAKE
select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_COMETLAKE
tristate
@@ -210,7 +210,7 @@ config SND_SOC_SOF_COMETLAKE
select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_COMETLAKE_SUPPORT
bool
@@ -237,7 +237,7 @@ config SND_SOC_SOF_TIGERLAKE
select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_ELKHARTLAKE_SUPPORT
bool "SOF support for ElkhartLake"
@@ -253,7 +253,7 @@ config SND_SOC_SOF_ELKHARTLAKE
select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_JASPERLAKE_SUPPORT
bool "SOF support for JasperLake"
@@ -268,7 +268,7 @@ config SND_SOC_SOF_JASPERLAKE
select SND_SOC_SOF_HDA_COMMON
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_ALDERLAKE_SUPPORT
bool "SOF support for Alderlake"
@@ -291,7 +291,7 @@ config SND_SOC_SOF_HDA_COMMON
select SND_SOC_SOF_HDA_LINK_BASELINE
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
if SND_SOC_SOF_HDA_COMMON
@@ -301,7 +301,7 @@ config SND_SOC_SOF_HDA_LINK
select SND_SOC_SOF_PROBE_WORK_QUEUE
help
This adds support for HDA links(HDA/HDMI) with Sound Open Firmware
- for Intel(R) platforms.
+ for Intel(R) platforms.
Say Y if you want to enable HDA links with SOF.
If unsure select "N".
@@ -310,7 +310,7 @@ config SND_SOC_SOF_HDA_AUDIO_CODEC
depends on SND_SOC_SOF_HDA_LINK
help
This adds support for HDAudio codecs with Sound Open Firmware
- for Intel(R) platforms.
+ for Intel(R) platforms.
Say Y if you want to enable HDAudio codecs with SOF.
If unsure select "N".
@@ -318,8 +318,8 @@ config SND_SOC_SOF_HDA_PROBES
bool "SOF enable probes over HDA"
depends on SND_SOC_SOF_DEBUG_PROBES
help
- This option enables the data probing for Intel(R).
- Intel(R) Skylake and newer platforms.
+ This option enables the data probing for Intel(R)
+ Skylake and newer platforms.
Say Y if you want to enable probes.
If unsure, select "N".
@@ -330,7 +330,7 @@ config SND_SOC_SOF_HDA_ALWAYS_ENABLE_DMI_L1
and disables known workarounds for specific HDAudio platforms.
Only use to look into power optimizations on platforms not
affected by DMI L1 issues. This option is not recommended.
- Say Y if you want to enable DMI Link L1
+ Say Y if you want to enable DMI Link L1.
If unsure, select "N".
endif ## SND_SOC_SOF_HDA_COMMON
@@ -340,7 +340,7 @@ config SND_SOC_SOF_HDA_LINK_BASELINE
select SND_SOC_SOF_HDA if SND_SOC_SOF_HDA_LINK
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_HDA
tristate
@@ -349,14 +349,14 @@ config SND_SOC_SOF_HDA
select SND_INTEL_DSP_CONFIG
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
bool "SOF support for SoundWire"
depends on SOUNDWIRE && ACPI
help
This adds support for SoundWire with Sound Open Firmware
- for Intel(R) platforms.
+ for Intel(R) platforms.
Say Y if you want to enable SoundWire links with SOF.
If unsure select "N".
@@ -365,14 +365,14 @@ config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
select SND_SOC_SOF_INTEL_SOUNDWIRE if SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
config SND_SOC_SOF_INTEL_SOUNDWIRE
tristate
select SOUNDWIRE_INTEL
help
This option is not user-selectable but automagically handled by
- 'select' statements at a higher level
+ 'select' statements at a higher level.
endif ## SND_SOC_SOF_INTEL_PCI
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG
2020-11-11 21:35 [PATCH 0/4] ASoC: SOF: Kconfig corrections Pierre-Louis Bossart
` (2 preceding siblings ...)
2020-11-11 21:35 ` [PATCH 3/4] ASoC: SOF: Intel: " Pierre-Louis Bossart
@ 2020-11-11 21:35 ` Pierre-Louis Bossart
2020-11-12 15:12 ` Mark Brown
2020-11-12 19:39 ` [PATCH 0/4] ASoC: SOF: Kconfig corrections Mark Brown
4 siblings, 1 reply; 8+ messages in thread
From: Pierre-Louis Bossart @ 2020-11-11 21:35 UTC (permalink / raw
To: alsa-devel
Cc: tiwai, broonie, Randy Dunlap, Pierre-Louis Bossart,
Ranjani Sridharan
SND_INTEL_DSP_CONFIG is selected by the HDaudio, Skylake and SOF
drivers. When the HDaudio link is not selected as a option, this
Kconfig option is not touched and will default to whatever other
drivers selected. In the case e.g. where HDaudio is compiled as
built-in, the linker will complain:
ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe':
sof-pci-dev.c:(.text+0x5c): undefined reference to
`snd_intel_dsp_driver_probe'
Adding the select for all HDaudio platforms, regardless of whether
they rely on the HDaudio link or not, solves the problem.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 82d9d54a6c0ee ('ALSA: hda: add Intel DSP configuration / probe code')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
sound/soc/sof/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index 720dce5d7d1e..b607dba5fb2a 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -287,6 +287,7 @@ config SND_SOC_SOF_ALDERLAKE
config SND_SOC_SOF_HDA_COMMON
tristate
+ select SND_INTEL_DSP_CONFIG
select SND_SOC_SOF_INTEL_COMMON
select SND_SOC_SOF_HDA_LINK_BASELINE
help
@@ -346,7 +347,6 @@ config SND_SOC_SOF_HDA
tristate
select SND_HDA_EXT_CORE if SND_SOC_SOF_HDA_LINK
select SND_SOC_HDAC_HDA if SND_SOC_SOF_HDA_AUDIO_CODEC
- select SND_INTEL_DSP_CONFIG
help
This option is not user-selectable but automagically handled by
'select' statements at a higher level.
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] ASoC: SOF: Intel: fix Kconfig punctuation and wording
2020-11-11 21:35 ` [PATCH 3/4] ASoC: SOF: Intel: " Pierre-Louis Bossart
@ 2020-11-12 15:07 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-11-12 15:07 UTC (permalink / raw
To: Pierre-Louis Bossart
Cc: Guennadi Liakhovetski, alsa-devel, tiwai, Randy Dunlap,
Ranjani Sridharan, Rander Wang
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Wed, Nov 11, 2020 at 03:35:32PM -0600, Pierre-Louis Bossart wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Add periods at the end of sentences in help text.
> Insert a "not" in one place.
> Fix help text indentation.
> Remove a duplicate "Intel(R)" in one place.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG
2020-11-11 21:35 ` [PATCH 4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG Pierre-Louis Bossart
@ 2020-11-12 15:12 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-11-12 15:12 UTC (permalink / raw
To: Pierre-Louis Bossart; +Cc: tiwai, alsa-devel, Randy Dunlap, Ranjani Sridharan
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Wed, Nov 11, 2020 at 03:35:33PM -0600, Pierre-Louis Bossart wrote:
> SND_INTEL_DSP_CONFIG is selected by the HDaudio, Skylake and SOF
> drivers. When the HDaudio link is not selected as a option, this
> Kconfig option is not touched and will default to whatever other
> drivers selected. In the case e.g. where HDaudio is compiled as
> built-in, the linker will complain:
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] ASoC: SOF: Kconfig corrections
2020-11-11 21:35 [PATCH 0/4] ASoC: SOF: Kconfig corrections Pierre-Louis Bossart
` (3 preceding siblings ...)
2020-11-11 21:35 ` [PATCH 4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG Pierre-Louis Bossart
@ 2020-11-12 19:39 ` Mark Brown
4 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-11-12 19:39 UTC (permalink / raw
To: alsa-devel, Pierre-Louis Bossart; +Cc: tiwai
On Wed, 11 Nov 2020 15:35:29 -0600, Pierre-Louis Bossart wrote:
> Three cosmetic patches and a fix for a randconfig issue.
>
> Pierre-Louis Bossart (1):
> ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG
>
> Randy Dunlap (3):
> ASoC: SOF: imx: fix Kconfig punctuation
> ASoC: SOF: Kconfig: fix Kconfig punctuation and wording
> ASoC: SOF: Intel: fix Kconfig punctuation and wording
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/4] ASoC: SOF: imx: fix Kconfig punctuation
commit: 724d53f6a0f318390630a50ee713fa19a927fa23
[2/4] ASoC: SOF: Kconfig: fix Kconfig punctuation and wording
commit: aff581aee84079b89e796d6ab26560c88d1dcd7a
[3/4] ASoC: SOF: Intel: fix Kconfig punctuation and wording
commit: 66e1b65128c2bf884d39589a8308dd115c5eba67
[4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG
commit: 358f0ac1f2791c80c19cc26706cf34664c9fd756
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-12 19:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-11 21:35 [PATCH 0/4] ASoC: SOF: Kconfig corrections Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 1/4] ASoC: SOF: imx: fix Kconfig punctuation Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 2/4] ASoC: SOF: Kconfig: fix Kconfig punctuation and wording Pierre-Louis Bossart
2020-11-11 21:35 ` [PATCH 3/4] ASoC: SOF: Intel: " Pierre-Louis Bossart
2020-11-12 15:07 ` Mark Brown
2020-11-11 21:35 ` [PATCH 4/4] ASoC: SOF: Intel: fix Kconfig dependency for SND_INTEL_DSP_CONFIG Pierre-Louis Bossart
2020-11-12 15:12 ` Mark Brown
2020-11-12 19:39 ` [PATCH 0/4] ASoC: SOF: Kconfig corrections Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.