From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F96C5519F for ; Mon, 16 Nov 2020 14:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FE1422314 for ; Mon, 16 Nov 2020 14:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730331AbgKPOpc (ORCPT ); Mon, 16 Nov 2020 09:45:32 -0500 Received: from mga02.intel.com ([134.134.136.20]:26603 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728041AbgKPOpb (ORCPT ); Mon, 16 Nov 2020 09:45:31 -0500 IronPort-SDR: SV0RgNc9V2rbNdYojCQwX8E2WXzCOvvTGTZ4sbSHvSqun1dmrUzXVBzk0wNLVXRZllNAHxEDTN XDddjRaxYNsg== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="157780272" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="157780272" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 06:45:30 -0800 IronPort-SDR: 5OC54gy0gRe8XOTq+Vy7cP6Z9Lgy9X+1KcDyJ9xyyzZwQLChspDHQVniS6NuTI0gvKAFdp7B4u 4B86Di3pjGMA== X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="531869408" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 06:45:28 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kefm3-0075VI-35; Mon, 16 Nov 2020 16:46:31 +0200 Date: Mon, 16 Nov 2020 16:46:31 +0200 From: Andy Shevchenko To: Claudius Heine Cc: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Henning Schild , Johannes Hahn Subject: Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C Message-ID: <20201116144631.GB1689012@smile.fi.intel.com> References: <20201112130734.331094-1-ch@denx.de> <20201112130734.331094-3-ch@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112130734.331094-3-ch@denx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 02:07:33PM +0100, Claudius Heine wrote: > From: Johannes Hahn > > This allows the RX6110 driver to be automatically assigned to the right > device on the I2C bus. Before adding new ACPI ID, can you provide an evidence (either from vendor of the component, or a real snapshot of DSDT from device on market) that this is real ID? Before that happens, NAK. P.S. Seems to me that this is kinda cargo cult patch because proposed ID is against ACPI and PNP registry and ACPI specification. -- With Best Regards, Andy Shevchenko