From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Fri, 8 Jan 2021 22:37:37 +0100
Subject: [Buildroot] [PATCH] support/scripts/pkg-stats: properly handle
 host packages with -c option
In-Reply-To: <20210107223447.4a2b8674@windsurf.home>
References: <20210107211336.3030397-1-thomas.petazzoni@bootlin.com>
 <20210107211336.3030397-2-thomas.petazzoni@bootlin.com>
 <20210107213207.GO1485369@scaer>
 <20210107223447.4a2b8674@windsurf.home>
Message-ID: <20210108213737.GP1485369@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Thomas, All,

On 2021-01-07 22:34 +0100, Thomas Petazzoni spake thusly:
> On Thu, 7 Jan 2021 22:32:07 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
> > I think the correct fix would be for the json output to already contain
> > the base name of the package, and the script to use that field, rather
> > than the key, as a package name. That way, the behaviour would be the
> > same for both target and host packages.
> 
> Right, that could certainly work as well.
> 
> > 
> > Something like:
> > 
> >     diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> >     index a2cc160d0b..0f9d612f12 100644
> >     --- a/package/pkg-utils.mk
> >     +++ b/package/pkg-utils.mk
> >     @@ -91,6 +91,7 @@ endef
> >      # $(1): upper-case package or filesystem name
> >      define json-info
> >      	"$($(1)_NAME)": {
> >     +		"name": "$($(1)_RAWNAME)",
> 
> "name" or "rawname" ?

"rawname" is a detail of the naming of our internal variables. WE do not
want to propagate that to the outside world.

"name" is really that: the name of the package, by which people know it
and talk about.

Regards,
Yann E. MORIN.

> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'