All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/xenomai: set 'custom' as version in case of tarball
@ 2021-01-31 21:27 Thomas De Schampheleire
  2021-02-01 17:25 ` Peter Korsgaard
  2021-02-03 17:49 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2021-01-31 21:27 UTC (permalink / raw
  To: buildroot

From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

When BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL is selected, the xenomai package
declared an empty version, which among others means that the build directory
becomes output/build/xenomai without any version specification, and empty
version information in 'xenomai-show-info'.

Other packages that allow a custom tarball, like 'linux' and
'arm-trusted-firmware', specify 'custom' as version in this case.

Adapt the xenomai package accordingly.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 package/xenomai/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
index 452b452039..b655733528 100644
--- a/package/xenomai/Config.in
+++ b/package/xenomai/Config.in
@@ -69,9 +69,11 @@ config BR2_PACKAGE_XENOMAI_REPOSITORY
 	depends on BR2_PACKAGE_XENOMAI_CUSTOM_GIT
 
 config BR2_PACKAGE_XENOMAI_VERSION
-	string "Custom Xenomai version" if !BR2_PACKAGE_XENOMAI_LATEST_VERSION
+	string "Custom Xenomai version" if \
+		!BR2_PACKAGE_XENOMAI_LATEST_VERSION && \
+		!BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
 	default "3.0.10" if BR2_PACKAGE_XENOMAI_LATEST_VERSION
-	depends on !BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
+	default "custom" if BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
 
 config BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL_URL
 	string "URL of custom tarball"
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/xenomai: set 'custom' as version in case of tarball
  2021-01-31 21:27 [Buildroot] [PATCH] package/xenomai: set 'custom' as version in case of tarball Thomas De Schampheleire
@ 2021-02-01 17:25 ` Peter Korsgaard
  2021-02-03 17:49 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-02-01 17:25 UTC (permalink / raw
  To: buildroot

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > When BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL is selected, the xenomai package
 > declared an empty version, which among others means that the build directory
 > becomes output/build/xenomai without any version specification, and empty
 > version information in 'xenomai-show-info'.

 > Other packages that allow a custom tarball, like 'linux' and
 > 'arm-trusted-firmware', specify 'custom' as version in this case.

 > Adapt the xenomai package accordingly.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/xenomai: set 'custom' as version in case of tarball
  2021-01-31 21:27 [Buildroot] [PATCH] package/xenomai: set 'custom' as version in case of tarball Thomas De Schampheleire
  2021-02-01 17:25 ` Peter Korsgaard
@ 2021-02-03 17:49 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-02-03 17:49 UTC (permalink / raw
  To: buildroot

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > When BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL is selected, the xenomai package
 > declared an empty version, which among others means that the build directory
 > becomes output/build/xenomai without any version specification, and empty
 > version information in 'xenomai-show-info'.

 > Other packages that allow a custom tarball, like 'linux' and
 > 'arm-trusted-firmware', specify 'custom' as version in this case.

 > Adapt the xenomai package accordingly.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed to 2020.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-03 17:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-31 21:27 [Buildroot] [PATCH] package/xenomai: set 'custom' as version in case of tarball Thomas De Schampheleire
2021-02-01 17:25 ` Peter Korsgaard
2021-02-03 17:49 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.