* [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
This RFC is based on the discussion going on the linux-fsdevel [1].
I've tested this on the brd and null_blk. The fio verify job seems to
run without any error on the top of the original series applied [1].
Any feedback is welcome to move this forward.
-ck
[1] https://lore.kernel.org/linux-fsdevel/20210205232304.1670522-1-ira.weiny@intel.com/T/#m53145c155fa3631595594877da96a3a75b71e909
Chaitanya Kulkarni (8):
brd: use memcpy_from_page() in copy_from_brd()
brd: use memcpy_from_page() in copy_from_brd()
null_blk: use memcpy_page() in copy_to_nullb()
null_blk: use memcpy_page() in copy_from_nullb()
ext4: use memcpy_from_page() in pagecache_read()
ext4: use memcpy_to_page() in pagecache_write()
f2fs: use memcpy_from_page() in pagecache_read()
f2fs: use memcpy_to_page() in pagecache_write()
drivers/block/brd.c | 17 ++++++-----------
drivers/block/null_blk/main.c | 23 ++++++-----------------
fs/ext4/verity.c | 10 ++--------
fs/f2fs/verity.c | 10 ++--------
4 files changed, 16 insertions(+), 44 deletions(-)
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* [RFC PATCH 0/8] use core page calls instead of kmaps
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
This RFC is based on the discussion going on the linux-fsdevel [1].
I've tested this on the brd and null_blk. The fio verify job seems to
run without any error on the top of the original series applied [1].
Any feedback is welcome to move this forward.
-ck
[1] https://lore.kernel.org/linux-fsdevel/20210205232304.1670522-1-ira.weiny@intel.com/T/#m53145c155fa3631595594877da96a3a75b71e909
Chaitanya Kulkarni (8):
brd: use memcpy_from_page() in copy_from_brd()
brd: use memcpy_from_page() in copy_from_brd()
null_blk: use memcpy_page() in copy_to_nullb()
null_blk: use memcpy_page() in copy_from_nullb()
ext4: use memcpy_from_page() in pagecache_read()
ext4: use memcpy_to_page() in pagecache_write()
f2fs: use memcpy_from_page() in pagecache_read()
f2fs: use memcpy_to_page() in pagecache_write()
drivers/block/brd.c | 17 ++++++-----------
drivers/block/null_blk/main.c | 23 ++++++-----------------
fs/ext4/verity.c | 10 ++--------
fs/f2fs/verity.c | 10 ++--------
4 files changed, 16 insertions(+), 44 deletions(-)
--
2.22.1
^ permalink raw reply [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 1/8] brd: use memcpy_from_page() in copy_from_brd()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/brd.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index cb5c872ac9b2..d41b7d489e9f 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -226,11 +226,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
copy = min_t(size_t, n, PAGE_SIZE - offset);
page = brd_lookup_page(brd, sector);
- if (page) {
- src = kmap_atomic(page);
- memcpy(dst, src + offset, copy);
- kunmap_atomic(src);
- } else
+ if (page)
+ memcpy_from_page(dst, page, offset, copy);
+ else
memset(dst, 0, copy);
if (copy < n) {
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 1/8] brd: use memcpy_from_page() in copy_from_brd()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/brd.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index cb5c872ac9b2..d41b7d489e9f 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -226,11 +226,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
copy = min_t(size_t, n, PAGE_SIZE - offset);
page = brd_lookup_page(brd, sector);
- if (page) {
- src = kmap_atomic(page);
- memcpy(dst, src + offset, copy);
- kunmap_atomic(src);
- } else
+ if (page)
+ memcpy_from_page(dst, page, offset, copy);
+ else
memset(dst, 0, copy);
if (copy < n) {
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/brd.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index d41b7d489e9f..c1f6d768a1b3 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -220,7 +220,6 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
sector_t sector, size_t n)
{
struct page *page;
- void *src;
unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
size_t copy;
@@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
sector += copy >> SECTOR_SHIFT;
copy = n - copy;
page = brd_lookup_page(brd, sector);
- if (page) {
- src = kmap_atomic(page);
- memcpy(dst, src, copy);
- kunmap_atomic(src);
- } else
+ if (page)
+ memcpy_from_page(dst, page, offset, copy);
+ else
memset(dst, 0, copy);
}
}
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/brd.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index d41b7d489e9f..c1f6d768a1b3 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -220,7 +220,6 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
sector_t sector, size_t n)
{
struct page *page;
- void *src;
unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
size_t copy;
@@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
sector += copy >> SECTOR_SHIFT;
copy = n - copy;
page = brd_lookup_page(brd, sector);
- if (page) {
- src = kmap_atomic(page);
- memcpy(dst, src, copy);
- kunmap_atomic(src);
- } else
+ if (page)
+ memcpy_from_page(dst, page, offset, copy);
+ else
memset(dst, 0, copy);
}
}
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 3/8] null_blk: use memcpy_page() in copy_to_nullb()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/null_blk/main.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index d6c821d48090..c9b6db82b07c 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1010,7 +1010,6 @@ static int copy_to_nullb(struct nullb *nullb, struct page *source,
size_t temp, count = 0;
unsigned int offset;
struct nullb_page *t_page;
- void *dst, *src;
while (count < n) {
temp = min_t(size_t, nullb->dev->blocksize, n - count);
@@ -1024,11 +1023,7 @@ static int copy_to_nullb(struct nullb *nullb, struct page *source,
if (!t_page)
return -ENOSPC;
- src = kmap_atomic(source);
- dst = kmap_atomic(t_page->page);
- memcpy(dst + offset, src + off + count, temp);
- kunmap_atomic(dst);
- kunmap_atomic(src);
+ memcpy_page(t_page->page, offset, source, off + count, temp);
__set_bit(sector & SECTOR_MASK, t_page->bitmap);
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 3/8] null_blk: use memcpy_page() in copy_to_nullb()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/null_blk/main.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index d6c821d48090..c9b6db82b07c 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1010,7 +1010,6 @@ static int copy_to_nullb(struct nullb *nullb, struct page *source,
size_t temp, count = 0;
unsigned int offset;
struct nullb_page *t_page;
- void *dst, *src;
while (count < n) {
temp = min_t(size_t, nullb->dev->blocksize, n - count);
@@ -1024,11 +1023,7 @@ static int copy_to_nullb(struct nullb *nullb, struct page *source,
if (!t_page)
return -ENOSPC;
- src = kmap_atomic(source);
- dst = kmap_atomic(t_page->page);
- memcpy(dst + offset, src + off + count, temp);
- kunmap_atomic(dst);
- kunmap_atomic(src);
+ memcpy_page(t_page->page, offset, source, off + count, temp);
__set_bit(sector & SECTOR_MASK, t_page->bitmap);
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 4/8] null_blk: use memcpy_page() in copy_from_nullb()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/null_blk/main.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index c9b6db82b07c..1c0e1a295e90 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1042,7 +1042,6 @@ static int copy_from_nullb(struct nullb *nullb, struct page *dest,
size_t temp, count = 0;
unsigned int offset;
struct nullb_page *t_page;
- void *dst, *src;
while (count < n) {
temp = min_t(size_t, nullb->dev->blocksize, n - count);
@@ -1051,16 +1050,11 @@ static int copy_from_nullb(struct nullb *nullb, struct page *dest,
t_page = null_lookup_page(nullb, sector, false,
!null_cache_active(nullb));
- dst = kmap_atomic(dest);
- if (!t_page) {
- memset(dst + off + count, 0, temp);
- goto next;
- }
- src = kmap_atomic(t_page->page);
- memcpy(dst + off + count, src + offset, temp);
- kunmap_atomic(src);
-next:
- kunmap_atomic(dst);
+ if (t_page)
+ memcpy_page(dest, off + count, t_page->page, offset,
+ temp);
+ else
+ zero_user(dest, off + count, temp);
count += temp;
sector += temp >> SECTOR_SHIFT;
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 4/8] null_blk: use memcpy_page() in copy_from_nullb()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/null_blk/main.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index c9b6db82b07c..1c0e1a295e90 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1042,7 +1042,6 @@ static int copy_from_nullb(struct nullb *nullb, struct page *dest,
size_t temp, count = 0;
unsigned int offset;
struct nullb_page *t_page;
- void *dst, *src;
while (count < n) {
temp = min_t(size_t, nullb->dev->blocksize, n - count);
@@ -1051,16 +1050,11 @@ static int copy_from_nullb(struct nullb *nullb, struct page *dest,
t_page = null_lookup_page(nullb, sector, false,
!null_cache_active(nullb));
- dst = kmap_atomic(dest);
- if (!t_page) {
- memset(dst + off + count, 0, temp);
- goto next;
- }
- src = kmap_atomic(t_page->page);
- memcpy(dst + off + count, src + offset, temp);
- kunmap_atomic(src);
-next:
- kunmap_atomic(dst);
+ if (t_page)
+ memcpy_page(dest, off + count, t_page->page, offset,
+ temp);
+ else
+ zero_user(dest, off + count, temp);
count += temp;
sector += temp >> SECTOR_SHIFT;
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/ext4/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c
index 5b7ba8f71153..c8e07f8a792d 100644
--- a/fs/ext4/verity.c
+++ b/fs/ext4/verity.c
@@ -45,16 +45,13 @@ static int pagecache_read(struct inode *inode, void *buf, size_t count,
size_t n = min_t(size_t, count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
- void *addr;
page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT,
NULL);
if (IS_ERR(page))
return PTR_ERR(page);
- addr = kmap_atomic(page);
- memcpy(buf, addr + offset_in_page(pos), n);
- kunmap_atomic(addr);
+ memcpy_from_page(buf, page, offset_in_page(pos), n);
put_page(page);
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/ext4/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c
index 5b7ba8f71153..c8e07f8a792d 100644
--- a/fs/ext4/verity.c
+++ b/fs/ext4/verity.c
@@ -45,16 +45,13 @@ static int pagecache_read(struct inode *inode, void *buf, size_t count,
size_t n = min_t(size_t, count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
- void *addr;
page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT,
NULL);
if (IS_ERR(page))
return PTR_ERR(page);
- addr = kmap_atomic(page);
- memcpy(buf, addr + offset_in_page(pos), n);
- kunmap_atomic(addr);
+ memcpy_from_page(buf, page, offset_in_page(pos), n);
put_page(page);
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/ext4/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c
index c8e07f8a792d..cc4b046490b0 100644
--- a/fs/ext4/verity.c
+++ b/fs/ext4/verity.c
@@ -77,7 +77,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
void *fsdata;
- void *addr;
int res;
res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,
@@ -85,9 +84,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
if (res)
return res;
- addr = kmap_atomic(page);
- memcpy(addr + offset_in_page(pos), buf, n);
- kunmap_atomic(addr);
+ memcpy_to_page(page, offset_in_page(pos), buf, n);
res = pagecache_write_end(NULL, inode->i_mapping, pos, n, n,
page, fsdata);
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/ext4/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c
index c8e07f8a792d..cc4b046490b0 100644
--- a/fs/ext4/verity.c
+++ b/fs/ext4/verity.c
@@ -77,7 +77,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
void *fsdata;
- void *addr;
int res;
res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,
@@ -85,9 +84,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
if (res)
return res;
- addr = kmap_atomic(page);
- memcpy(addr + offset_in_page(pos), buf, n);
- kunmap_atomic(addr);
+ memcpy_to_page(page, offset_in_page(pos), buf, n);
res = pagecache_write_end(NULL, inode->i_mapping, pos, n, n,
page, fsdata);
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 7/8] f2fs: use memcpy_from_page() in pagecache_read()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/f2fs/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
index 054ec852b5ea..44e057bdc416 100644
--- a/fs/f2fs/verity.c
+++ b/fs/f2fs/verity.c
@@ -47,16 +47,13 @@ static int pagecache_read(struct inode *inode, void *buf, size_t count,
size_t n = min_t(size_t, count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
- void *addr;
page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT,
NULL);
if (IS_ERR(page))
return PTR_ERR(page);
- addr = kmap_atomic(page);
- memcpy(buf, addr + offset_in_page(pos), n);
- kunmap_atomic(addr);
+ memcpy_from_page(buf, page, offset_in_page(pos), n);
put_page(page);
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 7/8] f2fs: use memcpy_from_page() in pagecache_read()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/f2fs/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
index 054ec852b5ea..44e057bdc416 100644
--- a/fs/f2fs/verity.c
+++ b/fs/f2fs/verity.c
@@ -47,16 +47,13 @@ static int pagecache_read(struct inode *inode, void *buf, size_t count,
size_t n = min_t(size_t, count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
- void *addr;
page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT,
NULL);
if (IS_ERR(page))
return PTR_ERR(page);
- addr = kmap_atomic(page);
- memcpy(buf, addr + offset_in_page(pos), n);
- kunmap_atomic(addr);
+ memcpy_from_page(buf, page, offset_in_page(pos), n);
put_page(page);
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [f2fs-dev] [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, chaitanya.kulkarni,
dave.hansen, johannes.thumshirn, ebiggers, clm, adilger.kernel,
dongli.zhang, dsterba, jaegeuk, ira.weiny
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/f2fs/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
index 44e057bdc416..ca019685a944 100644
--- a/fs/f2fs/verity.c
+++ b/fs/f2fs/verity.c
@@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
void *fsdata;
- void *addr;
int res;
res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,
@@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
if (res)
return res;
- addr = kmap_atomic(page);
- memcpy(addr + offset_in_page(pos), buf, n);
- kunmap_atomic(addr);
+ memcpy_to_page(page, offset_in_page(pos) buf, n);
res = pagecache_write_end(NULL, inode->i_mapping, pos, n, n,
page, fsdata);
--
2.22.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
@ 2021-02-07 19:04 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:04 UTC (permalink / raw
To: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel
Cc: axboe, tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, chaitanya.kulkarni, dongli.zhang, clm,
ira.weiny, dsterba, ebiggers, hch, dave.hansen
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/f2fs/verity.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
index 44e057bdc416..ca019685a944 100644
--- a/fs/f2fs/verity.c
+++ b/fs/f2fs/verity.c
@@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
PAGE_SIZE - offset_in_page(pos));
struct page *page;
void *fsdata;
- void *addr;
int res;
res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,
@@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
if (res)
return res;
- addr = kmap_atomic(page);
- memcpy(addr + offset_in_page(pos), buf, n);
- kunmap_atomic(addr);
+ memcpy_to_page(page, offset_in_page(pos) buf, n);
res = pagecache_write_end(NULL, inode->i_mapping, pos, n, n,
page, fsdata);
--
2.22.1
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-07 19:10 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:10 UTC (permalink / raw
To: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Cc: axboe@kernel.dk, hch@infradead.org, Damien Le Moal, tytso@mit.edu,
bvanassche@acm.org, dave.hansen@intel.com, Johannes Thumshirn,
ebiggers@kernel.org, clm@fb.com, adilger.kernel@dilger.ca,
dongli.zhang@oracle.com, dsterba@suse.com, jaegeuk@kernel.org,
ira.weiny@intel.com
On 2/7/21 11:04, Chaitanya Kulkarni wrote:
> Chaitanya Kulkarni (8):
> brd: use memcpy_from_page() in copy_from_brd()
> brd: use memcpy_from_page() in copy_from_brd()
I'm aware that couple of places in brd code we can use memcpy_to_page()
and get rid the local variable, once I get some feedback I'll add those
to the V1.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 0/8] use core page calls instead of kmaps
@ 2021-02-07 19:10 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-07 19:10 UTC (permalink / raw
To: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Cc: axboe@kernel.dk, tytso@mit.edu, adilger.kernel@dilger.ca,
jaegeuk@kernel.org, chao@kernel.org, Johannes Thumshirn,
Damien Le Moal, bvanassche@acm.org, dongli.zhang@oracle.com,
clm@fb.com, ira.weiny@intel.com, dsterba@suse.com,
ebiggers@kernel.org, hch@infradead.org, dave.hansen@intel.com
On 2/7/21 11:04, Chaitanya Kulkarni wrote:
> Chaitanya Kulkarni (8):
> brd: use memcpy_from_page() in copy_from_brd()
> brd: use memcpy_from_page() in copy_from_brd()
I'm aware that couple of places in brd code we can use memcpy_to_page()
and get rid the local variable, once I get some feedback I'll add those
to the V1.
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 1/8] brd: use memcpy_from_page() in copy_from_brd()
2021-02-07 19:04 ` Chaitanya Kulkarni
(?)
@ 2021-02-07 22:34 ` kernel test robot
-1 siblings, 0 replies; 40+ messages in thread
From: kernel test robot @ 2021-02-07 22:34 UTC (permalink / raw
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2821 bytes --]
Hi Chaitanya,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on block/for-next]
[also build test ERROR on ext4/dev f2fs/dev-test v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chaitanya-Kulkarni/use-core-page-calls-instead-of-kmaps/20210208-030809
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-m021-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/fa7c5de3afcfa5b284ba9fca9a883f658ad13019
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chaitanya-Kulkarni/use-core-page-calls-instead-of-kmaps/20210208-030809
git checkout fa7c5de3afcfa5b284ba9fca9a883f658ad13019
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/block/brd.c: In function 'copy_from_brd':
>> drivers/block/brd.c:235:3: error: implicit declaration of function 'memcpy_from_page'; did you mean 'memcpy_fromio'? [-Werror=implicit-function-declaration]
235 | memcpy_from_page(dst, page, offset, copy);
| ^~~~~~~~~~~~~~~~
| memcpy_fromio
cc1: some warnings being treated as errors
vim +235 drivers/block/brd.c
220
221 /*
222 * Copy n bytes to dst from the brd starting at sector. Does not sleep.
223 */
224 static void copy_from_brd(void *dst, struct brd_device *brd,
225 sector_t sector, size_t n)
226 {
227 struct page *page;
228 void *src;
229 unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
230 size_t copy;
231
232 copy = min_t(size_t, n, PAGE_SIZE - offset);
233 page = brd_lookup_page(brd, sector);
234 if (page)
> 235 memcpy_from_page(dst, page, offset, copy);
236 else
237 memset(dst, 0, copy);
238
239 if (copy < n) {
240 dst += copy;
241 sector += copy >> SECTOR_SHIFT;
242 copy = n - copy;
243 page = brd_lookup_page(brd, sector);
244 if (page) {
245 src = kmap_atomic(page);
246 memcpy(dst, src, copy);
247 kunmap_atomic(src);
248 } else
249 memset(dst, 0, copy);
250 }
251 }
252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38404 bytes --]
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read()
2021-02-07 19:04 ` Chaitanya Kulkarni
(?)
@ 2021-02-08 1:45 ` kernel test robot
-1 siblings, 0 replies; 40+ messages in thread
From: kernel test robot @ 2021-02-08 1:45 UTC (permalink / raw
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2653 bytes --]
Hi Chaitanya,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on block/for-next]
[also build test ERROR on ext4/dev f2fs/dev-test v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chaitanya-Kulkarni/use-core-page-calls-instead-of-kmaps/20210208-030809
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-m021-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/f431d96c961282073b7a3ab50f622f541f0fa513
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chaitanya-Kulkarni/use-core-page-calls-instead-of-kmaps/20210208-030809
git checkout f431d96c961282073b7a3ab50f622f541f0fa513
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ext4/verity.c: In function 'pagecache_read':
>> fs/ext4/verity.c:54:3: error: implicit declaration of function 'memcpy_from_page'; did you mean 'memcpy_fromio'? [-Werror=implicit-function-declaration]
54 | memcpy_from_page(buf, page, offset_in_page(pos), n);
| ^~~~~~~~~~~~~~~~
| memcpy_fromio
cc1: some warnings being treated as errors
vim +54 fs/ext4/verity.c
36
37 /*
38 * Read some verity metadata from the inode. __vfs_read() can't be used because
39 * we need to read beyond i_size.
40 */
41 static int pagecache_read(struct inode *inode, void *buf, size_t count,
42 loff_t pos)
43 {
44 while (count) {
45 size_t n = min_t(size_t, count,
46 PAGE_SIZE - offset_in_page(pos));
47 struct page *page;
48
49 page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT,
50 NULL);
51 if (IS_ERR(page))
52 return PTR_ERR(page);
53
> 54 memcpy_from_page(buf, page, offset_in_page(pos), n);
55
56 put_page(page);
57
58 buf += n;
59 pos += n;
60 count -= n;
61 }
62 return 0;
63 }
64
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38404 bytes --]
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-08 4:35 ` Ira Weiny
-1 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-02-08 4:35 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: axboe, ebiggers, damien.lemoal, tytso, bvanassche, hch,
johannes.thumshirn, dave.hansen, linux-f2fs-devel, linux-block,
clm, adilger.kernel, dongli.zhang, linux-fsdevel, jaegeuk,
dsterba, linux-ext4
On Sun, Feb 07, 2021 at 11:04:19AM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> drivers/block/brd.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index d41b7d489e9f..c1f6d768a1b3 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -220,7 +220,6 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
> sector_t sector, size_t n)
> {
> struct page *page;
> - void *src;
> unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
> size_t copy;
>
> @@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
> sector += copy >> SECTOR_SHIFT;
> copy = n - copy;
> page = brd_lookup_page(brd, sector);
> - if (page) {
> - src = kmap_atomic(page);
> - memcpy(dst, src, copy);
> - kunmap_atomic(src);
> - } else
> + if (page)
> + memcpy_from_page(dst, page, offset, copy);
Why 'offset'?
Ira
> + else
> memset(dst, 0, copy);
> }
> }
> --
> 2.22.1
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()
@ 2021-02-08 4:35 ` Ira Weiny
0 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-02-08 4:35 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel, axboe,
tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, dongli.zhang, clm, dsterba, ebiggers,
hch, dave.hansen
On Sun, Feb 07, 2021 at 11:04:19AM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> drivers/block/brd.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index d41b7d489e9f..c1f6d768a1b3 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -220,7 +220,6 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
> sector_t sector, size_t n)
> {
> struct page *page;
> - void *src;
> unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
> size_t copy;
>
> @@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
> sector += copy >> SECTOR_SHIFT;
> copy = n - copy;
> page = brd_lookup_page(brd, sector);
> - if (page) {
> - src = kmap_atomic(page);
> - memcpy(dst, src, copy);
> - kunmap_atomic(src);
> - } else
> + if (page)
> + memcpy_from_page(dst, page, offset, copy);
Why 'offset'?
Ira
> + else
> memset(dst, 0, copy);
> }
> }
> --
> 2.22.1
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps
2021-02-07 19:10 ` Chaitanya Kulkarni
@ 2021-02-08 4:42 ` Ira Weiny
-1 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-02-08 4:42 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: axboe@kernel.dk, ebiggers@kernel.org, Damien Le Moal,
tytso@mit.edu, bvanassche@acm.org, hch@infradead.org,
Johannes Thumshirn, dave.hansen@intel.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, clm@fb.com, adilger.kernel@dilger.ca,
dongli.zhang@oracle.com, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, dsterba@suse.com, linux-ext4@vger.kernel.org
On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote:
> On 2/7/21 11:04, Chaitanya Kulkarni wrote:
> > Chaitanya Kulkarni (8):
> > brd: use memcpy_from_page() in copy_from_brd()
> > brd: use memcpy_from_page() in copy_from_brd()
> I'm aware that couple of places in brd code we can use memcpy_to_page()
> and get rid the local variable, once I get some feedback I'll add those
> to the V1.
Except for the one comment I had this series look's good to me.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Thanks!
Ira
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 0/8] use core page calls instead of kmaps
@ 2021-02-08 4:42 ` Ira Weiny
0 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-02-08 4:42 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, axboe@kernel.dk, tytso@mit.edu,
adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org,
Johannes Thumshirn, Damien Le Moal, bvanassche@acm.org,
dongli.zhang@oracle.com, clm@fb.com, dsterba@suse.com,
ebiggers@kernel.org, hch@infradead.org, dave.hansen@intel.com
On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote:
> On 2/7/21 11:04, Chaitanya Kulkarni wrote:
> > Chaitanya Kulkarni (8):
> > brd: use memcpy_from_page() in copy_from_brd()
> > brd: use memcpy_from_page() in copy_from_brd()
> I'm aware that couple of places in brd code we can use memcpy_to_page()
> and get rid the local variable, once I get some feedback I'll add those
> to the V1.
Except for the one comment I had this series look's good to me.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Thanks!
Ira
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps
2021-02-08 4:42 ` Ira Weiny
@ 2021-02-08 5:47 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-08 5:47 UTC (permalink / raw
To: Ira Weiny
Cc: axboe@kernel.dk, ebiggers@kernel.org, Damien Le Moal,
tytso@mit.edu, bvanassche@acm.org, hch@infradead.org,
Johannes Thumshirn, dave.hansen@intel.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, clm@fb.com, adilger.kernel@dilger.ca,
dongli.zhang@oracle.com, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, dsterba@suse.com, linux-ext4@vger.kernel.org
On 2/7/21 20:42, Ira Weiny wrote:
> On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote:
>> On 2/7/21 11:04, Chaitanya Kulkarni wrote:
>>> Chaitanya Kulkarni (8):
>>> brd: use memcpy_from_page() in copy_from_brd()
>>> brd: use memcpy_from_page() in copy_from_brd()
>> I'm aware that couple of places in brd code we can use memcpy_to_page()
>> and get rid the local variable, once I get some feedback I'll add those
>> to the V1.
> Except for the one comment I had this series look's good to me.
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> Thanks!
> Ira
>
>
Thanks Ira, I'll add your fix in the V1 and send with your review-by tag,
when this code is upstream.
Thanks a lot for doing this we can get rid of go in null_blk which makes
code smooth.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 0/8] use core page calls instead of kmaps
@ 2021-02-08 5:47 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-08 5:47 UTC (permalink / raw
To: Ira Weiny
Cc: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, axboe@kernel.dk, tytso@mit.edu,
adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org,
Johannes Thumshirn, Damien Le Moal, bvanassche@acm.org,
dongli.zhang@oracle.com, clm@fb.com, dsterba@suse.com,
ebiggers@kernel.org, hch@infradead.org, dave.hansen@intel.com
On 2/7/21 20:42, Ira Weiny wrote:
> On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote:
>> On 2/7/21 11:04, Chaitanya Kulkarni wrote:
>>> Chaitanya Kulkarni (8):
>>> brd: use memcpy_from_page() in copy_from_brd()
>>> brd: use memcpy_from_page() in copy_from_brd()
>> I'm aware that couple of places in brd code we can use memcpy_to_page()
>> and get rid the local variable, once I get some feedback I'll add those
>> to the V1.
> Except for the one comment I had this series look's good to me.
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> Thanks!
> Ira
>
>
Thanks Ira, I'll add your fix in the V1 and send with your review-by tag,
when this code is upstream.
Thanks a lot for doing this we can get rid of go in null_blk which makes
code smooth.
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()
2021-02-08 4:35 ` Ira Weiny
@ 2021-02-08 5:47 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-08 5:47 UTC (permalink / raw
To: Ira Weiny
Cc: axboe@kernel.dk, ebiggers@kernel.org, Damien Le Moal,
tytso@mit.edu, bvanassche@acm.org, hch@infradead.org,
Johannes Thumshirn, dave.hansen@intel.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, clm@fb.com, adilger.kernel@dilger.ca,
dongli.zhang@oracle.com, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, dsterba@suse.com, linux-ext4@vger.kernel.org
>> @@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
>> sector += copy >> SECTOR_SHIFT;
>> copy = n - copy;
>> page = brd_lookup_page(brd, sector);
>> - if (page) {
>> - src = kmap_atomic(page);
>> - memcpy(dst, src, copy);
>> - kunmap_atomic(src);
>> - } else
>> + if (page)
>> + memcpy_from_page(dst, page, offset, copy);
> Why 'offset'?
Will fix it in the V1.
> Ira
>
>> + else
>> memset(dst, 0, copy);
>> }
>> }
>> --
>> 2.22.1
>>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()
@ 2021-02-08 5:47 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-08 5:47 UTC (permalink / raw
To: Ira Weiny
Cc: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, axboe@kernel.dk, tytso@mit.edu,
adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org,
Johannes Thumshirn, Damien Le Moal, bvanassche@acm.org,
dongli.zhang@oracle.com, clm@fb.com, dsterba@suse.com,
ebiggers@kernel.org, hch@infradead.org, dave.hansen@intel.com
>> @@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
>> sector += copy >> SECTOR_SHIFT;
>> copy = n - copy;
>> page = brd_lookup_page(brd, sector);
>> - if (page) {
>> - src = kmap_atomic(page);
>> - memcpy(dst, src, copy);
>> - kunmap_atomic(src);
>> - } else
>> + if (page)
>> + memcpy_from_page(dst, page, offset, copy);
> Why 'offset'?
Will fix it in the V1.
> Ira
>
>> + else
>> memset(dst, 0, copy);
>> }
>> }
>> --
>> 2.22.1
>>
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-02-10 18:01 ` Eric Biggers
-1 siblings, 0 replies; 40+ messages in thread
From: Eric Biggers @ 2021-02-10 18:01 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: axboe, hch, damien.lemoal, tytso, bvanassche, dave.hansen,
johannes.thumshirn, linux-f2fs-devel, linux-block, clm,
adilger.kernel, dongli.zhang, linux-fsdevel, jaegeuk, dsterba,
linux-ext4, ira.weiny
On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
No explanation in commit message? There isn't much explanation needed for this,
but there should be at least one sentence.
Likewise for the other patches.
> fs/f2fs/verity.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
> index 44e057bdc416..ca019685a944 100644
> --- a/fs/f2fs/verity.c
> +++ b/fs/f2fs/verity.c
> @@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
> PAGE_SIZE - offset_in_page(pos));
> struct page *page;
> void *fsdata;
> - void *addr;
> int res;
>
> res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,
> @@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
> if (res)
> return res;
>
> - addr = kmap_atomic(page);
> - memcpy(addr + offset_in_page(pos), buf, n);
> - kunmap_atomic(addr);
> + memcpy_to_page(page, offset_in_page(pos) buf, n);
This is missing a comma between 'offset_in_page(pos)' and 'buf'.
Otherwise the patches to fs/{ext4,f2fs}/verity.c look fine; thanks for doing
this!
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
@ 2021-02-10 18:01 ` Eric Biggers
0 siblings, 0 replies; 40+ messages in thread
From: Eric Biggers @ 2021-02-10 18:01 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel, axboe,
tytso, adilger.kernel, jaegeuk, chao, johannes.thumshirn,
damien.lemoal, bvanassche, dongli.zhang, clm, ira.weiny, dsterba,
hch, dave.hansen
On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
No explanation in commit message? There isn't much explanation needed for this,
but there should be at least one sentence.
Likewise for the other patches.
> fs/f2fs/verity.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
> index 44e057bdc416..ca019685a944 100644
> --- a/fs/f2fs/verity.c
> +++ b/fs/f2fs/verity.c
> @@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
> PAGE_SIZE - offset_in_page(pos));
> struct page *page;
> void *fsdata;
> - void *addr;
> int res;
>
> res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,
> @@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count,
> if (res)
> return res;
>
> - addr = kmap_atomic(page);
> - memcpy(addr + offset_in_page(pos), buf, n);
> - kunmap_atomic(addr);
> + memcpy_to_page(page, offset_in_page(pos) buf, n);
This is missing a comma between 'offset_in_page(pos)' and 'buf'.
Otherwise the patches to fs/{ext4,f2fs}/verity.c look fine; thanks for doing
this!
- Eric
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
2021-02-10 18:01 ` Eric Biggers
@ 2021-02-10 19:41 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-10 19:41 UTC (permalink / raw
To: Eric Biggers
Cc: axboe@kernel.dk, hch@infradead.org, Damien Le Moal, tytso@mit.edu,
bvanassche@acm.org, dave.hansen@intel.com, Johannes Thumshirn,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, clm@fb.com, adilger.kernel@dilger.ca,
dongli.zhang@oracle.com, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, dsterba@suse.com, linux-ext4@vger.kernel.org,
ira.weiny@intel.com
On 2/10/21 10:01, Eric Biggers wrote:
> On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote:
>> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> No explanation in commit message? There isn't much explanation needed for this,
> but there should be at least one sentence.
>
> Likewise for the other patches.
>
Thanks Eric for your comment.
Sent out minimal RFC, I'll add detail explanation also having original
series
in the tree helps.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
@ 2021-02-10 19:41 ` Chaitanya Kulkarni
0 siblings, 0 replies; 40+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-10 19:41 UTC (permalink / raw
To: Eric Biggers
Cc: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, axboe@kernel.dk, tytso@mit.edu,
adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org,
Johannes Thumshirn, Damien Le Moal, bvanassche@acm.org,
dongli.zhang@oracle.com, clm@fb.com, ira.weiny@intel.com,
dsterba@suse.com, hch@infradead.org, dave.hansen@intel.com
On 2/10/21 10:01, Eric Biggers wrote:
> On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote:
>> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> No explanation in commit message? There isn't much explanation needed for this,
> but there should be at least one sentence.
>
> Likewise for the other patches.
>
Thanks Eric for your comment.
Sent out minimal RFC, I'll add detail explanation also having original
series
in the tree helps.
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
2021-02-07 19:04 ` Chaitanya Kulkarni
@ 2021-03-25 14:22 ` Theodore Ts'o
-1 siblings, 0 replies; 40+ messages in thread
From: Theodore Ts'o @ 2021-03-25 14:22 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: axboe, ebiggers, damien.lemoal, bvanassche, hch,
johannes.thumshirn, dave.hansen, linux-f2fs-devel, linux-block,
clm, adilger.kernel, dongli.zhang, linux-fsdevel, jaegeuk,
dsterba, linux-ext4, ira.weiny
On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> fs/ext4/verity.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Hi, were you expecting to have file system maintainers take these
patches into their own trees? The ext4 patches look good, and unless
you have any objections, I can take them through the ext4 tree.
Thanks,
- Ted
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
@ 2021-03-25 14:22 ` Theodore Ts'o
0 siblings, 0 replies; 40+ messages in thread
From: Theodore Ts'o @ 2021-03-25 14:22 UTC (permalink / raw
To: Chaitanya Kulkarni
Cc: linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel, axboe,
adilger.kernel, jaegeuk, chao, johannes.thumshirn, damien.lemoal,
bvanassche, dongli.zhang, clm, ira.weiny, dsterba, ebiggers, hch,
dave.hansen
On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> fs/ext4/verity.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Hi, were you expecting to have file system maintainers take these
patches into their own trees? The ext4 patches look good, and unless
you have any objections, I can take them through the ext4 tree.
Thanks,
- Ted
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
2021-03-25 14:22 ` Theodore Ts'o
@ 2021-03-25 15:09 ` Ira Weiny
-1 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-03-25 15:09 UTC (permalink / raw
To: Theodore Ts'o
Cc: axboe, ebiggers, damien.lemoal, bvanassche, Chaitanya Kulkarni,
hch, johannes.thumshirn, dave.hansen, linux-f2fs-devel,
linux-block, clm, adilger.kernel, dongli.zhang, linux-fsdevel,
jaegeuk, dsterba, linux-ext4
On Thu, Mar 25, 2021 at 10:22:54AM -0400, Theodore Y. Ts'o wrote:
> On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote:
> > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> > ---
> > fs/ext4/verity.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Hi, were you expecting to have file system maintainers take these
> patches into their own trees? The ext4 patches look good, and unless
> you have any objections, I can take them through the ext4 tree.
I think going through the ext4 tree would be fine.
However, there was a fix needed in patch 2/8. Chaitanya was a V1 sent?
Ira
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
@ 2021-03-25 15:09 ` Ira Weiny
0 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-03-25 15:09 UTC (permalink / raw
To: Theodore Ts'o
Cc: Chaitanya Kulkarni, linux-block, linux-ext4, linux-f2fs-devel,
linux-fsdevel, axboe, adilger.kernel, jaegeuk, chao,
johannes.thumshirn, damien.lemoal, bvanassche, dongli.zhang, clm,
dsterba, ebiggers, hch, dave.hansen
On Thu, Mar 25, 2021 at 10:22:54AM -0400, Theodore Y. Ts'o wrote:
> On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote:
> > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> > ---
> > fs/ext4/verity.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Hi, were you expecting to have file system maintainers take these
> patches into their own trees? The ext4 patches look good, and unless
> you have any objections, I can take them through the ext4 tree.
I think going through the ext4 tree would be fine.
However, there was a fix needed in patch 2/8. Chaitanya was a V1 sent?
Ira
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
2021-03-25 14:22 ` Theodore Ts'o
@ 2021-03-25 15:10 ` Ira Weiny
-1 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-03-25 15:10 UTC (permalink / raw
To: Theodore Ts'o
Cc: Chaitanya Kulkarni, linux-block, linux-ext4, linux-f2fs-devel,
linux-fsdevel, axboe, adilger.kernel, jaegeuk, chao,
johannes.thumshirn, damien.lemoal, bvanassche, dongli.zhang, clm,
dsterba, ebiggers, hch, dave.hansen
On Thu, Mar 25, 2021 at 10:22:54AM -0400, Theodore Y. Ts'o wrote:
> On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote:
> > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> > ---
> > fs/ext4/verity.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Hi, were you expecting to have file system maintainers take these
> patches into their own trees? The ext4 patches look good, and unless
> you have any objections, I can take them through the ext4 tree.
I should have sent the lore link to the fix:
https://lore.kernel.org/linux-f2fs-devel/BYAPR04MB496564B786E293FDA21D06E6868F9@BYAPR04MB4965.namprd04.prod.outlook.com/
Sorry,
Ira
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [f2fs-dev] [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write()
@ 2021-03-25 15:10 ` Ira Weiny
0 siblings, 0 replies; 40+ messages in thread
From: Ira Weiny @ 2021-03-25 15:10 UTC (permalink / raw
To: Theodore Ts'o
Cc: axboe, ebiggers, damien.lemoal, bvanassche, Chaitanya Kulkarni,
hch, johannes.thumshirn, dave.hansen, linux-f2fs-devel,
linux-block, clm, adilger.kernel, dongli.zhang, linux-fsdevel,
jaegeuk, dsterba, linux-ext4
On Thu, Mar 25, 2021 at 10:22:54AM -0400, Theodore Y. Ts'o wrote:
> On Sun, Feb 07, 2021 at 11:04:23AM -0800, Chaitanya Kulkarni wrote:
> > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> > ---
> > fs/ext4/verity.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Hi, were you expecting to have file system maintainers take these
> patches into their own trees? The ext4 patches look good, and unless
> you have any objections, I can take them through the ext4 tree.
I should have sent the lore link to the fix:
https://lore.kernel.org/linux-f2fs-devel/BYAPR04MB496564B786E293FDA21D06E6868F9@BYAPR04MB4965.namprd04.prod.outlook.com/
Sorry,
Ira
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 40+ messages in thread
end of thread, other threads:[~2021-03-25 15:11 UTC | newest]
Thread overview: 40+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-07 19:04 [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 1/8] brd: use memcpy_from_page() in copy_from_brd() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-07 22:34 ` kernel test robot
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 2/8] " Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-08 4:35 ` [f2fs-dev] " Ira Weiny
2021-02-08 4:35 ` Ira Weiny
2021-02-08 5:47 ` [f2fs-dev] " Chaitanya Kulkarni
2021-02-08 5:47 ` Chaitanya Kulkarni
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 3/8] null_blk: use memcpy_page() in copy_to_nullb() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 4/8] null_blk: use memcpy_page() in copy_from_nullb() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-08 1:45 ` kernel test robot
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-03-25 14:22 ` [f2fs-dev] " Theodore Ts'o
2021-03-25 14:22 ` Theodore Ts'o
2021-03-25 15:09 ` [f2fs-dev] " Ira Weiny
2021-03-25 15:09 ` Ira Weiny
2021-03-25 15:10 ` Ira Weiny
2021-03-25 15:10 ` [f2fs-dev] " Ira Weiny
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 7/8] f2fs: use memcpy_from_page() in pagecache_read() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-07 19:04 ` [f2fs-dev] [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write() Chaitanya Kulkarni
2021-02-07 19:04 ` Chaitanya Kulkarni
2021-02-10 18:01 ` [f2fs-dev] " Eric Biggers
2021-02-10 18:01 ` Eric Biggers
2021-02-10 19:41 ` [f2fs-dev] " Chaitanya Kulkarni
2021-02-10 19:41 ` Chaitanya Kulkarni
2021-02-07 19:10 ` [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps Chaitanya Kulkarni
2021-02-07 19:10 ` Chaitanya Kulkarni
2021-02-08 4:42 ` [f2fs-dev] " Ira Weiny
2021-02-08 4:42 ` Ira Weiny
2021-02-08 5:47 ` [f2fs-dev] " Chaitanya Kulkarni
2021-02-08 5:47 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.