* [meta][PATCH] npm.bbclass: avoid building target nodejs for native npm recipes
@ 2021-02-08 17:52 Yoann Congal
2021-02-08 17:55 ` [OE-core] " Konrad Weihmann
0 siblings, 1 reply; 3+ messages in thread
From: Yoann Congal @ 2021-02-08 17:52 UTC (permalink / raw
To: openembedded-core; +Cc: Yoann Congal
The current recipe unconditionally RDEPENDS on nodejs (the target one).
When building on the "-native recipe" of "BBCLASSEXTEND native" recipe,
the target nodejs is unnecessarily built.
This patch fixes this by only RDEPENDS on nodejs when building for the target.
Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
---
meta/classes/npm.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
index 79f55febcc..61d16cf23d 100644
--- a/meta/classes/npm.bbclass
+++ b/meta/classes/npm.bbclass
@@ -20,7 +20,7 @@
inherit python3native
DEPENDS_prepend = "nodejs-native "
-RDEPENDS_${PN}_prepend = "nodejs "
+RDEPENDS_${PN}_class-target_prepend += "nodejs"
NPM_INSTALL_DEV ?= "0"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [OE-core] [meta][PATCH] npm.bbclass: avoid building target nodejs for native npm recipes
2021-02-08 17:52 [meta][PATCH] npm.bbclass: avoid building target nodejs for native npm recipes Yoann Congal
@ 2021-02-08 17:55 ` Konrad Weihmann
2021-02-08 18:07 ` Yoann Congal
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Weihmann @ 2021-02-08 17:55 UTC (permalink / raw
To: openembedded-core, yoann.congal
On 08.02.21 18:52, Yoann Congal wrote:
> The current recipe unconditionally RDEPENDS on nodejs (the target one).
> When building on the "-native recipe" of "BBCLASSEXTEND native" recipe,
> the target nodejs is unnecessarily built.
>
> This patch fixes this by only RDEPENDS on nodejs when building for the target.
>
> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> ---
> meta/classes/npm.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
> index 79f55febcc..61d16cf23d 100644
> --- a/meta/classes/npm.bbclass
> +++ b/meta/classes/npm.bbclass
> @@ -20,7 +20,7 @@
> inherit python3native
>
> DEPENDS_prepend = "nodejs-native "
> -RDEPENDS_${PN}_prepend = "nodejs "
> +RDEPENDS_${PN}_class-target_prepend += "nodejs"
This doesn't look right. Either
RDEPENDS_${PN}_class-target_prepend = "nodejs "
or
RDEPENDS_${PN}_class-target += "nodejs"
but not both. plus prepend does require a trailing blank iirc
>
> NPM_INSTALL_DEV ?= "0"
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [OE-core] [meta][PATCH] npm.bbclass: avoid building target nodejs for native npm recipes
2021-02-08 17:55 ` [OE-core] " Konrad Weihmann
@ 2021-02-08 18:07 ` Yoann Congal
0 siblings, 0 replies; 3+ messages in thread
From: Yoann Congal @ 2021-02-08 18:07 UTC (permalink / raw
To: Konrad Weihmann; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
Le lun. 8 févr. 2021 à 18:55, Konrad Weihmann <kweihmann@outlook.com> a
écrit :
>
>
> On 08.02.21 18:52, Yoann Congal wrote:
> > The current recipe unconditionally RDEPENDS on nodejs (the target one).
> > When building on the "-native recipe" of "BBCLASSEXTEND native" recipe,
> > the target nodejs is unnecessarily built.
> >
> > This patch fixes this by only RDEPENDS on nodejs when building for the
> target.
> >
> > Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> > ---
> > meta/classes/npm.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
> > index 79f55febcc..61d16cf23d 100644
> > --- a/meta/classes/npm.bbclass
> > +++ b/meta/classes/npm.bbclass
> > @@ -20,7 +20,7 @@
> > inherit python3native
> >
> > DEPENDS_prepend = "nodejs-native "
> > -RDEPENDS_${PN}_prepend = "nodejs "
> > +RDEPENDS_${PN}_class-target_prepend += "nodejs"
>
> This doesn't look right. Either
>
> RDEPENDS_${PN}_class-target_prepend = "nodejs "
> or
> RDEPENDS_${PN}_class-target += "nodejs"
>
> but not both. plus prepend does require a trailing blank iirc
>
Oh wow, I should not have missed that :-/
I'll send a PATCHv2.
Thanks!
> >
> > NPM_INSTALL_DEV ?= "0"
> >
> >
> >
> >
> >
> >
>
>
>
>
--
Yoann Congal
Smile ECS - Expert technique
yoann.congal@smile.fr
[-- Attachment #2: Type: text/html, Size: 2580 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-08 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-08 17:52 [meta][PATCH] npm.bbclass: avoid building target nodejs for native npm recipes Yoann Congal
2021-02-08 17:55 ` [OE-core] " Konrad Weihmann
2021-02-08 18:07 ` Yoann Congal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.