* [Buildroot] [PATCH 1/4] package/python-magic: Add new package
@ 2021-02-26 16:09 Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 2/4] package/python-libarchive-c: Add as " Conrad Ratschan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Conrad Ratschan @ 2021-02-26 16:09 UTC (permalink / raw
To: buildroot
Add new package for python-magic. This is needed as a runtime dependency
for Diffoscope.
Signed-off-by: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
---
package/Config.in.host | 1 +
package/python-magic/Config.in.host | 8 ++++++++
package/python-magic/python-magic.hash | 2 ++
package/python-magic/python-magic.mk | 14 ++++++++++++++
4 files changed, 25 insertions(+)
create mode 100644 package/python-magic/Config.in.host
create mode 100644 package/python-magic/python-magic.hash
create mode 100644 package/python-magic/python-magic.mk
diff --git a/package/Config.in.host b/package/Config.in.host
index ba6a68c728..1b3812decf 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -66,6 +66,7 @@ menu "Host utilities"
source "package/python/Config.in.host"
source "package/python-cython/Config.in.host"
source "package/python-lxml/Config.in.host"
+ source "package/python-magic/Config.in.host"
source "package/python-six/Config.in.host"
source "package/python-xlrd/Config.in.host"
source "package/python3/Config.in.host"
diff --git a/package/python-magic/Config.in.host b/package/python-magic/Config.in.host
new file mode 100644
index 0000000000..021c6b11ed
--- /dev/null
+++ b/package/python-magic/Config.in.host
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_HOST_PYTHON_MAGIC
+ bool "host-python-magic"
+ depends on BR2_PACKAGE_HOST_PYTHON3
+ help
+ A Python interface to the libmagic file type identification
+ library.
+
+ https://github.com/ahupp/python-magic
diff --git a/package/python-magic/python-magic.hash b/package/python-magic/python-magic.hash
new file mode 100644
index 0000000000..e6d722ec50
--- /dev/null
+++ b/package/python-magic/python-magic.hash
@@ -0,0 +1,2 @@
+# sha256 from https://pypi.org/pypi/python-magic/json
+sha256 ca884349f2c92ce830e3f498c5b7c7051fe2942c3ee4332f65213b8ebff15a62 python-magic-0.4.22.tar.gz
diff --git a/package/python-magic/python-magic.mk b/package/python-magic/python-magic.mk
new file mode 100644
index 0000000000..fb9e61d2e9
--- /dev/null
+++ b/package/python-magic/python-magic.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-magic
+#
+################################################################################
+
+PYTHON_MAGIC_VERSION = 0.4.22
+PYTHON_MAGIC_SITE = https://files.pythonhosted.org/packages/26/60/6d45e0e7043f5a7bf15238ca451256a78d3c5fe02cd372f0ed6d888a16d5
+PYTHON_MAGIC_SETUP_TYPE = setuptools
+PYTHON_MAGIC_LICENSE = MIT
+HOST_PYTHON_MAGIC_DL_SUBDIR = python-magic
+HOST_PYTHON_MAGIC_NEEDS_HOST_PYTHON = python3
+
+$(eval $(host-python-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/4] package/python-libarchive-c: Add as new package
2021-02-26 16:09 [Buildroot] [PATCH 1/4] package/python-magic: Add new package Conrad Ratschan
@ 2021-02-26 16:09 ` Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 3/4] package/python3: Allow host-python ncurses Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package Conrad Ratschan
2 siblings, 0 replies; 6+ messages in thread
From: Conrad Ratschan @ 2021-02-26 16:09 UTC (permalink / raw
To: buildroot
Add new host python package for python-libarchive-c. This is needed as a
runtime dependency for Diffoscope.
Signed-off-by: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
---
package/Config.in.host | 1 +
package/python-libarchive-c/Config.in.host | 8 ++++++++
.../python-libarchive-c/python-libarchive-c.hash | 2 ++
.../python-libarchive-c/python-libarchive-c.mk | 15 +++++++++++++++
4 files changed, 26 insertions(+)
create mode 100644 package/python-libarchive-c/Config.in.host
create mode 100644 package/python-libarchive-c/python-libarchive-c.hash
create mode 100644 package/python-libarchive-c/python-libarchive-c.mk
diff --git a/package/Config.in.host b/package/Config.in.host
index 1b3812decf..4edfb9cfa4 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -65,6 +65,7 @@ menu "Host utilities"
source "package/pwgen/Config.in.host"
source "package/python/Config.in.host"
source "package/python-cython/Config.in.host"
+ source "package/python-libarchive-c/Config.in.host"
source "package/python-lxml/Config.in.host"
source "package/python-magic/Config.in.host"
source "package/python-six/Config.in.host"
diff --git a/package/python-libarchive-c/Config.in.host b/package/python-libarchive-c/Config.in.host
new file mode 100644
index 0000000000..cd0c09af9d
--- /dev/null
+++ b/package/python-libarchive-c/Config.in.host
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_HOST_PYTHON_LIBARCHIVE_C
+ bool "host-python-libarchive-c"
+ depends on BR2_PACKAGE_HOST_PYTHON3
+ select BR2_PACKAGE_HOST_LIBARCHIVE
+ help
+ A Python interface to libarchive
+
+ https://github.com/Changaco/python-libarchive-c
diff --git a/package/python-libarchive-c/python-libarchive-c.hash b/package/python-libarchive-c/python-libarchive-c.hash
new file mode 100644
index 0000000000..adde6a8462
--- /dev/null
+++ b/package/python-libarchive-c/python-libarchive-c.hash
@@ -0,0 +1,2 @@
+# sha256 from https://pypi.org/pypi/diffoscope/json
+sha256 9919344cec203f5db6596a29b5bc26b07ba9662925a05e24980b84709232ef60 libarchive-c-2.9.tar.gz
diff --git a/package/python-libarchive-c/python-libarchive-c.mk b/package/python-libarchive-c/python-libarchive-c.mk
new file mode 100644
index 0000000000..b67e0a6796
--- /dev/null
+++ b/package/python-libarchive-c/python-libarchive-c.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-libarchive
+#
+################################################################################
+
+PYTHON_LIBARCHIVE_C_VERSION = 2.9
+PYTHON_LIBARCHIVE_C_SOURCE = libarchive-c-$(PYTHON_LIBARCHIVE_C_VERSION).tar.gz
+PYTHON_LIBARCHIVE_C_SITE = https://files.pythonhosted.org/packages/63/fe/9e6c78db381934e28c7ec3d30d4f209fe24442d17f1bd8c56d13ae185cf6
+PYTHON_LIBARCHIVE_C_SETUP_TYPE = setuptools
+PYTHON_LIBARCHIVE_C_LICENSE = CC0-1.0
+HOST_PYTHON_LIBARCHIVE_C_DL_SUBDIR = python-libarchive-c
+HOST_PYTHON_LIBARCHIVE_C_NEEDS_HOST_PYTHON = python3
+
+$(eval $(host-python-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/4] package/python3: Allow host-python ncurses
2021-02-26 16:09 [Buildroot] [PATCH 1/4] package/python-magic: Add new package Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 2/4] package/python-libarchive-c: Add as " Conrad Ratschan
@ 2021-02-26 16:09 ` Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package Conrad Ratschan
2 siblings, 0 replies; 6+ messages in thread
From: Conrad Ratschan @ 2021-02-26 16:09 UTC (permalink / raw
To: buildroot
The Diffoscope tool has a runtime dependency on the curses module in
Python. Buildroot disables curses support for host-python3. This patch
allows for ncurses to be a configurable option for the host-python3
package like it is for the target python3 package. An additional patch
is added to fix the ncurses include path as it previously was not
correct when not cross compiling.
Signed-off-by: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
---
...-ncurses-include-when-not-cross-comp.patch | 35 +++++++++++++++++++
package/python3/Config.in.host | 5 +++
package/python3/python3.mk | 8 ++++-
3 files changed, 47 insertions(+), 1 deletion(-)
create mode 100644 package/python3/0035-configure.ac-Fix-ncurses-include-when-not-cross-comp.patch
diff --git a/package/python3/0035-configure.ac-Fix-ncurses-include-when-not-cross-comp.patch b/package/python3/0035-configure.ac-Fix-ncurses-include-when-not-cross-comp.patch
new file mode 100644
index 0000000000..15834772d0
--- /dev/null
+++ b/package/python3/0035-configure.ac-Fix-ncurses-include-when-not-cross-comp.patch
@@ -0,0 +1,35 @@
+From 9f10c2f660ab24d622b66a58d14dd7522b120d6d Mon Sep 17 00:00:00 2001
+From: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
+Date: Tue, 2 Feb 2021 09:45:57 -0600
+Subject: [PATCH] configure.ac: Fix ncurses include when not cross compiling
+
+When not cross compiling, the ncurses include path used by configure.ac
+is hardcoded to a path on the user's development machine. Change this
+path to use ${prefix} so that it can use a host folder path specified
+by Buildroot.
+
+Signed-off-by: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
+---
+ configure.ac | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 07bceda..0398da5 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -5271,7 +5271,11 @@ fi
+ # first curses header check
+ ac_save_cppflags="$CPPFLAGS"
+ if test "$cross_compiling" = no; then
+- CPPFLAGS="$CPPFLAGS -I/usr/include/ncursesw"
++ if test "x${prefix}" = "xNONE" ; then
++ CPPFLAGS="$CPPFLAGS -I/usr/include/ncursesw"
++ else
++ CPPFLAGS="$CPPFLAGS -I${prefix}/include/ncursesw -I${prefix}/include/ncurses"
++ fi
+ fi
+
+ AC_CHECK_HEADERS(curses.h ncurses.h)
+--
+2.17.1
+
diff --git a/package/python3/Config.in.host b/package/python3/Config.in.host
index 70b5dacdde..dc463e51b6 100644
--- a/package/python3/Config.in.host
+++ b/package/python3/Config.in.host
@@ -13,4 +13,9 @@ config BR2_PACKAGE_HOST_PYTHON3_SSL
help
_ssl module for host Python3.
+config BR2_PACKAGE_HOST_PYTHON3_CURSES
+ bool "curses"
+ help
+ curses module for Python3.
+
endif
diff --git a/package/python3/python3.mk b/package/python3/python3.mk
index 63d6c3f535..9187fb8220 100644
--- a/package/python3/python3.mk
+++ b/package/python3/python3.mk
@@ -20,7 +20,6 @@ HOST_PYTHON3_CONF_OPTS += \
--disable-sqlite3 \
--disable-tk \
--with-expat=system \
- --disable-curses \
--disable-codecs-cjk \
--disable-nis \
--enable-unicodedata \
@@ -47,6 +46,13 @@ else
HOST_PYTHON3_CONF_OPTS += --disable-openssl
endif
+ifeq ($(BR2_PACKAGE_HOST_PYTHON3_CURSES),y)
+HOST_PYTHON3_DEPENDENCIES += host-ncurses
+HOST_PYTHON3_CONF_OPTS += --enable-curses
+else
+HOST_PYTHON3_CONF_OPTS += --disable-curses
+endif
+
PYTHON3_INSTALL_STAGING = YES
ifeq ($(BR2_PACKAGE_PYTHON3_2TO3),y)
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package
2021-02-26 16:09 [Buildroot] [PATCH 1/4] package/python-magic: Add new package Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 2/4] package/python-libarchive-c: Add as " Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 3/4] package/python3: Allow host-python ncurses Conrad Ratschan
@ 2021-02-26 16:09 ` Conrad Ratschan
2022-07-23 20:28 ` Romain Naour
2 siblings, 1 reply; 6+ messages in thread
From: Conrad Ratschan @ 2021-02-26 16:09 UTC (permalink / raw
To: buildroot
Add a new host python package for python-diffoscope.
Signed-off-by: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
---
package/Config.in.host | 1 +
package/python-diffoscope/Config.in.host | 10 ++++++++++
package/python-diffoscope/python-diffoscope.hash | 2 ++
package/python-diffoscope/python-diffoscope.mk | 16 ++++++++++++++++
4 files changed, 29 insertions(+)
create mode 100644 package/python-diffoscope/Config.in.host
create mode 100644 package/python-diffoscope/python-diffoscope.hash
create mode 100644 package/python-diffoscope/python-diffoscope.mk
diff --git a/package/Config.in.host b/package/Config.in.host
index 4edfb9cfa4..5a9e606a4b 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -65,6 +65,7 @@ menu "Host utilities"
source "package/pwgen/Config.in.host"
source "package/python/Config.in.host"
source "package/python-cython/Config.in.host"
+ source "package/python-diffoscope/Config.in.host"
source "package/python-libarchive-c/Config.in.host"
source "package/python-lxml/Config.in.host"
source "package/python-magic/Config.in.host"
diff --git a/package/python-diffoscope/Config.in.host b/package/python-diffoscope/Config.in.host
new file mode 100644
index 0000000000..520607e8a6
--- /dev/null
+++ b/package/python-diffoscope/Config.in.host
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_HOST_PYTHON_DIFFOSCOPE
+ bool "host-python-diffoscope"
+ depends on BR2_PACKAGE_HOST_PYTHON3
+ select BR2_PACKAGE_HOST_PYTHON_MAGIC
+ select BR2_PACKAGE_HOST_PYTHON_LIBARCHIVE_C
+ select BR2_PACKAGE_HOST_PYTHON3_CURSES
+ help
+ Tool to recursively diff varying file types.
+
+ https://diffoscope.org/
diff --git a/package/python-diffoscope/python-diffoscope.hash b/package/python-diffoscope/python-diffoscope.hash
new file mode 100644
index 0000000000..ea6d73aa60
--- /dev/null
+++ b/package/python-diffoscope/python-diffoscope.hash
@@ -0,0 +1,2 @@
+# sha256 from https://pypi.org/pypi/diffoscope/json
+sha256 d95cef5b3eef49fa1c811c1ac103f7f7cca4a0ebabc674e4283b51f28309d242 diffoscope-167.tar.gz
diff --git a/package/python-diffoscope/python-diffoscope.mk b/package/python-diffoscope/python-diffoscope.mk
new file mode 100644
index 0000000000..ad5a7c6255
--- /dev/null
+++ b/package/python-diffoscope/python-diffoscope.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# python-diffoscope
+#
+################################################################################
+
+PYTHON_DIFFOSCOPE_VERSION = 167
+PYTHON_DIFFOSCOPE_SOURCE = diffoscope-$(PYTHON_DIFFOSCOPE_VERSION).tar.gz
+PYTHON_DIFFOSCOPE_SITE = https://files.pythonhosted.org/packages/69/d8/3cd7efd904d4db9039f3111938598f6093d14087f40f4359ef1514e7d5eb
+PYTHON_DIFFOSCOPE_SETUP_TYPE = setuptools
+PYTHON_DIFFOSCOPE_LICENSE = GPL-3.0+
+HOST_PYTHON_DIFFOSCOPE_DL_SUBDIR = python-diffoscope
+HOST_PYTHON_DIFFOSCOPE_NEEDS_HOST_PYTHON = python3
+HOST_PYTHON_DIFFOSCOPE_DEPENDENCIES = host-python-libarchive-c host-python-magic
+
+$(eval $(host-python-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package
2021-02-26 16:09 ` [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package Conrad Ratschan
@ 2022-07-23 20:28 ` Romain Naour
2022-07-23 21:49 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2022-07-23 20:28 UTC (permalink / raw
To: Conrad Ratschan, buildroot; +Cc: Asaf Kahlon, Thomas Petazzoni
Hi Conrad,
Le 26/02/2021 à 17:09, Conrad Ratschan a écrit :
> Add a new host python package for python-diffoscope.
>
> Signed-off-by: Conrad Ratschan <conrad.ratschan@rockwellcollins.com>
> ---
> package/Config.in.host | 1 +
> package/python-diffoscope/Config.in.host | 10 ++++++++++
> package/python-diffoscope/python-diffoscope.hash | 2 ++
> package/python-diffoscope/python-diffoscope.mk | 16 ++++++++++++++++
> 4 files changed, 29 insertions(+)
> create mode 100644 package/python-diffoscope/Config.in.host
> create mode 100644 package/python-diffoscope/python-diffoscope.hash
> create mode 100644 package/python-diffoscope/python-diffoscope.mk
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 4edfb9cfa4..5a9e606a4b 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -65,6 +65,7 @@ menu "Host utilities"
> source "package/pwgen/Config.in.host"
> source "package/python/Config.in.host"
> source "package/python-cython/Config.in.host"
> + source "package/python-diffoscope/Config.in.host"
> source "package/python-libarchive-c/Config.in.host"
> source "package/python-lxml/Config.in.host"
> source "package/python-magic/Config.in.host"
> diff --git a/package/python-diffoscope/Config.in.host b/package/python-diffoscope/Config.in.host
> new file mode 100644
> index 0000000000..520607e8a6
> --- /dev/null
> +++ b/package/python-diffoscope/Config.in.host
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_HOST_PYTHON_DIFFOSCOPE
> + bool "host-python-diffoscope"
> + depends on BR2_PACKAGE_HOST_PYTHON3
> + select BR2_PACKAGE_HOST_PYTHON_MAGIC
> + select BR2_PACKAGE_HOST_PYTHON_LIBARCHIVE_C
> + select BR2_PACKAGE_HOST_PYTHON3_CURSES
> + help
> + Tool to recursively diff varying file types.
> +
> + https://diffoscope.org/
Even if it's a python based application, the name of the package should be
diffoscope not python-diffoscope.
> diff --git a/package/python-diffoscope/python-diffoscope.hash b/package/python-diffoscope/python-diffoscope.hash
> new file mode 100644
> index 0000000000..ea6d73aa60
> --- /dev/null
> +++ b/package/python-diffoscope/python-diffoscope.hash
> @@ -0,0 +1,2 @@
> +# sha256 from https://pypi.org/pypi/diffoscope/json
> +sha256 d95cef5b3eef49fa1c811c1ac103f7f7cca4a0ebabc674e4283b51f28309d242 diffoscope-167.tar.gz
> diff --git a/package/python-diffoscope/python-diffoscope.mk b/package/python-diffoscope/python-diffoscope.mk
> new file mode 100644
> index 0000000000..ad5a7c6255
> --- /dev/null
> +++ b/package/python-diffoscope/python-diffoscope.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# python-diffoscope
> +#
> +################################################################################
> +
> +PYTHON_DIFFOSCOPE_VERSION = 167
Sorry for the delay, when you posted back in 2021 it was the latest version...
today the latest version is 219.
> +PYTHON_DIFFOSCOPE_SOURCE = diffoscope-$(PYTHON_DIFFOSCOPE_VERSION).tar.gz
> +PYTHON_DIFFOSCOPE_SITE = https://files.pythonhosted.org/packages/69/d8/3cd7efd904d4db9039f3111938598f6093d14087f40f4359ef1514e7d5eb
> +PYTHON_DIFFOSCOPE_SETUP_TYPE = setuptools
> +PYTHON_DIFFOSCOPE_LICENSE = GPL-3.0+
> +HOST_PYTHON_DIFFOSCOPE_DL_SUBDIR = python-diffoscope
> +HOST_PYTHON_DIFFOSCOPE_NEEDS_HOST_PYTHON = python3
> +HOST_PYTHON_DIFFOSCOPE_DEPENDENCIES = host-python-libarchive-c host-python-magic
Still, the dependency seems short here.
To ease Buildroot packaging, you can get some hint from other Linux Distribution
packaging (Debian [1], Fedora [2], Archlinux [3] or even Yocto [4]).
The list of optional dependency of diffoscope is huge and if we compare with the
Yocto packaging some runtime dependencies are missing (binutils vim
squashfs-tools python3-rpm)
So at least we can build diffoscope but a limited (light) version with
Buildroot. For a full version, you have to use the one from your build machine.
For example, only the autobuilder script use diffoscope but the one installed on
the build machine.
It would be great if we can have a test case for this package.
[1]
https://salsa.debian.org/reproducible-builds/diffoscope/-/blob/master/debian/control
[2] https://src.fedoraproject.org/rpms/diffoscope/blob/rawhide/f/diffoscope.spec
[3]
https://github.com/archlinux/svntogit-community/blob/packages/diffoscope/trunk/PKGBUILD
[4]
https://github.com/openembedded/openembedded-core/blob/c2cf956881c3b691691f50b00b0d6930d8abea6f/meta/recipes-support/diffoscope/diffoscope_218.bb
Best regards,
Romain
> +
> +$(eval $(host-python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package
2022-07-23 20:28 ` Romain Naour
@ 2022-07-23 21:49 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-07-23 21:49 UTC (permalink / raw
To: Romain Naour, Conrad Ratschan, buildroot; +Cc: Thomas Petazzoni, Asaf Kahlon
On 23/07/2022 22:28, Romain Naour wrote:
> Hi Conrad,
>
> Le 26/02/2021 à 17:09, Conrad Ratschan a écrit :
[snip]
>> +HOST_PYTHON_DIFFOSCOPE_DL_SUBDIR = python-diffoscope
>> +HOST_PYTHON_DIFFOSCOPE_NEEDS_HOST_PYTHON = python3
>> +HOST_PYTHON_DIFFOSCOPE_DEPENDENCIES = host-python-libarchive-c host-python-magic
>
> Still, the dependency seems short here.
>
> To ease Buildroot packaging, you can get some hint from other Linux Distribution
> packaging (Debian [1], Fedora [2], Archlinux [3] or even Yocto [4]).
>
> The list of optional dependency of diffoscope is huge and if we compare with the
> Yocto packaging some runtime dependencies are missing (binutils vim
> squashfs-tools python3-rpm)
>
> So at least we can build diffoscope but a limited (light) version with
> Buildroot.
It looks like the light version is not going to be very useful, so unless
there's a very good reason to build it in buildroot, I think it's better to rely
on the distro-installed package.
Also, it's really a debug tool, not something that is ever going to be needed
during the build. Maybe you want CI not to just fail if the build is not
reproducible, but also
Therefore, I marked this series as Rejected.
Regards,
Arnout
> For a full version, you have to use the one from your build machine.
>
> For example, only the autobuilder script use diffoscope but the one installed on
> the build machine.
>
> It would be great if we can have a test case for this package.
>
> [1]
> https://salsa.debian.org/reproducible-builds/diffoscope/-/blob/master/debian/control
>
> [2] https://src.fedoraproject.org/rpms/diffoscope/blob/rawhide/f/diffoscope.spec
>
> [3]
> https://github.com/archlinux/svntogit-community/blob/packages/diffoscope/trunk/PKGBUILD
>
> [4]
> https://github.com/openembedded/openembedded-core/blob/c2cf956881c3b691691f50b00b0d6930d8abea6f/meta/recipes-support/diffoscope/diffoscope_218.bb
>
> Best regards,
> Romain
>
>
>> +
>> +$(eval $(host-python-package))
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-23 21:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 16:09 [Buildroot] [PATCH 1/4] package/python-magic: Add new package Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 2/4] package/python-libarchive-c: Add as " Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 3/4] package/python3: Allow host-python ncurses Conrad Ratschan
2021-02-26 16:09 ` [Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package Conrad Ratschan
2022-07-23 20:28 ` Romain Naour
2022-07-23 21:49 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.