From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D7FC433E6 for ; Tue, 16 Mar 2021 20:55:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A75D664F9B for ; Tue, 16 Mar 2021 20:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhCPUzU (ORCPT ); Tue, 16 Mar 2021 16:55:20 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:44628 "EHLO mail-io1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231136AbhCPUzC (ORCPT ); Tue, 16 Mar 2021 16:55:02 -0400 Received: by mail-io1-f45.google.com with SMTP id 81so38701657iou.11; Tue, 16 Mar 2021 13:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=b/HLRtc9/GppMSPP5tT4uFEB2bYhGH4aO6xHcwQ2WfQ=; b=my5GrnLQTfPKyGXWfirRVeUa7Qe3rsX2hfvaSfS8WoZCFHTWIk39tUFcWY4NdFvE6B LAOSF9Wza26MMmp1WBOf1cGM4z2TqPoICyBXOO8jnBQxzCQiybS1tJfst8eOWn1VPJqp lQO9TWXGywEW97b+099EYgwpHOS1sVgFXUZSAJL6q0vtD+AknCrLWsYl7zwCUUbZkVza zUwM9dHumswjoSsqTnaY33BDfxLlV2g2fl55uuCW0WiHdf5JMIv7jeYrwsZK8aGr2oXQ g803EnEmlyU1xkajPzvm7vDxNkI0OhIPvpxWBJQp1cIlOOWv3mbqCj/1aTev1h+/Z5o2 Z6Uw== X-Gm-Message-State: AOAM531Dxwn0+QRcFLV7KzwxOt5AWwld0rX9M7wVbqG7cUrXYw1jcjjN aK3AtOaN9HWDgMWl+vWVqTESVGMC2A== X-Google-Smtp-Source: ABdhPJy2FFbwPfeH4HjcRF/xa3S7dCrwdPT3NP7sdc78q/Hb0Z2ft0uvTjdvs8BIYhPvswTeMdhyAA== X-Received: by 2002:a02:53:: with SMTP id 80mr468199jaa.96.1615928094530; Tue, 16 Mar 2021 13:54:54 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id j17sm8971166iok.37.2021.03.16.13.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 13:54:54 -0700 (PDT) Received: (nullmailer pid 3647201 invoked by uid 1000); Tue, 16 Mar 2021 20:54:51 -0000 Date: Tue, 16 Mar 2021 14:54:51 -0600 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Lee Jones , Michael Walle , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 03/22] dt-bindings: add BCM63XX GPIO binding documentation Message-ID: <20210316205451.GA3629500@robh.at.kernel.org> References: <20210315114214.3096-1-noltari@gmail.com> <20210315114214.3096-4-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210315114214.3096-4-noltari@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 12:41:55PM +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO controller found in BCM6318, BCM6328, > BCM6358, BCM6362, BCM6368 and BCM63268 SoCs. > > Co-developed-by: Jonas Gorski > Signed-off-by: Jonas Gorski > Signed-off-by: Álvaro Fernández Rojas > --- > v7: new patch, splitted from pinctrl documentation > > .../bindings/gpio/brcm,bcm63xx-gpio.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yaml > new file mode 100644 > index 000000000000..94a4f00ae2c7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/brcm,bcm63xx-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM63xx GPIO controller > + > +maintainers: > + - Álvaro Fernández Rojas > + - Jonas Gorski > + > +description: |+ > + The GPIO controller node should be the child of a syscon node. > + > + Refer to the the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml The above description is not too useful because it should hopefully later on in the series be expressed as a schema. IOW, the syscon schema should have a gpio child node with a $ref to this schema. What would be useful is to say something about the GPIO block. > + > +properties: > + compatible: > + enum: > + - brcm,bcm6318-gpio > + - brcm,bcm6328-gpio > + - brcm,bcm6358-gpio > + - brcm,bcm6362-gpio > + - brcm,bcm6368-gpio > + - brcm,bcm63268-gpio > + > + data: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Offset in the register map for the data register (in bytes). > + > + dirout: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Offset in the register map for the dirout register (in bytes). As I said earlier, copy what brcm,bcm6345-gpio.txt did and use reg instead of data and dirout properties. That binding says it is for bcm63xx SoCs, too. So that should be resolved. It looks like it should be 1 binding IMO. The only difference I see is the number of GPIO lines and register size. The fact that the parent is a syscon in some cases is irrelevant. > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + gpio-ranges: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - gpio-controller > + - gpio-ranges > + - '#gpio-cells' > + > +additionalProperties: false > + > +examples: > + - | > + gpio@0 { > + compatible = "brcm,bcm6328-gpio"; > + reg = <0x0 0x10>; > + > + data = <0xc>; > + dirout = <0x4>; > + > + gpio-controller; > + gpio-ranges = <&pinctrl 0 0 32>; > + #gpio-cells = <2>; > + }; > + > + - | > + gpio@0 { > + compatible = "brcm,bcm63268-gpio"; > + reg = <0x0 0x10>; > + > + data = <0xc>; > + dirout = <0x4>; > + > + gpio-controller; > + gpio-ranges = <&pinctrl 0 0 52>; > + #gpio-cells = <2>; > + }; > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E854C433E0 for ; Tue, 16 Mar 2021 20:56:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1796564F8F for ; Tue, 16 Mar 2021 20:56:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1796564F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jOVEU/FsH6bVnoygp4DqNxOzYtq0Lalk6uSQmX/j6yI=; b=YBtnDDNYChR4DP3n2sa2wHpiM MMFW97myXLeYofD0BfNZuDwxMmE0sFh0CMYxu9C7CSeimfsOjGZ+YZOdLv1gEY5d8sGb2816F0nag SM4Rstc3PQYa2rBbDeFRUSC99Ps/vwJSnOZxLhVVfBhs/NfAeZlXmRRFCJXAswh9CWek/OlTgPn5T muyjvDSLZDntUjRugZD2FA7SfcoGiLaDUlaDdU3jHCptVmhpIdtDYiz5Ze2/yL86BtmdYNO3Yx7Tp FxrVTSKse0YXpsXI6iHYh92g2tsEEVlcKMHmUzizsuu7bvkLtuZec+MFSZ0eIZ4CSyRU9rlSiHGQW r0MlsrPzg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMGiT-001qmy-Rt; Tue, 16 Mar 2021 20:55:01 +0000 Received: from mail-io1-f47.google.com ([209.85.166.47]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMGiN-001qmC-Nw for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 20:54:58 +0000 Received: by mail-io1-f47.google.com with SMTP id n132so38734274iod.0 for ; Tue, 16 Mar 2021 13:54:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=b/HLRtc9/GppMSPP5tT4uFEB2bYhGH4aO6xHcwQ2WfQ=; b=Vbui1rc5ohiB0QTaMylm8ayTwZApywvKj6dhBaStia5IcRe+rO9CNSRYhygOak7Gr0 SpyyC6KpH+iAajHRSh1KEQtM9ZOuVncZXLNkgnfpomK8zSH5N09EagExc8AxSUij+GxE aYHsi96TK6+mmGDuFVQ5Tuj6uQEfi61AVSslcQ56XfUsnkqG8sg7k1Uqy+ah6OujN+pA VBqk7on+PPJz2osQiTfhbC3HMdHBEqQfzPOsEs4cRmkUJjSJUPuqTr0p6dxJhh3wnXD3 uZpLk0JqqiExIf6NafQ3AYEn9la1TN77lNOxDts5g5GhcvPHphsIy/PLwfrA3IWmSe5r qNGg== X-Gm-Message-State: AOAM530wh8v6MSLIt3Rg0SrLROb2GY5L6PdveGrHjTfQMuYMLKdn1+3Q nZVJaKoefzezvdg3Hag8+w== X-Google-Smtp-Source: ABdhPJy2FFbwPfeH4HjcRF/xa3S7dCrwdPT3NP7sdc78q/Hb0Z2ft0uvTjdvs8BIYhPvswTeMdhyAA== X-Received: by 2002:a02:53:: with SMTP id 80mr468199jaa.96.1615928094530; Tue, 16 Mar 2021 13:54:54 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id j17sm8971166iok.37.2021.03.16.13.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 13:54:54 -0700 (PDT) Received: (nullmailer pid 3647201 invoked by uid 1000); Tue, 16 Mar 2021 20:54:51 -0000 Date: Tue, 16 Mar 2021 14:54:51 -0600 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Lee Jones , Michael Walle , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 03/22] dt-bindings: add BCM63XX GPIO binding documentation Message-ID: <20210316205451.GA3629500@robh.at.kernel.org> References: <20210315114214.3096-1-noltari@gmail.com> <20210315114214.3096-4-noltari@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315114214.3096-4-noltari@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_205456_135962_8417D972 X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 12:41:55PM +0100, =C1lvaro Fern=E1ndez Rojas wrote: > Add binding documentation for the GPIO controller found in BCM6318, BCM63= 28, > BCM6358, BCM6362, BCM6368 and BCM63268 SoCs. > = > Co-developed-by: Jonas Gorski > Signed-off-by: Jonas Gorski > Signed-off-by: =C1lvaro Fern=E1ndez Rojas > --- > v7: new patch, splitted from pinctrl documentation > = > .../bindings/gpio/brcm,bcm63xx-gpio.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,bcm63xx-g= pio.yaml > = > diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yam= l b/Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yaml > new file mode 100644 > index 000000000000..94a4f00ae2c7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/brcm,bcm63xx-gpio.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/brcm,bcm63xx-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM63xx GPIO controller > + > +maintainers: > + - =C1lvaro Fern=E1ndez Rojas > + - Jonas Gorski > + > +description: |+ > + The GPIO controller node should be the child of a syscon node. > + > + Refer to the the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml The above description is not too useful because it should hopefully = later on in the series be expressed as a schema. IOW, the syscon schema = should have a gpio child node with a $ref to this schema. What would be useful is to say something about the GPIO block. > + > +properties: > + compatible: > + enum: > + - brcm,bcm6318-gpio > + - brcm,bcm6328-gpio > + - brcm,bcm6358-gpio > + - brcm,bcm6362-gpio > + - brcm,bcm6368-gpio > + - brcm,bcm63268-gpio > + > + data: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Offset in the register map for the data register (in bytes). > + > + dirout: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Offset in the register map for the dirout register (in bytes). As I said earlier, copy what brcm,bcm6345-gpio.txt did and use reg = instead of data and dirout properties. That binding says it is for bcm63xx SoCs, too. So that should be = resolved. It looks like it should be 1 binding IMO. The only difference = I see is the number of GPIO lines and register size. The fact that the = parent is a syscon in some cases is irrelevant. > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + gpio-ranges: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - gpio-controller > + - gpio-ranges > + - '#gpio-cells' > + > +additionalProperties: false > + > +examples: > + - | > + gpio@0 { > + compatible =3D "brcm,bcm6328-gpio"; > + reg =3D <0x0 0x10>; > + > + data =3D <0xc>; > + dirout =3D <0x4>; > + > + gpio-controller; > + gpio-ranges =3D <&pinctrl 0 0 32>; > + #gpio-cells =3D <2>; > + }; > + > + - | > + gpio@0 { > + compatible =3D "brcm,bcm63268-gpio"; > + reg =3D <0x0 0x10>; > + > + data =3D <0xc>; > + dirout =3D <0x4>; > + > + gpio-controller; > + gpio-ranges =3D <&pinctrl 0 0 52>; > + #gpio-cells =3D <2>; > + }; > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel