From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27312C433E6 for ; Tue, 16 Mar 2021 21:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E849064F8F for ; Tue, 16 Mar 2021 21:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232145AbhCPU7n (ORCPT ); Tue, 16 Mar 2021 16:59:43 -0400 Received: from mail-il1-f175.google.com ([209.85.166.175]:42106 "EHLO mail-il1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232113AbhCPU7J (ORCPT ); Tue, 16 Mar 2021 16:59:09 -0400 Received: by mail-il1-f175.google.com with SMTP id p10so14041573ils.9; Tue, 16 Mar 2021 13:59:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xsVrLqfFpXKxNuoRZpVin2JaTCzQFHIEf5rAhS0t1jc=; b=uetsiHxGzCvdaYcDnNwM426E+oETstT4wGVG20uUbnkIe7D8irE99guviaBuzu1qop 8VpdYFyqyE+Rox4QFeyTisTf3wUMzme2dwJU53jlgYxXyEatzQ6554aNds4vrOvj/VXF Zp86DkyXGxYwbXJMJksq3zhm1oEhEYGUm9Z/PSHuUNnczMOgzy7wYQ68Wb2HhgVTATCl Hkwtb0ofmsCWhod3pMIeR6+qScT41Q6PT67to19Fujpjfegv7kcsSqibKzQ49Y8FaKbJ gcx9WXAcy+q64HGqrGbF8PH4kROMfX97eRuccDBRhi3Qs5rJb+KrnBA3dc3ns24ISwR3 RC4A== X-Gm-Message-State: AOAM530bLg52EzN9igKJdpwmaEhMF3mumtvywyL1FOHBQgUlUcGE2T8h 32tWGiVIurdovJqahW7rfYPZjPkLtA== X-Google-Smtp-Source: ABdhPJwrwf44s8a491QtBFCu7iMS7CHmGjuCHAa3ym10vpMY+nI/W/uVCU+NEjLTT1bOCf9Kk7E25w== X-Received: by 2002:a92:4a0e:: with SMTP id m14mr5359432ilf.117.1615928349009; Tue, 16 Mar 2021 13:59:09 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id t9sm6303046ils.76.2021.03.16.13.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 13:59:08 -0700 (PDT) Received: (nullmailer pid 3653740 invoked by uid 1000); Tue, 16 Mar 2021 20:59:05 -0000 Date: Tue, 16 Mar 2021 14:59:05 -0600 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Lee Jones , Michael Walle , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Message-ID: <20210316205905.GB3629500@robh.at.kernel.org> References: <20210315114214.3096-1-noltari@gmail.com> <20210315114214.3096-6-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210315114214.3096-6-noltari@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 12:41:57PM +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the pincontrol core found in BCM6328 SoCs. > > Co-developed-by: Jonas Gorski > Signed-off-by: Jonas Gorski > Signed-off-by: Álvaro Fernández Rojas > --- > v7: add changes suggested by Rob Herring > v6: add changes suggested by Rob Herring > v5: change Documentation to dt-bindings in commit title > v4: no changes > v3: add new gpio node > v2: remove interrupts > > .../pinctrl/brcm,bcm6328-pinctrl.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > new file mode 100644 > index 000000000000..e1ecdc578f32 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/brcm,bcm6328-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM6328 pin controller > + > +maintainers: > + - Álvaro Fernández Rojas > + - Jonas Gorski > + > +description: |+ > + The pin controller node should be the child of a syscon node. > + > + Refer to the the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + compatible: > + const: brcm,bcm6328-pinctrl > + > + reg: > + maxItems: 1 > + > +patternProperties: > + '^.*-pins$': '-pins$' is equivalent. > + if: > + type: object > + then: You don't need this if/then. This should be: '-pins$': type: object $ref: pinmux-node.yaml# additionalProperties: false properties: ... > + properties: > + function: > + $ref: "pinmux-node.yaml#/properties/function" Drop this as you need the $ref up a level. > + enum: [ serial_led_data, serial_led_clk, inet_act_led, pcie_clkreq, > + led, ephy0_act_led, ephy1_act_led, ephy2_act_led, > + ephy3_act_led, hsspi_cs1, usb_device_port, usb_host_port ] > + > + pins: > + $ref: "pinmux-node.yaml#/properties/pins" > + enum: [ gpio6, gpio7, gpio11, gpio16, gpio17, gpio18, gpio19, > + gpio20, gpio25, gpio26, gpio27, gpio28, hsspi_cs1, > + usb_port1 ] > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pinctrl@18 { > + compatible = "brcm,bcm6328-pinctrl"; > + reg = <0x18 0x10>; > + > + pinctrl_serial_led: serial_led-pins { > + pinctrl_serial_led_data: serial_led_data-pins { > + function = "serial_led_data"; > + pins = "gpio6"; > + }; > + > + pinctrl_serial_led_clk: serial_led_clk-pins { > + function = "serial_led_clk"; > + pins = "gpio7"; > + }; > + }; > + > + pinctrl_inet_act_led: inet_act_led-pins { > + function = "inet_act_led"; > + pins = "gpio11"; > + }; > + > + pinctrl_pcie_clkreq: pcie_clkreq-pins { > + function = "pcie_clkreq"; > + pins = "gpio16"; > + }; > + > + pinctrl_ephy0_spd_led: ephy0_spd_led-pins { > + function = "led"; > + pins = "gpio17"; > + }; > + > + pinctrl_ephy1_spd_led: ephy1_spd_led-pins { > + function = "led"; > + pins = "gpio18"; > + }; > + > + pinctrl_ephy2_spd_led: ephy2_spd_led-pins { > + function = "led"; > + pins = "gpio19"; > + }; > + > + pinctrl_ephy3_spd_led: ephy3_spd_led-pins { > + function = "led"; > + pins = "gpio20"; > + }; > + > + pinctrl_ephy0_act_led: ephy0_act_led-pins { > + function = "ephy0_act_led"; > + pins = "gpio25"; > + }; > + > + pinctrl_ephy1_act_led: ephy1_act_led-pins { > + function = "ephy1_act_led"; > + pins = "gpio26"; > + }; > + > + pinctrl_ephy2_act_led: ephy2_act_led-pins { > + function = "ephy2_act_led"; > + pins = "gpio27"; > + }; > + > + pinctrl_ephy3_act_led: ephy3_act_led-pins { > + function = "ephy3_act_led"; > + pins = "gpio28"; > + }; > + > + pinctrl_hsspi_cs1: hsspi_cs1-pins { > + function = "hsspi_cs1"; > + pins = "hsspi_cs1"; > + }; > + > + pinctrl_usb_port1_device: usb_port1_device-pins { > + function = "usb_device_port"; > + pins = "usb_port1"; > + }; > + > + pinctrl_usb_port1_host: usb_port1_host-pins { > + function = "usb_host_port"; > + pins = "usb_port1"; > + }; > + }; > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF97C433DB for ; Tue, 16 Mar 2021 21:00:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7798A64F8F for ; Tue, 16 Mar 2021 21:00:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7798A64F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D7vGb8ZNRaApljiusXmA0NmA22WE1GygNesHyNZlwVo=; b=TfGko1ud5/izHkQj6LMcf7Hhj QUlKb2FflIh16F1Otch+KCgaNslPY4FT79uoC606iS7msm0HNsx+Rv65G9AOXuUZOIxWHpXS9JSlN cpYtuXQWe7Uuxsx6+Os2KxAr9WFF87u+KsSvhApmqxqfLtgRvx7I47cRRt87jJIs2p1pJOUw2H07D eHiCXxU53ySOlluSNyxxEh+ghyKLBhHePhWeGtXCLi58kp/8OUvyL7+Z3105iUaG3K8dK9IC7QFKT jr9bumGbxvhEFxLy+qyYqM8oPkADv7B/KgNDTDBw9jxR+wPrSpUS9QfJFJ9Wh2L4g8i+YT02QbGVT r7kWrJbUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMGmc-001r6C-96; Tue, 16 Mar 2021 20:59:18 +0000 Received: from mail-il1-f182.google.com ([209.85.166.182]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMGmU-001r5L-5F for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 20:59:13 +0000 Received: by mail-il1-f182.google.com with SMTP id f10so14023625ilq.5 for ; Tue, 16 Mar 2021 13:59:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xsVrLqfFpXKxNuoRZpVin2JaTCzQFHIEf5rAhS0t1jc=; b=bVggm4sz0ndvlCJVyPNYY0x4CfxQutJFsRBWYNYUG5yrdIc5yNHx0SZecUjo6RWayS 3jYZyQDD33gM0RDlJNmicnZCEc9SZFebPW5IX8TXuZGDcbo8TtxtX60oWh3btmjIyV5B wuTY53mWITiUNG3FKF53/QZezgirQLjNFZVbLCVXEr45HVdNrPzprvQRTLfX/G+ardyh HX/zUXmNe74m2gnV7GdMVoHB5JC07i/TXKyBRiXhGZF0HS/mWAwEE6BNmwKjKnZ8KrRv K25Ewc+mfL1i1cLmXTJHGdjY0KccRFqWY5A7YZpQsZedXv7cTirtbzg6IIn4xg722lFm MiEA== X-Gm-Message-State: AOAM533MsbzRBons4IWmqnN3i7aApQTStVUE57JvZGNCMcgWtiLG0Z17 6iddY0obcTfaeMKYHUXWbA== X-Google-Smtp-Source: ABdhPJwrwf44s8a491QtBFCu7iMS7CHmGjuCHAa3ym10vpMY+nI/W/uVCU+NEjLTT1bOCf9Kk7E25w== X-Received: by 2002:a92:4a0e:: with SMTP id m14mr5359432ilf.117.1615928349009; Tue, 16 Mar 2021 13:59:09 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id t9sm6303046ils.76.2021.03.16.13.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 13:59:08 -0700 (PDT) Received: (nullmailer pid 3653740 invoked by uid 1000); Tue, 16 Mar 2021 20:59:05 -0000 Date: Tue, 16 Mar 2021 14:59:05 -0600 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Lee Jones , Michael Walle , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Message-ID: <20210316205905.GB3629500@robh.at.kernel.org> References: <20210315114214.3096-1-noltari@gmail.com> <20210315114214.3096-6-noltari@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315114214.3096-6-noltari@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_205911_140092_11063004 X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 12:41:57PM +0100, =C1lvaro Fern=E1ndez Rojas wrote: > Add binding documentation for the pincontrol core found in BCM6328 SoCs. > = > Co-developed-by: Jonas Gorski > Signed-off-by: Jonas Gorski > Signed-off-by: =C1lvaro Fern=E1ndez Rojas > --- > v7: add changes suggested by Rob Herring > v6: add changes suggested by Rob Herring > v5: change Documentation to dt-bindings in commit title > v4: no changes > v3: add new gpio node > v2: remove interrupts > = > .../pinctrl/brcm,bcm6328-pinctrl.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,bcm632= 8-pinctrl.yaml > = > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinct= rl.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.ya= ml > new file mode 100644 > index 000000000000..e1ecdc578f32 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm6328-pinctrl.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/brcm,bcm6328-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM6328 pin controller > + > +maintainers: > + - =C1lvaro Fern=E1ndez Rojas > + - Jonas Gorski > + > +description: |+ > + The pin controller node should be the child of a syscon node. > + > + Refer to the the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + compatible: > + const: brcm,bcm6328-pinctrl > + > + reg: > + maxItems: 1 > + > +patternProperties: > + '^.*-pins$': '-pins$' is equivalent. > + if: > + type: object > + then: You don't need this if/then. This should be: '-pins$': type: object $ref: pinmux-node.yaml# additionalProperties: false properties: ... > + properties: > + function: > + $ref: "pinmux-node.yaml#/properties/function" Drop this as you need the $ref up a level. > + enum: [ serial_led_data, serial_led_clk, inet_act_led, pcie_cl= kreq, > + led, ephy0_act_led, ephy1_act_led, ephy2_act_led, > + ephy3_act_led, hsspi_cs1, usb_device_port, usb_host_po= rt ] > + > + pins: > + $ref: "pinmux-node.yaml#/properties/pins" > + enum: [ gpio6, gpio7, gpio11, gpio16, gpio17, gpio18, gpio19, > + gpio20, gpio25, gpio26, gpio27, gpio28, hsspi_cs1, > + usb_port1 ] > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pinctrl@18 { > + compatible =3D "brcm,bcm6328-pinctrl"; > + reg =3D <0x18 0x10>; > + > + pinctrl_serial_led: serial_led-pins { > + pinctrl_serial_led_data: serial_led_data-pins { > + function =3D "serial_led_data"; > + pins =3D "gpio6"; > + }; > + > + pinctrl_serial_led_clk: serial_led_clk-pins { > + function =3D "serial_led_clk"; > + pins =3D "gpio7"; > + }; > + }; > + > + pinctrl_inet_act_led: inet_act_led-pins { > + function =3D "inet_act_led"; > + pins =3D "gpio11"; > + }; > + > + pinctrl_pcie_clkreq: pcie_clkreq-pins { > + function =3D "pcie_clkreq"; > + pins =3D "gpio16"; > + }; > + > + pinctrl_ephy0_spd_led: ephy0_spd_led-pins { > + function =3D "led"; > + pins =3D "gpio17"; > + }; > + > + pinctrl_ephy1_spd_led: ephy1_spd_led-pins { > + function =3D "led"; > + pins =3D "gpio18"; > + }; > + > + pinctrl_ephy2_spd_led: ephy2_spd_led-pins { > + function =3D "led"; > + pins =3D "gpio19"; > + }; > + > + pinctrl_ephy3_spd_led: ephy3_spd_led-pins { > + function =3D "led"; > + pins =3D "gpio20"; > + }; > + > + pinctrl_ephy0_act_led: ephy0_act_led-pins { > + function =3D "ephy0_act_led"; > + pins =3D "gpio25"; > + }; > + > + pinctrl_ephy1_act_led: ephy1_act_led-pins { > + function =3D "ephy1_act_led"; > + pins =3D "gpio26"; > + }; > + > + pinctrl_ephy2_act_led: ephy2_act_led-pins { > + function =3D "ephy2_act_led"; > + pins =3D "gpio27"; > + }; > + > + pinctrl_ephy3_act_led: ephy3_act_led-pins { > + function =3D "ephy3_act_led"; > + pins =3D "gpio28"; > + }; > + > + pinctrl_hsspi_cs1: hsspi_cs1-pins { > + function =3D "hsspi_cs1"; > + pins =3D "hsspi_cs1"; > + }; > + > + pinctrl_usb_port1_device: usb_port1_device-pins { > + function =3D "usb_device_port"; > + pins =3D "usb_port1"; > + }; > + > + pinctrl_usb_port1_host: usb_port1_host-pins { > + function =3D "usb_host_port"; > + pins =3D "usb_port1"; > + }; > + }; > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel