From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213FAC433E0 for ; Wed, 17 Mar 2021 14:01:31 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 44FD564F67 for ; Wed, 17 Mar 2021 14:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44FD564F67 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A6DF44B65B; Wed, 17 Mar 2021 10:01:29 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HYFgeD8ruTPP; Wed, 17 Mar 2021 10:01:28 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 948B84B652; Wed, 17 Mar 2021 10:01:28 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6682E4B650 for ; Wed, 17 Mar 2021 10:01:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aoissdopTF0S for ; Wed, 17 Mar 2021 10:01:22 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9EEAD4B3C3 for ; Wed, 17 Mar 2021 10:01:22 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BCF964F6A; Wed, 17 Mar 2021 14:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615989681; bh=R6KOf4597iuSM4zPgAf8uid9pCmGJM6V8VLQdYKDtuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AMuPGbX/1Rbfsk9QPCfX1ABnBwbsQubBcaLqciEpZlKtAgiqP48jjGh+q9ue11UFc JeLgldqcpVhBn9ZcVzjVr44x/u7Ud8Z7E3oVAajsMohBLdggCeVBxMt5oJf7QxdmH5 NsX1HJxvy8xCxOzCnQMm90gF5LiyhKSFPTjRX/wIys6PtNWW0Eg3jVjAdNtD2wbd/7 yF94m1w1jg4yDHW6iz1rbJ1wESGkHHylcdbEk5IfcI76xeqIQm6uYvS1a+0w3pClan xuRRdZOwm/yfnaLgeUq/MBEQR2rO8EghdnWRxmry+fKdv0LLCSdLyaE/KmwX75vrQO vs6WJ9R7Hocsg== Date: Wed, 17 Mar 2021 14:01:15 +0000 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper Message-ID: <20210317140115.GA5295@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-5-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-5-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kvm@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, broonie@kernel.org, kernel-team@android.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org, daniel.kiss@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Mar 16, 2021 at 10:13:06AM +0000, Marc Zyngier wrote: > The KVM code contains a number of "sve_vq_from_vl(vcpu->arch.sve_max_vl)" > instances, and we are about to add more. > > Introduce vcpu_sve_vq() as a shorthand for this expression. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 4 +++- > arch/arm64/kvm/guest.c | 6 +++--- > arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index fb1d78299ba0..c4afe3d3397f 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -375,6 +375,8 @@ struct kvm_vcpu_arch { > #define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \ > sve_ffr_offset((vcpu)->arch.sve_max_vl)) > > +#define vcpu_sve_vq(vcpu) sve_vq_from_vl((vcpu)->arch.sve_max_vl) nit: maybe vcpu_sve_max_vq() would be a better name? Either way: Acked-by: Will Deacon Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766CFC433DB for ; Wed, 17 Mar 2021 14:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2552A64F69 for ; Wed, 17 Mar 2021 14:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbhCQOBu (ORCPT ); Wed, 17 Mar 2021 10:01:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:48834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbhCQOBV (ORCPT ); Wed, 17 Mar 2021 10:01:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BCF964F6A; Wed, 17 Mar 2021 14:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615989681; bh=R6KOf4597iuSM4zPgAf8uid9pCmGJM6V8VLQdYKDtuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AMuPGbX/1Rbfsk9QPCfX1ABnBwbsQubBcaLqciEpZlKtAgiqP48jjGh+q9ue11UFc JeLgldqcpVhBn9ZcVzjVr44x/u7Ud8Z7E3oVAajsMohBLdggCeVBxMt5oJf7QxdmH5 NsX1HJxvy8xCxOzCnQMm90gF5LiyhKSFPTjRX/wIys6PtNWW0Eg3jVjAdNtD2wbd/7 yF94m1w1jg4yDHW6iz1rbJ1wESGkHHylcdbEk5IfcI76xeqIQm6uYvS1a+0w3pClan xuRRdZOwm/yfnaLgeUq/MBEQR2rO8EghdnWRxmry+fKdv0LLCSdLyaE/KmwX75vrQO vs6WJ9R7Hocsg== Date: Wed, 17 Mar 2021 14:01:15 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper Message-ID: <20210317140115.GA5295@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-5-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316101312.102925-5-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 16, 2021 at 10:13:06AM +0000, Marc Zyngier wrote: > The KVM code contains a number of "sve_vq_from_vl(vcpu->arch.sve_max_vl)" > instances, and we are about to add more. > > Introduce vcpu_sve_vq() as a shorthand for this expression. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 4 +++- > arch/arm64/kvm/guest.c | 6 +++--- > arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index fb1d78299ba0..c4afe3d3397f 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -375,6 +375,8 @@ struct kvm_vcpu_arch { > #define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \ > sve_ffr_offset((vcpu)->arch.sve_max_vl)) > > +#define vcpu_sve_vq(vcpu) sve_vq_from_vl((vcpu)->arch.sve_max_vl) nit: maybe vcpu_sve_max_vq() would be a better name? Either way: Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F39C433DB for ; Wed, 17 Mar 2021 14:03:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 613CC64F5E for ; Wed, 17 Mar 2021 14:03:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 613CC64F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j5wxGDR5VtLEHJoOAzN+h/baKS8BssiDzYtRXhJfXMk=; b=rWDPbqCv5hReNy67b5lASjLsJ CojbU3VYw9pimjK7+S3dLLiBzHH0oXelYqG++f5esyQSvnOYoJNW+YdLP1KWSdKVOpO9xoNvuLOqn oT03yTsq83TQ9GzuShXeF1o3ZuGEi01BBC3AnkSNlqdu9uXEuoySHxHw/rpSVU1wUEgZ1BNNdGqdW Ht+2NgBz1Arkc15Ywfompq7z/Czyc3BnJYN4bziDXZe5JGG7bLsYZlvWM8OAH8Ki+AOsr5TCviBwf WRu5t3t+4/9CXO16iNQbX/UcmjV3c7J2x7CHrsPX84JqxL33dxTMnG92h9T6BI6DfvzqeqeCcK/a+ NXP+MQm5g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMWjo-003CjW-Cg; Wed, 17 Mar 2021 14:01:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMWjk-003Cin-1E for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 14:01:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BCF964F6A; Wed, 17 Mar 2021 14:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615989681; bh=R6KOf4597iuSM4zPgAf8uid9pCmGJM6V8VLQdYKDtuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AMuPGbX/1Rbfsk9QPCfX1ABnBwbsQubBcaLqciEpZlKtAgiqP48jjGh+q9ue11UFc JeLgldqcpVhBn9ZcVzjVr44x/u7Ud8Z7E3oVAajsMohBLdggCeVBxMt5oJf7QxdmH5 NsX1HJxvy8xCxOzCnQMm90gF5LiyhKSFPTjRX/wIys6PtNWW0Eg3jVjAdNtD2wbd/7 yF94m1w1jg4yDHW6iz1rbJ1wESGkHHylcdbEk5IfcI76xeqIQm6uYvS1a+0w3pClan xuRRdZOwm/yfnaLgeUq/MBEQR2rO8EghdnWRxmry+fKdv0LLCSdLyaE/KmwX75vrQO vs6WJ9R7Hocsg== Date: Wed, 17 Mar 2021 14:01:15 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 04/10] KVM: arm64: Introduce vcpu_sve_vq() helper Message-ID: <20210317140115.GA5295@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-5-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-5-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_140124_282749_E5876A92 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 10:13:06AM +0000, Marc Zyngier wrote: > The KVM code contains a number of "sve_vq_from_vl(vcpu->arch.sve_max_vl)" > instances, and we are about to add more. > > Introduce vcpu_sve_vq() as a shorthand for this expression. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 4 +++- > arch/arm64/kvm/guest.c | 6 +++--- > arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index fb1d78299ba0..c4afe3d3397f 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -375,6 +375,8 @@ struct kvm_vcpu_arch { > #define vcpu_sve_pffr(vcpu) (kern_hyp_va((vcpu)->arch.sve_state) + \ > sve_ffr_offset((vcpu)->arch.sve_max_vl)) > > +#define vcpu_sve_vq(vcpu) sve_vq_from_vl((vcpu)->arch.sve_max_vl) nit: maybe vcpu_sve_max_vq() would be a better name? Either way: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel