From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17329C433DB for ; Wed, 17 Mar 2021 16:01:25 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5645064E61 for ; Wed, 17 Mar 2021 16:01:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5645064E61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DE5994B666; Wed, 17 Mar 2021 12:01:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qyqkMPwbJsfy; Wed, 17 Mar 2021 12:01:22 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CC3004B674; Wed, 17 Mar 2021 12:01:22 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BD3784B666 for ; Wed, 17 Mar 2021 12:01:21 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KJO0NGtCfDeJ for ; Wed, 17 Mar 2021 12:01:20 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D2A184B3BF for ; Wed, 17 Mar 2021 12:01:20 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id DD39D64E61; Wed, 17 Mar 2021 16:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615996878; bh=we520fPnvR+Rv9m8n4m+wndrb+dnrLpZXA3mdbq49uQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pPj0efyieA0yEzJ70ka3Gx5g46Q7tkHPeNCzVS+hZCHJG9DAz5vtsER1hfFPzGjFl QLgrDP8Y+IIAfUM7FrzRIiHJOFHwyGmGtphz4nqL3ld80zE1CsNKVZ0QbspYDO/mXW IMrqhSFfmAmQczE45DKGzHw3TyqDRcpjOtFvhNLTEgZRVHJI4uWmNOkeJtK/Zisc1e H74duv2v6hYqIF/ocoWF/KdfM1cYz9K5q2diQzmsT+YLN9PInv/c2U8JwvTsQeZ/bR 1jtAoWfjBUEhyiR4p7Rs3bSgkIIDHBQhCE62fzV0mXGpH1BLvztQauk//LiRUUunEw WSdHWXVl813aw== Date: Wed, 17 Mar 2021 16:01:12 +0000 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH 06/10] KVM: arm64: Map SVE context at EL2 when available Message-ID: <20210317160112.GA5556@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-7-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-7-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kvm@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, broonie@kernel.org, kernel-team@android.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org, daniel.kiss@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Mar 16, 2021 at 10:13:08AM +0000, Marc Zyngier wrote: > When running on nVHE, and that the vcpu supports SVE, map the > SVE state at EL2 so that KVM can access it. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/fpsimd.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index b7e36a506d3d..84afca5ed6f2 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -43,6 +43,17 @@ int kvm_arch_vcpu_run_map_fp(struct kvm_vcpu *vcpu) > if (ret) > goto error; > > + if (vcpu->arch.sve_state) { > + void *sve_end; > + > + sve_end = vcpu->arch.sve_state + vcpu_sve_state_size(vcpu) + 1; Why do you need the '+ 1' here? Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6051C433DB for ; Wed, 17 Mar 2021 16:02:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8ADA64F6C for ; Wed, 17 Mar 2021 16:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbhCQQBf (ORCPT ); Wed, 17 Mar 2021 12:01:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:37040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232301AbhCQQBS (ORCPT ); Wed, 17 Mar 2021 12:01:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD39D64E61; Wed, 17 Mar 2021 16:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615996878; bh=we520fPnvR+Rv9m8n4m+wndrb+dnrLpZXA3mdbq49uQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pPj0efyieA0yEzJ70ka3Gx5g46Q7tkHPeNCzVS+hZCHJG9DAz5vtsER1hfFPzGjFl QLgrDP8Y+IIAfUM7FrzRIiHJOFHwyGmGtphz4nqL3ld80zE1CsNKVZ0QbspYDO/mXW IMrqhSFfmAmQczE45DKGzHw3TyqDRcpjOtFvhNLTEgZRVHJI4uWmNOkeJtK/Zisc1e H74duv2v6hYqIF/ocoWF/KdfM1cYz9K5q2diQzmsT+YLN9PInv/c2U8JwvTsQeZ/bR 1jtAoWfjBUEhyiR4p7Rs3bSgkIIDHBQhCE62fzV0mXGpH1BLvztQauk//LiRUUunEw WSdHWXVl813aw== Date: Wed, 17 Mar 2021 16:01:12 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 06/10] KVM: arm64: Map SVE context at EL2 when available Message-ID: <20210317160112.GA5556@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-7-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316101312.102925-7-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 16, 2021 at 10:13:08AM +0000, Marc Zyngier wrote: > When running on nVHE, and that the vcpu supports SVE, map the > SVE state at EL2 so that KVM can access it. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/fpsimd.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index b7e36a506d3d..84afca5ed6f2 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -43,6 +43,17 @@ int kvm_arch_vcpu_run_map_fp(struct kvm_vcpu *vcpu) > if (ret) > goto error; > > + if (vcpu->arch.sve_state) { > + void *sve_end; > + > + sve_end = vcpu->arch.sve_state + vcpu_sve_state_size(vcpu) + 1; Why do you need the '+ 1' here? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6451C433E0 for ; Wed, 17 Mar 2021 16:02:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8691E64E61 for ; Wed, 17 Mar 2021 16:02:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8691E64E61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NVDwXejBh3NEbGZmJyMaAZPCwDFJYujwZtfzSzbXSOg=; b=Cbpv0YwKFjY8656klx4BTD/V2 ntcBlPzZVWvIQORNRJM1pZliJYDz1UgSqCKCsv2Y+z47ON/y4VbKCmg7xfShZqAIopcr7a3eowFvb T+W2u7aOSt1hfwznz16SdK/PJ7uF1VMuFVcWvH1Yl4HA9xaDII8l4vcEPcwEmvlDXm7ro1YmHhszb itLCjAYRrhGYR1hTC3Sx9jJ8xwUrPiJ5LtpNZNRRHa5N3UFPw07ZVFEIxHz2MLDyRt1QW1Mh+7cx3 Dt93UrwS4kprzFsBXEmdg8CiJ9aP4cK1fr9gsvA+ZJDwA76ILzmLZwND406cEPN5y3xLf5GvoGrEv jtNeI3guQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMYbt-003TqJ-M6; Wed, 17 Mar 2021 16:01:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMYbo-003Tpt-SF for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 16:01:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD39D64E61; Wed, 17 Mar 2021 16:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615996878; bh=we520fPnvR+Rv9m8n4m+wndrb+dnrLpZXA3mdbq49uQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pPj0efyieA0yEzJ70ka3Gx5g46Q7tkHPeNCzVS+hZCHJG9DAz5vtsER1hfFPzGjFl QLgrDP8Y+IIAfUM7FrzRIiHJOFHwyGmGtphz4nqL3ld80zE1CsNKVZ0QbspYDO/mXW IMrqhSFfmAmQczE45DKGzHw3TyqDRcpjOtFvhNLTEgZRVHJI4uWmNOkeJtK/Zisc1e H74duv2v6hYqIF/ocoWF/KdfM1cYz9K5q2diQzmsT+YLN9PInv/c2U8JwvTsQeZ/bR 1jtAoWfjBUEhyiR4p7Rs3bSgkIIDHBQhCE62fzV0mXGpH1BLvztQauk//LiRUUunEw WSdHWXVl813aw== Date: Wed, 17 Mar 2021 16:01:12 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 06/10] KVM: arm64: Map SVE context at EL2 when available Message-ID: <20210317160112.GA5556@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-7-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-7-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_160121_159087_F6F82992 X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 10:13:08AM +0000, Marc Zyngier wrote: > When running on nVHE, and that the vcpu supports SVE, map the > SVE state at EL2 so that KVM can access it. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/fpsimd.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index b7e36a506d3d..84afca5ed6f2 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -43,6 +43,17 @@ int kvm_arch_vcpu_run_map_fp(struct kvm_vcpu *vcpu) > if (ret) > goto error; > > + if (vcpu->arch.sve_state) { > + void *sve_end; > + > + sve_end = vcpu->arch.sve_state + vcpu_sve_state_size(vcpu) + 1; Why do you need the '+ 1' here? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel