From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC46C433E0 for ; Wed, 17 Mar 2021 17:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72C2464EE7 for ; Wed, 17 Mar 2021 17:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbhCQRSF (ORCPT ); Wed, 17 Mar 2021 13:18:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:46412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbhCQRRo (ORCPT ); Wed, 17 Mar 2021 13:17:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87EA864DDA; Wed, 17 Mar 2021 17:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616001464; bh=f3UV9P1ez1H29l2EmF0j0dk0b+DNBxiRJEGlA20Jt7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qCOwbD4OrXNYihuHcVUWjgB96Cox8G+wQdO8UjpBecet6+c9mVYfBWE96NBhWa6KF N6rOyg/RIK28DWvYCjPAudJELrpnPW1bAUnQLHffda+AOY8HGbiJtvdkP2ke8H1Xrw iDYaQo27HauVEDJGrIzwEX6gwTb+qGumbdqXvjgRDpqssM8VxiCBzYBLP++jIhfbP4 iPWbrNEIQw7x9Ojg15j2CFxtbLMQGj+SweOWIkh7FqJmygEPPifeSbcmZAL8Afu481 BdeP8Ml9tx/JhvR/YwDSJL0ojBN4XRFXsyrGmJicZM8LxBiqiLu9et1MjsX9SjRdXq aFC62mSOLlFDw== Date: Wed, 17 Mar 2021 17:17:39 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 07/10] KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state Message-ID: <20210317171738.GA5640@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-8-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316101312.102925-8-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 16, 2021 at 10:13:09AM +0000, Marc Zyngier wrote: > Make sure the guest's ZCR_EL1 is saved before we save/flush the > state. This will be useful in later patches. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/fpsimd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index 84afca5ed6f2..b5f95abd23f5 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -121,10 +121,10 @@ void kvm_arch_vcpu_put_fp(struct kvm_vcpu *vcpu) > local_irq_save(flags); > > if (vcpu->arch.flags & KVM_ARM64_FP_ENABLED) { > - fpsimd_save_and_flush_cpu_state(); > - > if (guest_has_sve) > __vcpu_sys_reg(vcpu, ZCR_EL1) = read_sysreg_el1(SYS_ZCR); > + > + fpsimd_save_and_flush_cpu_state(); I _think_ fpsimd_save_and_flush_cpu_state() contains a RDVL instruction to get at the vector length for sve_get_vl(), and this ends up reading from ZCR_EL1. So I'm not sure it's save to move it like this. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E2DC433DB for ; Wed, 17 Mar 2021 17:17:51 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id BBA7264EE7 for ; Wed, 17 Mar 2021 17:17:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBA7264EE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3DB2A4B675; Wed, 17 Mar 2021 13:17:50 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c-2QgG90yUqW; Wed, 17 Mar 2021 13:17:48 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1AF814B686; Wed, 17 Mar 2021 13:17:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 932724B675 for ; Wed, 17 Mar 2021 13:17:46 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OKdV-b5K+1tM for ; Wed, 17 Mar 2021 13:17:45 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A18054B51C for ; Wed, 17 Mar 2021 13:17:45 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 87EA864DDA; Wed, 17 Mar 2021 17:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616001464; bh=f3UV9P1ez1H29l2EmF0j0dk0b+DNBxiRJEGlA20Jt7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qCOwbD4OrXNYihuHcVUWjgB96Cox8G+wQdO8UjpBecet6+c9mVYfBWE96NBhWa6KF N6rOyg/RIK28DWvYCjPAudJELrpnPW1bAUnQLHffda+AOY8HGbiJtvdkP2ke8H1Xrw iDYaQo27HauVEDJGrIzwEX6gwTb+qGumbdqXvjgRDpqssM8VxiCBzYBLP++jIhfbP4 iPWbrNEIQw7x9Ojg15j2CFxtbLMQGj+SweOWIkh7FqJmygEPPifeSbcmZAL8Afu481 BdeP8Ml9tx/JhvR/YwDSJL0ojBN4XRFXsyrGmJicZM8LxBiqiLu9et1MjsX9SjRdXq aFC62mSOLlFDw== Date: Wed, 17 Mar 2021 17:17:39 +0000 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH 07/10] KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state Message-ID: <20210317171738.GA5640@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-8-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-8-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kvm@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, broonie@kernel.org, kernel-team@android.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org, daniel.kiss@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Mar 16, 2021 at 10:13:09AM +0000, Marc Zyngier wrote: > Make sure the guest's ZCR_EL1 is saved before we save/flush the > state. This will be useful in later patches. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/fpsimd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index 84afca5ed6f2..b5f95abd23f5 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -121,10 +121,10 @@ void kvm_arch_vcpu_put_fp(struct kvm_vcpu *vcpu) > local_irq_save(flags); > > if (vcpu->arch.flags & KVM_ARM64_FP_ENABLED) { > - fpsimd_save_and_flush_cpu_state(); > - > if (guest_has_sve) > __vcpu_sys_reg(vcpu, ZCR_EL1) = read_sysreg_el1(SYS_ZCR); > + > + fpsimd_save_and_flush_cpu_state(); I _think_ fpsimd_save_and_flush_cpu_state() contains a RDVL instruction to get at the vector length for sve_get_vl(), and this ends up reading from ZCR_EL1. So I'm not sure it's save to move it like this. Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA47C433E0 for ; Wed, 17 Mar 2021 17:19:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46D7564EE7 for ; Wed, 17 Mar 2021 17:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46D7564EE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v2XPP2PTjmDjCXzS3IZaMojPOX11Lj7k0/00XaLonq8=; b=NYgO1EOHC8Cqg73RzsmsqFZ/w pWh32upPvmpunSQKf5ZCJ8wkpoYcSVGwd1BJZ+xYmvg/O5Csj2YO9B0SdglF8DG31tMJwmSSykmk1 pVjLtT6ZCLcMZnIfAxvLbbgOY9octrYPisn0e164uO+7LdILzYbQvf2ZPU/KqXTw+XLUjZYzSrsWL kndg9ZP+CCmlnS6y5W+cC3w8qF7FASKziD8U03aIcmE0eVK5QTdjx5hhKEvK3ePU6qTHQkR4yjJ/Y 6DLXhr4HS7yWuS467En9kyOsL1c7k+KuL5RkpDyoYVS2M2vUd2dCxS00+TsufFXnQ4AX2I5DVTgL4 zweLDIyKQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMZnp-003cLU-W8; Wed, 17 Mar 2021 17:17:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMZnm-003cL5-AR for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 17:17:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87EA864DDA; Wed, 17 Mar 2021 17:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616001464; bh=f3UV9P1ez1H29l2EmF0j0dk0b+DNBxiRJEGlA20Jt7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qCOwbD4OrXNYihuHcVUWjgB96Cox8G+wQdO8UjpBecet6+c9mVYfBWE96NBhWa6KF N6rOyg/RIK28DWvYCjPAudJELrpnPW1bAUnQLHffda+AOY8HGbiJtvdkP2ke8H1Xrw iDYaQo27HauVEDJGrIzwEX6gwTb+qGumbdqXvjgRDpqssM8VxiCBzYBLP++jIhfbP4 iPWbrNEIQw7x9Ojg15j2CFxtbLMQGj+SweOWIkh7FqJmygEPPifeSbcmZAL8Afu481 BdeP8Ml9tx/JhvR/YwDSJL0ojBN4XRFXsyrGmJicZM8LxBiqiLu9et1MjsX9SjRdXq aFC62mSOLlFDw== Date: Wed, 17 Mar 2021 17:17:39 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, kernel-team@android.com Subject: Re: [PATCH 07/10] KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state Message-ID: <20210317171738.GA5640@willie-the-truck> References: <20210316101312.102925-1-maz@kernel.org> <20210316101312.102925-8-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316101312.102925-8-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_171746_582582_7D084785 X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 10:13:09AM +0000, Marc Zyngier wrote: > Make sure the guest's ZCR_EL1 is saved before we save/flush the > state. This will be useful in later patches. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/fpsimd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/fpsimd.c b/arch/arm64/kvm/fpsimd.c > index 84afca5ed6f2..b5f95abd23f5 100644 > --- a/arch/arm64/kvm/fpsimd.c > +++ b/arch/arm64/kvm/fpsimd.c > @@ -121,10 +121,10 @@ void kvm_arch_vcpu_put_fp(struct kvm_vcpu *vcpu) > local_irq_save(flags); > > if (vcpu->arch.flags & KVM_ARM64_FP_ENABLED) { > - fpsimd_save_and_flush_cpu_state(); > - > if (guest_has_sve) > __vcpu_sys_reg(vcpu, ZCR_EL1) = read_sysreg_el1(SYS_ZCR); > + > + fpsimd_save_and_flush_cpu_state(); I _think_ fpsimd_save_and_flush_cpu_state() contains a RDVL instruction to get at the vector length for sve_get_vl(), and this ends up reading from ZCR_EL1. So I'm not sure it's save to move it like this. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel