* [RFC 1/1] tegra: video: fix tegra_dc_sor_config_panel()
@ 2021-04-04 23:48 Heinrich Schuchardt
2021-04-11 19:09 ` Anatolij Gustschin
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2021-04-04 23:48 UTC (permalink / raw
To: u-boot
Bitwise OR has a higher operator precedence than the ternary conditional.
Add the missing parentheses.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
I don't have a Tegra system. But the current U-Boot code seems to be
incorrect. 2 << CSTM_ROTCLK_SHIFT | is_lvds is always true with and
without the shift.
Best regards
Heinrich
---
drivers/video/tegra124/sor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/tegra124/sor.c b/drivers/video/tegra124/sor.c
index 95976ee573..ef1a2e6dc0 100644
--- a/drivers/video/tegra124/sor.c
+++ b/drivers/video/tegra124/sor.c
@@ -671,8 +671,8 @@ static void tegra_dc_sor_config_panel(struct tegra_dc_sor_data *sor,
CSTM_ROTCLK_DEFAULT_MASK |
CSTM_LVDS_EN_ENABLE,
2 << CSTM_ROTCLK_SHIFT |
- is_lvds ? CSTM_LVDS_EN_ENABLE :
- CSTM_LVDS_EN_DISABLE);
+ (is_lvds ? CSTM_LVDS_EN_ENABLE :
+ CSTM_LVDS_EN_DISABLE));
tegra_dc_sor_config_pwm(sor, 1024, 1024);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [RFC 1/1] tegra: video: fix tegra_dc_sor_config_panel()
2021-04-04 23:48 [RFC 1/1] tegra: video: fix tegra_dc_sor_config_panel() Heinrich Schuchardt
@ 2021-04-11 19:09 ` Anatolij Gustschin
0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2021-04-11 19:09 UTC (permalink / raw
To: u-boot
On Mon, 5 Apr 2021 01:48:51 +0200
Heinrich Schuchardt xypron.glpk at gmx.de wrote:
...
> ---
> drivers/video/tegra124/sor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-11 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-04 23:48 [RFC 1/1] tegra: video: fix tegra_dc_sor_config_panel() Heinrich Schuchardt
2021-04-11 19:09 ` Anatolij Gustschin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.