From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D789C433B4 for ; Tue, 13 Apr 2021 21:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CA2B611F2 for ; Tue, 13 Apr 2021 21:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348410AbhDMVWa (ORCPT ); Tue, 13 Apr 2021 17:22:30 -0400 Received: from mga04.intel.com ([192.55.52.120]:14834 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231955AbhDMVW3 (ORCPT ); Tue, 13 Apr 2021 17:22:29 -0400 IronPort-SDR: fvbfg4xiS/fhTy/fCuxc4jsztc6zrmRpognrhk9AfEk71AcXCFPCKrolPXaRZN5EbVeNN7lyir A12oSrOn1yEQ== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="192378778" X-IronPort-AV: E=Sophos;i="5.82,220,1613462400"; d="scan'208";a="192378778" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 14:22:06 -0700 IronPort-SDR: 9rzF2Bdx0v7QOidNv5ZqjosswKNcLgHVc7HwI6vb1BBJ5JuIYIasptiFS+n5en9YJK33YUfQ8a Da5yQP51NiTA== X-IronPort-AV: E=Sophos;i="5.82,220,1613462400"; d="scan'208";a="424426038" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 14:22:04 -0700 Date: Tue, 13 Apr 2021 14:22:03 -0700 From: Andi Kleen To: Alex Kogan Cc: linux@armlinux.org.uk, Peter Zijlstra , Ingo Molnar , will.deacon@arm.com, arnd@arndb.de, longman@redhat.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@alien8.de, hpa@zytor.com, x86@kernel.org, guohanjun@huawei.com, jglauber@marvell.com, steven.sistare@oracle.com, daniel.m.jordan@oracle.com, dave.dice@oracle.com Subject: Re: [External] : Re: [PATCH v14 4/6] locking/qspinlock: Introduce starvation avoidance into CNA Message-ID: <20210413212203.GT3762101@tassilo.jf.intel.com> References: <20210401153156.1165900-1-alex.kogan@oracle.com> <20210401153156.1165900-5-alex.kogan@oracle.com> <87mtu2vhzz.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > ms granularity seems very coarse grained for this. Surely > > at some point of spinning you can afford a ktime_get? But ok. > We are reading time when we are at the head of the (main) queue, but > don’t have the lock yet. Not sure about the latency of ktime_get(), but > anything reasonably fast but not necessarily precise should work. Actually cpu_clock / sched_clock (see my other email). These should be fast without corner cases and also monotonic. > > > Could you turn that into a moduleparm which can be changed at runtime? > > Would be strange to have to reboot just to play with this parameter > Yes, good suggestion, thanks. > > > This would also make the code a lot shorter I guess. > So you don’t think we need the command-line parameter, just the module_param? module_params can be changed at the command line too, so yes. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEA4C433ED for ; Tue, 13 Apr 2021 21:25:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B51261244 for ; Tue, 13 Apr 2021 21:25:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B51261244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m0Qavxz14yCKMgqjNCmTv1M1dgbtBScnnaVbimXUraU=; b=KWCTke4R9G+SZpciZ5pE9bjFn yjvnFjwEhbWtjma/BP32shZoCR9PtIw9T/oLId0LmYnBejup3ynNgg2rmdNdSOeER9KXwVrDoEyu7 /FufGIuDDVoRxEBgI8x76ydb4I+y8CxLVBUvOiYfWrdx/eKRHUciCV1ajJ1dPCUPTer40ImYzdrcR c7G7Gy4lAI7HEZKLsvfZUuf1jHhJnJzUgA9qp2eIbA9bNrQERORJGjvilHfBLZr4iF2sqJqXTi1b3 DpqGo9mL/yMEB5jKk7hVLBVCyvW46b5RRMo8E9vXcd7YiesptHzSAlf2JAMfc4x87rEeE54NaUYVq 3CipNncdw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWQUL-00AWhR-MK; Tue, 13 Apr 2021 21:22:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWQUF-00AWbC-Dy for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 21:22:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=piMfdujn7n6/x6SudKHwJdAJWCpA90/QWKjD+xgaFeU=; b=uhLHNCcCfqYNTRqcgqVP0LR1pH FVc+lIBgkXuYDPsVLO1Nn/qu2aM2v18ZBUQkHeIIdpg/dy2RoF1XjsQ5TtCV0PygWgIGCuHLuS3HO FqoddD7WGoSLBVCCBwQsj4PJ1RF0hodBOLPF3irQdAtq9CCri13mcLelS4zf8gdspSqkDRkAiPZD7 HvqD9LukzynSuWgm3ub1nYGf8mbVbKWX7EFP68cAouHzc9PEufV+VwU5ti86+3kvKS5T1ki0EpzlA hvW3zw06U2Y1TcgIigFa8+QUEKpjeeybYfk+EHqWEma1cQcei3zlkoL5HeCiwhTaBPfF5f4WJUxmJ GypwfWJg==; Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWQU8-007Kam-Vc for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 21:22:14 +0000 IronPort-SDR: kCazhpFvXjn/0+5aYXQC7w8AadXB4ZnRODgBJInAMB5H3M9LEGNbd4lYslc1ZLTgGh4tm4ZBnv L1M/GM+LG+Ag== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="192378775" X-IronPort-AV: E=Sophos;i="5.82,220,1613462400"; d="scan'208";a="192378775" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 14:22:06 -0700 IronPort-SDR: 9rzF2Bdx0v7QOidNv5ZqjosswKNcLgHVc7HwI6vb1BBJ5JuIYIasptiFS+n5en9YJK33YUfQ8a Da5yQP51NiTA== X-IronPort-AV: E=Sophos;i="5.82,220,1613462400"; d="scan'208";a="424426038" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 14:22:04 -0700 Date: Tue, 13 Apr 2021 14:22:03 -0700 From: Andi Kleen To: Alex Kogan Cc: linux@armlinux.org.uk, Peter Zijlstra , Ingo Molnar , will.deacon@arm.com, arnd@arndb.de, longman@redhat.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@alien8.de, hpa@zytor.com, x86@kernel.org, guohanjun@huawei.com, jglauber@marvell.com, steven.sistare@oracle.com, daniel.m.jordan@oracle.com, dave.dice@oracle.com Subject: Re: [External] : Re: [PATCH v14 4/6] locking/qspinlock: Introduce starvation avoidance into CNA Message-ID: <20210413212203.GT3762101@tassilo.jf.intel.com> References: <20210401153156.1165900-1-alex.kogan@oracle.com> <20210401153156.1165900-5-alex.kogan@oracle.com> <87mtu2vhzz.fsf@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_142213_045584_DE37E15E X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PiA+IG1zIGdyYW51bGFyaXR5IHNlZW1zIHZlcnkgY29hcnNlIGdyYWluZWQgZm9yIHRoaXMuIFN1 cmVseQo+ID4gYXQgc29tZSBwb2ludCBvZiBzcGlubmluZyB5b3UgY2FuIGFmZm9yZCBhIGt0aW1l X2dldD8gQnV0IG9rLgo+IFdlIGFyZSByZWFkaW5nIHRpbWUgd2hlbiB3ZSBhcmUgYXQgdGhlIGhl YWQgb2YgdGhlIChtYWluKSBxdWV1ZSwgYnV0Cj4gZG9u4oCZdCBoYXZlIHRoZSBsb2NrIHlldC4g Tm90IHN1cmUgYWJvdXQgdGhlIGxhdGVuY3kgb2Yga3RpbWVfZ2V0KCksIGJ1dAo+IGFueXRoaW5n IHJlYXNvbmFibHkgZmFzdCBidXQgbm90IG5lY2Vzc2FyaWx5IHByZWNpc2Ugc2hvdWxkIHdvcmsu CgpBY3R1YWxseSBjcHVfY2xvY2sgLyBzY2hlZF9jbG9jayAoc2VlIG15IG90aGVyIGVtYWlsKS4g VGhlc2Ugc2hvdWxkCmJlIGZhc3Qgd2l0aG91dCBjb3JuZXIgY2FzZXMgYW5kIGFsc28gbW9ub3Rv bmljLgoKPiAKPiA+IENvdWxkIHlvdSB0dXJuIHRoYXQgaW50byBhIG1vZHVsZXBhcm0gd2hpY2gg Y2FuIGJlIGNoYW5nZWQgYXQgcnVudGltZT8KPiA+IFdvdWxkIGJlIHN0cmFuZ2UgdG8gaGF2ZSB0 byByZWJvb3QganVzdCB0byBwbGF5IHdpdGggdGhpcyBwYXJhbWV0ZXIKPiBZZXMsIGdvb2Qgc3Vn Z2VzdGlvbiwgdGhhbmtzLgo+IAo+ID4gVGhpcyB3b3VsZCBhbHNvIG1ha2UgdGhlIGNvZGUgYSBs b3Qgc2hvcnRlciBJIGd1ZXNzLgo+IFNvIHlvdSBkb27igJl0IHRoaW5rIHdlIG5lZWQgdGhlIGNv bW1hbmQtbGluZSBwYXJhbWV0ZXIsIGp1c3QgdGhlIG1vZHVsZV9wYXJhbT8KCm1vZHVsZV9wYXJh bXMgY2FuIGJlIGNoYW5nZWQgYXQgdGhlIGNvbW1hbmQgbGluZSB0b28sIHNvIHllcy4KCi1BbmRp CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==