From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox
Date: Wed, 14 Apr 2021 13:32:59 -0400 [thread overview]
Message-ID: <20210414173259.GY1310@bill-the-cat> (raw)
In-Reply-To: <CAA93ih2Ja8cC0wwX2eYyqAZSDv2L82Bhxw1BfCs8HivT8=-p9g@mail.gmail.com>
On Wed, Apr 14, 2021 at 10:06:04AM +0900, Masami Hiramatsu wrote:
> Hello Tom,
>
> Thank you for your comment!
>
> 2021?4?14?(?) 2:47 Tom Rini <trini@konsulko.com>:
> >
> > On Wed, Apr 14, 2021 at 12:30:15AM +0900, Masami Hiramatsu wrote:
> >
> > > Add device trees for 96boards EE DeveloperBox and basement SynQuacer
> > > SoC dtsi. These files are imported from EDK2 with cosmetic change
> > > and modified for accessing SPI NOR flash.
> > >
> > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> > > ---
> > > arch/arm/dts/DeveloperBox.dts | 146 +++++++++
> > > arch/arm/dts/Makefile | 2
> > > arch/arm/dts/SynQuacer.dtsi | 590 +++++++++++++++++++++++++++++++++++++
> > > arch/arm/dts/SynQuacerCaches.dtsi | 72 +++++
> >
> > This poses a bit of a naming challenge. I assume, but please correct me
> > if I'm wrong, that you don't intend to push these dts files to the Linux
> > kernel. So that means EDK2 is the primary source of the files, yes?
>
> Yes, those are originally written for the EDK2 and I ported it.
OK.
> > We
> > want to keep them as-is from the upstream project, and note that
> > relevant git hash/tag/etc that matches where we pulled from, to make
> > future syncs easier, in the commit message.
>
> Let me confirm what you mean, is the git hash/tag/etc what the commit
> I copied from? and note it in commit message or in the devicetree file?
Correct.
> BTW, I made some changes on it for U-Boot drivers.
> - Enabled OP-TEE node by default (EDK2 checks OP-TEE existance
> and enables it)
> - Add SPI node information for accessing SPI-NOR from U-Boot (EDK2
> embedded such information inside)
> Thus the DeveloperBox.dts may not be kept as-is.
These kinds of changes can be done in something such as
DeveloperBox-u-boot.dtsi. Check out the logic in scripts/Makefile.lib
around automatic inclusion of a "-u-boot.dtsi" file.
> > I assume this is not part of the uniphier family, so we should start by
> > naming these as arch/arm/dts/synquacer-... to fit with the general
> > scheme. Perhaps -developerbox, -core and -caches ?
>
> OK. BTW, I'm not sure what is the best way to use SYS_CPU and SYS_SOC.
> This SoC family name is SynQuacer and the SoC itself is SC2A11.
> In this case,
> CONFIG_SYS_CPU=synquacer
> CONFIG_SYS_SOC=sc2a11
> or
> CONFIG_SYS_SOC=synquacer-sc2a11
I think the first example you list is likely the best.
> > And for any changes
> > we do need, they go in a -u-boot.dtsi file and then potentially
> > automatically included (if it fits in the logic we have today for that)
> > or specifically #included otherwise.
>
> It seems that (CONFIG_SYS_SOC)-u-boot.dtsi is automatically included,
> am I correct?
For the full list and how it works, see scripts/Makefile.lib
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210414/7e7b8e1e/attachment.sig>
next prev parent reply other threads:[~2021-04-14 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <161832714362.562320.8024090839631691588.stgit@localhost>
[not found] ` <161832781487.562320.49203469390042692.stgit@localhost>
2021-04-13 17:47 ` [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox Tom Rini
2021-04-14 1:06 ` Masami Hiramatsu
2021-04-14 17:32 ` Tom Rini [this message]
2021-04-16 9:13 ` Masami Hiramatsu
[not found] ` <161832788118.562320.11063528179837203251.stgit@localhost>
2021-04-13 17:47 ` [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support Tom Rini
2021-04-14 1:12 ` Masami Hiramatsu
2021-04-14 1:27 ` Takahiro Akashi
2021-04-14 2:06 ` Masami Hiramatsu
2021-04-14 4:48 ` Takahiro Akashi
2021-04-14 6:29 ` Masami Hiramatsu
2021-04-14 7:13 ` Takahiro Akashi
2021-04-14 17:35 ` Tom Rini
[not found] ` <161832721269.562320.7735221436131924903.stgit@localhost>
2021-04-14 19:37 ` [PATCH 01/13] pci: Update the highest subordinate bus number for bridge setup Simon Glass
2021-04-15 15:06 ` Tim Harvey
2021-04-16 0:14 ` Masami Hiramatsu
2021-04-16 0:21 ` Tim Harvey
2021-04-16 8:51 ` Masami Hiramatsu
[not found] ` <161832727900.562320.2865719006692739168.stgit@localhost>
2021-04-14 19:37 ` [PATCH 02/13] ata: ahci-pci: Use scsi_ops to initialize ops Simon Glass
[not found] ` <161832734602.562320.10889834449796156249.stgit@localhost>
2021-04-14 19:37 ` [PATCH 03/13] dm: pci: Skip setting VGA bridge bits if parent device is the host bus Simon Glass
2021-04-14 22:30 ` Bin Meng
2021-04-15 2:59 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414173259.GY1310@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.