From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05795C43460 for ; Sun, 25 Apr 2021 14:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D247061245 for ; Sun, 25 Apr 2021 14:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230398AbhDYO7g (ORCPT ); Sun, 25 Apr 2021 10:59:36 -0400 Received: from netrider.rowland.org ([192.131.102.5]:33791 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S230214AbhDYO7f (ORCPT ); Sun, 25 Apr 2021 10:59:35 -0400 Received: (qmail 337276 invoked by uid 1000); 25 Apr 2021 10:58:54 -0400 Date: Sun, 25 Apr 2021 10:58:54 -0400 From: Alan Stern To: Rajat Jain Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, helgaas@kernel.org, rajatxjain@gmail.com, jsbarnes@google.com, dtor@google.com Subject: Re: [PATCH v2 1/2] driver core: Move the "removable" attribute from USB to core Message-ID: <20210425145854.GD336783@rowland.harvard.edu> References: <20210424021631.1972022-1-rajatja@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210424021631.1972022-1-rajatja@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 07:16:30PM -0700, Rajat Jain wrote: > Move the "removable" attribute from USB to core in order to allow > it to be supported by other subsystem / buses. Individual buses > that want to support this attribute can opt-in by setting the > supports_removable flag, and then populating the removable property > of the device while enumerating it. The ABI for the attribute remains > unchanged. > > Signed-off-by: Rajat Jain > --- > v2: Add documentation For the parts affecting the USB core: Acked-by: Alan Stern