All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [ogabbay:next 9/12] drivers/misc/habanalabs/common/firmware_if.c:1369 hl_fw_static_init_cpu() warn: missing error code 'rc'
@ 2021-05-01  0:46 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-05-01  0:46 UTC (permalink / raw
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 27150 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Ohad Sharabi <osharabi@habana.ai>
CC: Oded Gabbay <ogabbay@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git next
head:   ce97151d0dfd690a0db33e6bcdde9db7c39ecb27
commit: 08cd6811265925e075a52e639e017b87dc91cb65 [9/12] habanalabs: dynamic fw load reset protocol
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-m001-20210430 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/misc/habanalabs/common/firmware_if.c:1369 hl_fw_static_init_cpu() warn: missing error code 'rc'

vim +/rc +1369 drivers/misc/habanalabs/common/firmware_if.c

08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1248  
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1249  /**
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1250   * hl_fw_static_init_cpu - initialize the device CPU using static protocol
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1251   *
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1252   * @hdev: pointer to the habanalabs device structure
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1253   * @fw_loader: managing structure for loading device's FW
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1254   *
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1255   * @return 0 on success, otherwise non-zero error code
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1256   */
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1257  static int hl_fw_static_init_cpu(struct hl_device *hdev,
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1258  					struct fw_load_mgr *fw_loader)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1259  {
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1260  	u32 cpu_msg_status_reg, cpu_timeout, msg_to_cpu_reg, status;
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1261  	u32 cpu_boot_status_reg, cpu_security_boot_status_reg;
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1262  	struct asic_fixed_properties *prop = &hdev->asic_prop;
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1263  	struct static_fw_load_mgr *static_loader;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1264  	int rc;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1265  
6a2f5d7098c868 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2021-02-15  1266  	if (!(hdev->fw_components & FW_TYPE_BOOT_CPU))
596553dbf9b235 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-10-01  1267  		return 0;
596553dbf9b235 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-10-01  1268  
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1269  	/* init common loader parameters */
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1270  	static_loader = &fw_loader->static_loader;
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1271  	cpu_msg_status_reg = fw_loader->cpu_cmd_status_to_host_reg;
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1272  	msg_to_cpu_reg = fw_loader->kmd_msg_to_cpu_reg;
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1273  	cpu_timeout = fw_loader->cpu_timeout;
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1274  
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1275  	/* init static loader parameters */
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1276  	cpu_security_boot_status_reg = static_loader->cpu_boot_status_reg;
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1277  	cpu_boot_status_reg = static_loader->cpu_boot_status_reg;
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1278  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1279  	dev_info(hdev->dev, "Going to wait for device boot (up to %lds)\n",
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1280  		cpu_timeout / USEC_PER_SEC);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1281  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1282  	/* Wait for boot FIT request */
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1283  	rc = hl_poll_timeout(
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1284  		hdev,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1285  		cpu_boot_status_reg,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1286  		status,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1287  		status == CPU_BOOT_STATUS_WAITING_FOR_BOOT_FIT,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1288  		10000,
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1289  		fw_loader->boot_fit_timeout);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1290  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1291  	if (rc) {
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1292  		dev_dbg(hdev->dev,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1293  			"No boot fit request received, resuming boot\n");
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1294  	} else {
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1295  		rc = hdev->asic_funcs->load_boot_fit_to_device(hdev);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1296  		if (rc)
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1297  			goto out;
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1298  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1299  		/* Clear device CPU message status */
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1300  		WREG32(cpu_msg_status_reg, CPU_MSG_CLR);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1301  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1302  		/* Signal device CPU that boot loader is ready */
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1303  		WREG32(msg_to_cpu_reg, KMD_MSG_FIT_RDY);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1304  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1305  		/* Poll for CPU device ack */
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1306  		rc = hl_poll_timeout(
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1307  			hdev,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1308  			cpu_msg_status_reg,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1309  			status,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1310  			status == CPU_MSG_OK,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1311  			10000,
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1312  			fw_loader->boot_fit_timeout);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1313  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1314  		if (rc) {
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1315  			dev_err(hdev->dev,
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1316  				"Timeout waiting for boot fit load ack\n");
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1317  			goto out;
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1318  		}
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1319  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1320  		/* Clear message */
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1321  		WREG32(msg_to_cpu_reg, KMD_MSG_NA);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1322  	}
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1323  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1324  	/* Make sure CPU boot-loader is running */
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1325  	rc = hl_poll_timeout(
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1326  		hdev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1327  		cpu_boot_status_reg,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1328  		status,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1329  		(status == CPU_BOOT_STATUS_DRAM_RDY) ||
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1330  		(status == CPU_BOOT_STATUS_NIC_FW_RDY) ||
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1331  		(status == CPU_BOOT_STATUS_READY_TO_BOOT) ||
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1332  		(status == CPU_BOOT_STATUS_SRAM_AVAIL),
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1333  		10000,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1334  		cpu_timeout);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1335  
596553dbf9b235 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-10-01  1336  	dev_dbg(hdev->dev, "uboot status = %d\n", status);
596553dbf9b235 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-10-01  1337  
57799ce9f85c23 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-09-13  1338  	/* Read U-Boot version now in case we will later fail */
15fa3dcdbcd5cc drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1339  	hl_read_device_fw_version(hdev, FW_COMP_BOOT_FIT);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1340  
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1341  	/* Clear reset status since we need to read it again from boot CPU */
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1342  	prop->hard_reset_done_by_fw = false;
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1343  
323b726706be3b drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-10-04  1344  	/* Read boot_cpu security bits */
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1345  	if (prop->fw_security_status_valid) {
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1346  		prop->fw_boot_cpu_security_map =
323b726706be3b drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-10-04  1347  				RREG32(cpu_security_boot_status_reg);
323b726706be3b drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-10-04  1348  
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1349  		if (prop->fw_boot_cpu_security_map &
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1350  				CPU_BOOT_DEV_STS0_FW_HARD_RST_EN)
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1351  			prop->hard_reset_done_by_fw = true;
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1352  
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1353  		dev_dbg(hdev->dev,
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1354  			"Firmware boot CPU security status %#x\n",
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1355  			prop->fw_boot_cpu_security_map);
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1356  	}
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1357  
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1358  	dev_dbg(hdev->dev, "Firmware boot CPU hard-reset is %s\n",
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1359  			prop->hard_reset_done_by_fw ? "enabled" : "disabled");
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1360  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1361  	if (rc) {
57799ce9f85c23 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-09-13  1362  		detect_cpu_boot_status(hdev, status);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1363  		rc = -EIO;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1364  		goto out;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1365  	}
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1366  
6a2f5d7098c868 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2021-02-15  1367  	if (!(hdev->fw_components & FW_TYPE_LINUX)) {
596553dbf9b235 drivers/misc/habanalabs/common/firmware_if.c Oded Gabbay     2020-10-01  1368  		dev_info(hdev->dev, "Skip loading Linux F/W\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26 @1369  		goto out;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1370  	}
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1371  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1372  	if (status == CPU_BOOT_STATUS_SRAM_AVAIL)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1373  		goto out;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1374  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1375  	dev_info(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1376  		"Loading firmware to device, may take some time...\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1377  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1378  	rc = hdev->asic_funcs->load_firmware_to_device(hdev);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1379  	if (rc)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1380  		goto out;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1381  
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1382  	if (fw_loader->skip_bmc) {
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1383  		WREG32(msg_to_cpu_reg, KMD_MSG_SKIP_BMC);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1384  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1385  		rc = hl_poll_timeout(
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1386  			hdev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1387  			cpu_boot_status_reg,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1388  			status,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1389  			(status == CPU_BOOT_STATUS_BMC_WAITING_SKIPPED),
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1390  			10000,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1391  			cpu_timeout);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1392  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1393  		if (rc) {
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1394  			dev_err(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1395  				"Failed to get ACK on skipping BMC, %d\n",
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1396  				status);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1397  			WREG32(msg_to_cpu_reg, KMD_MSG_NA);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1398  			rc = -EIO;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1399  			goto out;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1400  		}
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1401  	}
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1402  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1403  	WREG32(msg_to_cpu_reg, KMD_MSG_FIT_RDY);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1404  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1405  	rc = hl_poll_timeout(
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1406  		hdev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1407  		cpu_boot_status_reg,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1408  		status,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1409  		(status == CPU_BOOT_STATUS_SRAM_AVAIL),
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1410  		10000,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1411  		cpu_timeout);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1412  
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1413  	/* Clear message */
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1414  	WREG32(msg_to_cpu_reg, KMD_MSG_NA);
47f6b41cddf849 drivers/misc/habanalabs/firmware_if.c        Ofir Bitton     2020-04-16  1415  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1416  	if (rc) {
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1417  		if (status == CPU_BOOT_STATUS_FIT_CORRUPTED)
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1418  			dev_err(hdev->dev,
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1419  				"Device reports FIT image is corrupted\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1420  		else
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1421  			dev_err(hdev->dev,
917b79b0967174 drivers/misc/habanalabs/firmware_if.c        Omer Shpigelman 2020-07-04  1422  				"Failed to load firmware to device, %d\n",
917b79b0967174 drivers/misc/habanalabs/firmware_if.c        Omer Shpigelman 2020-07-04  1423  				status);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1424  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1425  		rc = -EIO;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1426  		goto out;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1427  	}
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1428  
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1429  	rc = fw_read_errors(hdev, fw_loader->static_loader.boot_err0_reg,
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1430  					cpu_security_boot_status_reg);
edb07cb69caacb drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-27  1431  	if (rc)
edb07cb69caacb drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-27  1432  		return rc;
edb07cb69caacb drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-27  1433  
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1434  	/* Clear reset status since we need to read again from app */
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1435  	prop->hard_reset_done_by_fw = false;
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1436  
323b726706be3b drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-10-04  1437  	/* Read FW application security bits */
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1438  	if (prop->fw_security_status_valid) {
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1439  		prop->fw_app_security_map =
323b726706be3b drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-10-04  1440  				RREG32(cpu_security_boot_status_reg);
323b726706be3b drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-10-04  1441  
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1442  		if (prop->fw_app_security_map &
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1443  				CPU_BOOT_DEV_STS0_FW_HARD_RST_EN)
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1444  			prop->hard_reset_done_by_fw = true;
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1445  
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1446  		dev_dbg(hdev->dev,
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1447  			"Firmware application CPU security status %#x\n",
2e368560080cf0 drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-16  1448  			prop->fw_app_security_map);
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1449  	}
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1450  
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1451  	dev_dbg(hdev->dev, "Firmware application CPU hard-reset is %s\n",
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1452  			prop->hard_reset_done_by_fw ? "enabled" : "disabled");
6bbb77b9e6f0bd drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-06  1453  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1454  	dev_info(hdev->dev, "Successfully loaded firmware to device\n");
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1455  
edb07cb69caacb drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-27  1456  	return 0;
edb07cb69caacb drivers/misc/habanalabs/common/firmware_if.c Ofir Bitton     2020-12-27  1457  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1458  out:
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1459  	fw_read_errors(hdev, fw_loader->static_loader.boot_err0_reg,
5e4993046d4d73 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-11  1460  					cpu_security_boot_status_reg);
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1461  
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1462  	return rc;
7e1c07dd352509 drivers/misc/habanalabs/firmware_if.c        Oded Gabbay     2020-03-26  1463  }
08cd6811265925 drivers/misc/habanalabs/common/firmware_if.c Ohad Sharabi    2021-04-08  1464  

:::::: The code at line 1369 was first introduced by commit
:::::: 7e1c07dd35250971cd29c60c786ac676179eb7f9 habanalabs: unify and improve device cpu init

:::::: TO: Oded Gabbay <oded.gabbay@gmail.com>
:::::: CC: Oded Gabbay <oded.gabbay@gmail.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35081 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-01  0:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-01  0:46 [ogabbay:next 9/12] drivers/misc/habanalabs/common/firmware_if.c:1369 hl_fw_static_init_cpu() warn: missing error code 'rc' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.