From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FCAC433ED for ; Tue, 11 May 2021 00:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61125616EA for ; Tue, 11 May 2021 00:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbhEKAkQ (ORCPT ); Mon, 10 May 2021 20:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbhEKAkD (ORCPT ); Mon, 10 May 2021 20:40:03 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9FE8C061763 for ; Mon, 10 May 2021 17:38:55 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id i190so14764430pfc.12 for ; Mon, 10 May 2021 17:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XJWqF1l7JEMhfTSAMN74xGPitTqml4QrDOfgb/mUZPk=; b=WbzeIHfGDt63kCkUjaBikTyBcRY/ZDKry+3OoLw5BuxuBqqfkhfcnkq+2k1URPpqX0 QAnx52NV3Bm4+47/3heqwqNYhDUG4PuMRbXHuzUk5KeRv4gqQRqIu+lGtCtTDhod6tfB Ak6TQ5qnfQQZa75ceGGJlW4nVqDnch9yJaMM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XJWqF1l7JEMhfTSAMN74xGPitTqml4QrDOfgb/mUZPk=; b=SG3TGB+ZpI9WP1LJ9ofqFqeqL+Zir6afH9SICxXiTpgWcmaz4uWY6RkH952uZ3zbFh GYhX3JNxA2cWFC2S4GDWU5CYmaALvrxRASFVFO6pkDy2usICPDChQGgevg0cXWGI8XSV gSc0uhmivAVzNwzjkctL9lBaxJhGviLyE8/pJDvRVcw38SDPWPM6nN+zATLKh63VRZCg dKwb8b3AajeU2HrX18D6dygis28iqy5Va7fheyHAn2+N/RwkHeyiynqDSPJ5nSuFfGqF VQ/GZqsN+VPcMOVs4AmX0nQUJOA0tjPBsWqx2HeWqcavPcPxjn4/1FHzNXMbjAIq0La9 gsHw== X-Gm-Message-State: AOAM532R20tDNpYckN71XwEjgc3bYEYK2Jl6xNOtkL82LuZnIZz7Rp/i NCYL+OyYSs8iJFr6C4PYCXUo2g== X-Google-Smtp-Source: ABdhPJyMcN8nhffXO0KOaOE5ORvRU3RWHd9iiSe4s6LJkbYE/BwIifqzKxZr2J3QeOvT3KSIIk7g/Q== X-Received: by 2002:a63:e105:: with SMTP id z5mr8347510pgh.321.1620693535506; Mon, 10 May 2021 17:38:55 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:6765:417e:19fc:9756]) by smtp.gmail.com with ESMTPSA id d26sm12142539pfq.215.2021.05.10.17.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 17:38:55 -0700 (PDT) From: Stephen Boyd To: Andrew Morton , Petr Mladek Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v6 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Mon, 10 May 2021 17:38:38 -0700 Message-Id: <20210511003845.2429846-7-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> References: <20210511003845.2429846-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Acked-by: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index d55bdfb7789c..ddb64ada74c2 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, -- https://chromeos.dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C418C433B4 for ; Tue, 11 May 2021 09:56:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4B226186A for ; Tue, 11 May 2021 09:56:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B226186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lfmau3qjuC4dEqcOilLhCjYaHIFZx/dMNapXERJiIGw=; b=UBBCLgX0psSARYyda+dOSKOuV yZGWfZpTbs71AAZ4bCxnr3Sw+W3NcuwPBENlqBqkYvvNIzYtegWSHnxmD/JLrgqnEVx5fG8keah5/ 9awTN7GHBHwjmbytzz7jykxN0n3N6gu1cxcsYWfKsuy4gU11BoVVY8Nq4C8RIry2suMZrbnKS7xpF ICK64wyixlD4OIzWBToUBeQL+EUqrY3OpWkwadNsJsUByh9+CjtdRVQkd566bRjfebdlYJUzVwa1f 7zE10Und5JcP/6bcHwuJOklaDHpVVI/2CuvKvlnmOlKvR99EKfujOOy4Rfzx7j6UfZo6x/ZZdwmsy UhYKqujTA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgP6d-00GmQF-3y; Tue, 11 May 2021 09:55:11 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgGQN-00FzWt-2Y for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 00:39:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=XJWqF1l7JEMhfTSAMN74xGPitTqml4QrDOfgb/mUZPk=; b=K4UrAUiN9AIWbseSSZ1LfgfSrR kd8bv7Jl1e3FWIwPksV4T61BDxe21+1Pu9NlfoMRKPc+Tx3RwXdaiO/1x5Rhxwh20W2kgh/pBuc0P b+K+XSTwAFndDq3ljT0bLCfCxycxBcDv+C95QNp5W9TzUhF8iJK3lNqFZcv5jDGj2zoB7+LzWMCon iFmll++ybTR99yzc4Zz9IiLJKGBqn0DB1yWS2BtKKZpaVb0Jjle2qeI4s9S8Pg7N/QGs8FMVjxjHT oxHvzwszmTlTzdN7Ky6mbCX0jt0xqIpHx5L136TfpmJtMZTbgbOkJpCLmXtMCTLGbJ1QgT2eC7Bh4 IvzV0uYQ==; Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgGQK-009Dpz-A0 for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 00:38:57 +0000 Received: by mail-pg1-x534.google.com with SMTP id m37so14532820pgb.8 for ; Mon, 10 May 2021 17:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XJWqF1l7JEMhfTSAMN74xGPitTqml4QrDOfgb/mUZPk=; b=WbzeIHfGDt63kCkUjaBikTyBcRY/ZDKry+3OoLw5BuxuBqqfkhfcnkq+2k1URPpqX0 QAnx52NV3Bm4+47/3heqwqNYhDUG4PuMRbXHuzUk5KeRv4gqQRqIu+lGtCtTDhod6tfB Ak6TQ5qnfQQZa75ceGGJlW4nVqDnch9yJaMM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XJWqF1l7JEMhfTSAMN74xGPitTqml4QrDOfgb/mUZPk=; b=FU306d5xLXTraiY+A9GrF3f68ynxgaGrDCQL7spXRneuOaeqXNQnbyqhZqzbuag2dP oTbvJT3G7J0D559/2dDvIK96I2a0yqwa6tWjDJ+BMpIZRjsX4R9w6/2t7EHRfOc/oP5C CAkfnnVqqw3fEibLgdExqAYUNlOtFyh8HtP6FO5Bs5FF3JZgS29d1vShSqYBTfkRdqaF REtV8OfLi1HI9U55jqvQ08mKlGcU0+YQYYwSCoJvDQ8/TdCJK4TBWfBiNy/JJuSx+8JQ +DJvJTdCNYM8b1aQx1pFbsaf0lJG/3d7YxEFbQQT+0bLTM0m6qQz7Jww/Qoc5EpJH2HD vKdA== X-Gm-Message-State: AOAM530r3Fbqhb++v6g31CkkIfH/QAc1QfNhmWhBMNYKywXgRW1HK4ZP Hu6wITjZJrndF3weMFLJDySuOA== X-Google-Smtp-Source: ABdhPJyMcN8nhffXO0KOaOE5ORvRU3RWHd9iiSe4s6LJkbYE/BwIifqzKxZr2J3QeOvT3KSIIk7g/Q== X-Received: by 2002:a63:e105:: with SMTP id z5mr8347510pgh.321.1620693535506; Mon, 10 May 2021 17:38:55 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:6765:417e:19fc:9756]) by smtp.gmail.com with ESMTPSA id d26sm12142539pfq.215.2021.05.10.17.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 17:38:55 -0700 (PDT) From: Stephen Boyd To: Andrew Morton , Petr Mladek Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v6 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Mon, 10 May 2021 17:38:38 -0700 Message-Id: <20210511003845.2429846-7-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> References: <20210511003845.2429846-1-swboyd@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_173856_364269_BB4E5D39 X-CRM114-Status: GOOD ( 14.63 ) /bin/ln: failed to access 'reaver_cache/texts/20210510_173856_364269_BB4E5D39': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_173856_364269_BB4E5D39 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Acked-by: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index d55bdfb7789c..ddb64ada74c2 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, -- https://chromeos.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel