From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC89AC433ED for ; Tue, 11 May 2021 22:19:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A216616EA for ; Tue, 11 May 2021 22:19:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A216616EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A2EB56B006E; Tue, 11 May 2021 18:19:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DF3A6B0070; Tue, 11 May 2021 18:19:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A6C86B0072; Tue, 11 May 2021 18:19:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 721416B006E for ; Tue, 11 May 2021 18:19:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 38BB1AF78 for ; Tue, 11 May 2021 22:19:53 +0000 (UTC) X-FDA: 78130368666.17.CA5DA74 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id 7B534E000107 for ; Tue, 11 May 2021 22:19:23 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E09EE6191C; Tue, 11 May 2021 22:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620771590; bh=gUkAmwj67gu1MoY25mVV7c00HYZC1NsG64HkCPKMRjo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QMpcQYIa7jhYD11gnxYHT8+usShMP4wUKWzUC30NTAoG2IFH+31urgKSWas62Nh+S IyrIbCG+G6iizwaxetSWRSPThfSA2bK8dK8z/b9666rUK7NvK54X5lF6tXpzBildoq 1O6gHu/YRI6rj90h2BX/IvxBt+EFN8XoX2mA5bOw= Date: Tue, 11 May 2021 15:19:49 -0700 From: Andrew Morton To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy Subject: Re: [PATCH v5 9/9] powerpc/mm: Enable move pmd/pud Message-Id: <20210511151949.fa1973124f3aba1ea7abceb9@linux-foundation.org> In-Reply-To: <20210422054323.150993-10-aneesh.kumar@linux.ibm.com> References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-10-aneesh.kumar@linux.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7B534E000107 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QMpcQYIa; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 9co84nci3r439r4dg7w1tccexzf8krs6 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620771563-615531 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Apr 2021 11:13:23 +0530 "Aneesh Kumar K.V" wrote: > mremap HAVE_MOVE_PMD/PUD optimization time comparison for 1GB region: > 1GB mremap - Source PTE-aligned, Destination PTE-aligned > mremap time: 1127034ns > 1GB mremap - Source PMD-aligned, Destination PMD-aligned > mremap time: 508817ns > 1GB mremap - Source PUD-aligned, Destination PUD-aligned > mremap time: 23046ns Well that's nice. How significant is this in practice? How common is it for applications to successfully align the region? Do real-world applications actually benefit from this? Are there userspace libraries (malloc() etc) which should be reworked to fully exploit this? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44893C433ED for ; Tue, 11 May 2021 22:20:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B582616EA for ; Tue, 11 May 2021 22:20:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B582616EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ffsn504vZz3099 for ; Wed, 12 May 2021 08:20:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=QMpcQYIa; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=QMpcQYIa; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FfsmV5M6Zz2xvT for ; Wed, 12 May 2021 08:19:53 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id E09EE6191C; Tue, 11 May 2021 22:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620771590; bh=gUkAmwj67gu1MoY25mVV7c00HYZC1NsG64HkCPKMRjo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QMpcQYIa7jhYD11gnxYHT8+usShMP4wUKWzUC30NTAoG2IFH+31urgKSWas62Nh+S IyrIbCG+G6iizwaxetSWRSPThfSA2bK8dK8z/b9666rUK7NvK54X5lF6tXpzBildoq 1O6gHu/YRI6rj90h2BX/IvxBt+EFN8XoX2mA5bOw= Date: Tue, 11 May 2021 15:19:49 -0700 From: Andrew Morton To: "Aneesh Kumar K.V" Subject: Re: [PATCH v5 9/9] powerpc/mm: Enable move pmd/pud Message-Id: <20210511151949.fa1973124f3aba1ea7abceb9@linux-foundation.org> In-Reply-To: <20210422054323.150993-10-aneesh.kumar@linux.ibm.com> References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-10-aneesh.kumar@linux.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: npiggin@gmail.com, linux-mm@kvack.org, kaleshsingh@google.com, joel@joelfernandes.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 22 Apr 2021 11:13:23 +0530 "Aneesh Kumar K.V" wrote: > mremap HAVE_MOVE_PMD/PUD optimization time comparison for 1GB region: > 1GB mremap - Source PTE-aligned, Destination PTE-aligned > mremap time: 1127034ns > 1GB mremap - Source PMD-aligned, Destination PMD-aligned > mremap time: 508817ns > 1GB mremap - Source PUD-aligned, Destination PUD-aligned > mremap time: 23046ns Well that's nice. How significant is this in practice? How common is it for applications to successfully align the region? Do real-world applications actually benefit from this? Are there userspace libraries (malloc() etc) which should be reworked to fully exploit this?