From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv3] nvme: allow to re-attach namespaces after all paths are down
Date: Tue, 11 May 2021 18:26:11 +0200 [thread overview]
Message-ID: <20210511162611.GA17617@lst.de> (raw)
In-Reply-To: <20210511075919.139624-1-hare@suse.de>
> } else {
> ret = -EINVAL;
> + /*
> + * If multipath is enabled we might hit an ns head with no
> + * paths, but that doesn't indicate it's a shared namespace.
> + */
> + if (nvme_ns_head_multipath(head) &&
> + list_empty(&head->list))
> + goto check_ids;
> if (!is_shared || !head->shared) {
> dev_err(ctrl->device,
> "Duplicate unshared namespace %d\n", nsid);
> goto out_put_ns_head;
> }
> +check_ids:
I think this should simply be:
if (!list_empty(&head->list) && (!is_shared || !head->shared)) {
dev_err(ctrl->device,
"Duplicate unshared namespace %d\n", nsid);
goto out_put_ns_head;
}
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-11 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 7:59 [PATCHv3] nvme: allow to re-attach namespaces after all paths are down Hannes Reinecke
2021-05-11 16:26 ` Christoph Hellwig [this message]
2021-05-12 5:28 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511162611.GA17617@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.