From: Christoph Hellwig <hch@lst.de>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Christoph Hellwig <hch@lst.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>, Jan Kara <jack@suse.cz>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v4] mtd: super: don't rely on mtdblock device minor
Date: Tue, 11 May 2021 18:42:48 +0200 [thread overview]
Message-ID: <20210511164248.GA18867@lst.de> (raw)
In-Reply-To: <YJo42y+lP9peFlkd@makrotopia.org>
On Tue, May 11, 2021 at 08:57:15AM +0100, Daniel Golle wrote:
> > Why are you changing the legacy lookup method that is clearly deprecated
> > in favor of the mdt* syntax?
>
> Because it breaks if part_bits != 1 and despite being legacy, it should
> not break (it would open the wrong MTD device).
Or we should just drop it if it doesn't even work.
> I do check the major number above to be MTD_BLOCK_MAJOR, and in that
> case I assume that my expectations towards private structure will hold
> true. If not, please enlighten me.
No, you can't. There's always the chance some other driver grabs
the major. Take a look at what e.g. ubd does to grab the IDE major.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-05-11 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 21:55 [PATCH] mtd: super: don't reply on mtdblock device minor Daniel Golle
2021-04-08 6:15 ` Miquel Raynal
2021-04-08 20:42 ` [PATCH v2] " Daniel Golle
2021-04-12 15:14 ` [PATCH v3] mtd: super: don't rely " Daniel Golle
2021-05-10 10:18 ` Miquel Raynal
2021-05-10 22:20 ` Daniel Golle
2021-05-10 22:21 ` [PATCH v4] " Daniel Golle
2021-05-11 5:49 ` Christoph Hellwig
2021-05-11 7:57 ` Daniel Golle
2021-05-11 16:42 ` Christoph Hellwig [this message]
2021-05-11 20:17 ` Daniel Golle
2021-05-12 6:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511164248.GA18867@lst.de \
--to=hch@lst.de \
--cc=daniel@makrotopia.org \
--cc=dwmw2@infradead.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.