From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB6AC433B4 for ; Tue, 11 May 2021 17:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C4F2616EA for ; Tue, 11 May 2021 17:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbhEKRaX (ORCPT ); Tue, 11 May 2021 13:30:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20882 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231439AbhEKRaW (ORCPT ); Tue, 11 May 2021 13:30:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620754155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wUoIucdENv8BXOBGPOWkmPen7wxXeM+RypsxgKO+gWo=; b=LpepODsaJhCBf7tmAUeIS6pf04N3au5vAzl26WQuUlPoP6kTLKKzhnJqS8XvyW72HmhyKi 0YwTQpKl6Ql3TzJK7MZr1nLGvVejRF/tm2N9MdN113Oe2Q0NoLvEe5YuRzHrL71EQWfUBF IK7yBfb6uVNBQy2vrIz3Vwyf5nOeaEU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-2PpVad9-M-OG9wywXnaSFA-1; Tue, 11 May 2021 13:29:13 -0400 X-MC-Unique: 2PpVad9-M-OG9wywXnaSFA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 196BD189C446; Tue, 11 May 2021 17:29:13 +0000 (UTC) Received: from fuller.cnet (ovpn-112-7.gru2.redhat.com [10.97.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22D9560C04; Tue, 11 May 2021 17:29:06 +0000 (UTC) Received: by fuller.cnet (Postfix, from userid 1000) id 2ADBC43F79C9; Tue, 11 May 2021 14:29:02 -0300 (-03) Date: Tue, 11 May 2021 14:29:02 -0300 From: Marcelo Tosatti To: Peter Xu Cc: kvm@vger.kernel.org, Paolo Bonzini , Alex Williamson , Sean Christopherson Subject: Re: [patch 1/4] KVM: x86: add start_assignment hook to kvm_x86_ops Message-ID: <20210511172902.GB162107@fuller.cnet> References: <20210510172646.930550753@redhat.com> <20210510172817.934490238@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 11, 2021 at 12:26:08PM -0400, Peter Xu wrote: > On Mon, May 10, 2021 at 02:26:47PM -0300, Marcelo Tosatti wrote: > > Add a start_assignment hook to kvm_x86_ops, which is called when > > kvm_arch_start_assignment is done. > > > > The hook is required to update the wakeup vector of a sleeping vCPU > > when a device is assigned to the guest. > > > > Signed-off-by: Marcelo Tosatti > > > > Index: kvm/arch/x86/include/asm/kvm_host.h > > =================================================================== > > --- kvm.orig/arch/x86/include/asm/kvm_host.h > > +++ kvm/arch/x86/include/asm/kvm_host.h > > @@ -1322,6 +1322,7 @@ struct kvm_x86_ops { > > > > int (*update_pi_irte)(struct kvm *kvm, unsigned int host_irq, > > uint32_t guest_irq, bool set); > > + void (*start_assignment)(struct kvm *kvm); > > void (*apicv_post_state_restore)(struct kvm_vcpu *vcpu); > > bool (*dy_apicv_has_pending_interrupt)(struct kvm_vcpu *vcpu); > > > > Index: kvm/arch/x86/kvm/svm/svm.c > > =================================================================== > > --- kvm.orig/arch/x86/kvm/svm/svm.c > > +++ kvm/arch/x86/kvm/svm/svm.c > > @@ -4601,6 +4601,7 @@ static struct kvm_x86_ops svm_x86_ops __ > > .deliver_posted_interrupt = svm_deliver_avic_intr, > > .dy_apicv_has_pending_interrupt = svm_dy_apicv_has_pending_interrupt, > > .update_pi_irte = svm_update_pi_irte, > > + .start_assignment = NULL, > > Can this be dropped (as default NULL)? Done. > > > .setup_mce = svm_setup_mce, > > > > .smi_allowed = svm_smi_allowed, > > Index: kvm/arch/x86/kvm/vmx/vmx.c > > =================================================================== > > --- kvm.orig/arch/x86/kvm/vmx/vmx.c > > +++ kvm/arch/x86/kvm/vmx/vmx.c > > @@ -7732,6 +7732,7 @@ static struct kvm_x86_ops vmx_x86_ops __ > > .nested_ops = &vmx_nested_ops, > > > > .update_pi_irte = pi_update_irte, > > + .start_assignment = NULL, > > Same here? Done. > > > > #ifdef CONFIG_X86_64 > > .set_hv_timer = vmx_set_hv_timer, > > Index: kvm/arch/x86/kvm/x86.c > > =================================================================== > > --- kvm.orig/arch/x86/kvm/x86.c > > +++ kvm/arch/x86/kvm/x86.c > > @@ -11295,7 +11295,11 @@ bool kvm_arch_can_dequeue_async_page_pre > > > > void kvm_arch_start_assignment(struct kvm *kvm) > > { > > - atomic_inc(&kvm->arch.assigned_device_count); > > + int ret; > > + > > + if (atomic_inc_return(&kvm->arch.assigned_device_count) == 1) > > + if (ret == 1) > > + static_call_cond(kvm_x86_start_assignment)(kvm); > > Maybe "ret" can be dropped too? > > void kvm_arch_start_assignment(struct kvm *kvm) > { > if (atomic_inc_return(&kvm->arch.assigned_device_count) == 1) > static_call_cond(kvm_x86_start_assignment)(kvm); > } > > Otherwise looks good to me. Thanks, Done.