From: Feng Tang <feng.tang@intel.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net,
Mark.Rutland@arm.com, maz@kernel.org, kernel-team@fb.com,
neeraju@codeaurora.org, ak@linux.intel.com,
zhengjun.xing@intel.com
Subject: Re: [PATCH v14 clocksource 6/6] clocksource: Print deviation in nanoseconds for unstable case
Date: Wed, 12 May 2021 10:21:36 +0800 [thread overview]
Message-ID: <20210512022136.GC78351@shbuild999.sh.intel.com> (raw)
In-Reply-To: <20210511233455.2897068-6-paulmck@kernel.org>
On Tue, May 11, 2021 at 04:34:55PM -0700, Paul E. McKenney wrote:
> From: Feng Tang <feng.tang@intel.com>
>
> Currently when an unstable clocksource is detected, the raw counters
> of that clocksource and watchdog will be printed, which can only be
> understood after some math calculation. So print the existing delta in
> nanoseconds to make it easier for humans to check the results.
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> kernel/time/clocksource.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index bbe1bcf44ffa..9c45b98e60e2 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -406,10 +406,10 @@ static void clocksource_watchdog(struct timer_list *unused)
> if (abs(cs_nsec - wd_nsec) > md) {
> pr_warn("timekeeping watchdog on CPU%d: Marking clocksource '%s' as unstable because the skew is too large:\n",
> smp_processor_id(), cs->name);
> - pr_warn(" '%s' wd_now: %llx wd_last: %llx mask: %llx\n",
> - watchdog->name, wdnow, wdlast, watchdog->mask);
> - pr_warn(" '%s' cs_now: %llx cs_last: %llx mask: %llx\n",
> - cs->name, csnow, cslast, cs->mask);
> + pr_warn(" '%s' wd_nesc: %lld wd_now: %llx wd_last: %llx mask: %llx\n",
There is a typo in the message, 'wd_nesc' should be 'wd_nsec' ,
sorry for that.
Thanks,
Feng
> + watchdog->name, wd_nsec, wdnow, wdlast, watchdog->mask);
> + pr_warn(" '%s' cs_nsec: %lld cs_now: %llx cs_last: %llx mask: %llx\n",
> + cs->name, cs_nsec, csnow, cslast, cs->mask);
> if (curr_clocksource == cs)
> pr_warn(" '%s' is current clocksource.\n", cs->name);
> else if (curr_clocksource)
> --
> 2.31.1.189.g2e36527f23
next prev parent reply other threads:[~2021-05-12 2:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 23:34 [PATCH v14 clocksource 0/5] Do not mark clocks unstable due to delays for v5.14 Paul E. McKenney
2021-05-11 23:34 ` [PATCH v14 clocksource 1/6] clocksource: Retry clock read if long delays detected Paul E. McKenney
2021-05-11 23:34 ` [PATCH v14 clocksource 2/6] clocksource: Check per-CPU clock synchronization when marked unstable Paul E. McKenney
2021-05-11 23:34 ` [PATCH v14 clocksource 3/6] clocksource: Limit number of CPUs checked for clock synchronization Paul E. McKenney
2021-05-11 23:34 ` [PATCH v14 clocksource 4/6] clocksource: Reduce clocksource-skew threshold for TSC Paul E. McKenney
2021-05-12 2:18 ` Feng Tang
2021-05-12 3:51 ` Paul E. McKenney
2021-05-12 13:18 ` Feng Tang
2021-05-12 17:14 ` Paul E. McKenney
2021-05-11 23:34 ` [PATCH v14 clocksource 5/6] clocksource: Provide kernel module to test clocksource watchdog Paul E. McKenney
2021-05-13 3:29 ` Feng Tang
2021-05-13 4:01 ` Paul E. McKenney
2021-05-11 23:34 ` [PATCH v14 clocksource 6/6] clocksource: Print deviation in nanoseconds for unstable case Paul E. McKenney
2021-05-12 2:21 ` Feng Tang [this message]
2021-05-12 3:38 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512022136.GC78351@shbuild999.sh.intel.com \
--to=feng.tang@intel.com \
--cc=Mark.Rutland@arm.com \
--cc=ak@linux.intel.com \
--cc=corbet@lwn.net \
--cc=john.stultz@linaro.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=neeraju@codeaurora.org \
--cc=paulmck@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhengjun.xing@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.