From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
"Andrew J. Kroll" <ag784@freenet.buffalo.edu>,
processes-Sapan Bhatia <sapan@corewars.org>
Subject: [PATCH 04/11] tty: n_tty: Fix some misdocumented functions
Date: Thu, 20 May 2021 13:18:59 +0100 [thread overview]
Message-ID: <20210520121906.3468725-5-lee.jones@linaro.org> (raw)
In-Reply-To: <20210520121906.3468725-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/tty/n_tty.c:623: warning: expecting prototype for process_echoes(). Prototype was for __process_echoes() instead
drivers/tty/n_tty.c:1109: warning: expecting prototype for isig(). Prototype was for __isig() instead
drivers/tty/n_tty.c:1268: warning: expecting prototype for n_tty_receive_char(). Prototype was for n_tty_receive_char_special() instead
drivers/tty/n_tty.c:2132: warning: Function parameter or member 'kbuf' not described in 'n_tty_read'
drivers/tty/n_tty.c:2132: warning: Function parameter or member 'cookie' not described in 'n_tty_read'
drivers/tty/n_tty.c:2132: warning: Function parameter or member 'offset' not described in 'n_tty_read'
drivers/tty/n_tty.c:2132: warning: Excess function parameter 'buf' description in 'n_tty_read'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: "Andrew J. Kroll" <ag784@freenet.buffalo.edu>
Cc: processes-Sapan Bhatia <sapan@corewars.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/n_tty.c | 10 +++++-----
drivers/tty/tty_io.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 0ec93f1a61f5d..56d3b43d8a3a4 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -596,7 +596,7 @@ static ssize_t process_output_block(struct tty_struct *tty,
}
/**
- * process_echoes - write pending echo characters
+ * __process_echoes - write pending echo characters
* @tty: terminal device
*
* Write previously buffered echo (and other ldisc-generated)
@@ -1092,7 +1092,7 @@ static void eraser(unsigned char c, struct tty_struct *tty)
}
/**
- * isig - handle the ISIG optio
+ * __isig - handle the ISIG optio
* @sig: signal
* @tty: terminal
*
@@ -1248,7 +1248,7 @@ n_tty_receive_signal_char(struct tty_struct *tty, int signal, unsigned char c)
}
/**
- * n_tty_receive_char - perform processing
+ * n_tty_receive_char_special - perform processing
* @tty: terminal device
* @c: character
*
@@ -2042,11 +2042,11 @@ static int job_control(struct tty_struct *tty, struct file *file)
}
-/**
+/*
* n_tty_read - read function for tty
* @tty: tty device
* @file: file object
- * @buf: userspace buffer pointer
+ * @kbuf: userspace buffer pointer
* @nr: size of I/O
*
* Perform reads for the line discipline. We are guaranteed that the
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index defea9cc20ce9..7431c9e0c2bfe 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1090,7 +1090,7 @@ void tty_write_message(struct tty_struct *tty, char *msg)
/*
- * tty_write - write method for tty device file
+ * file_tty_write - write method for tty device file
* @file: tty file pointer
*
* Write data to a tty device via the line discipline.
--
2.31.1
next prev parent reply other threads:[~2021-05-20 12:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
2021-05-20 12:18 ` Lee Jones
2021-05-20 12:18 ` [PATCH 01/11] tty: vt: selection: Correct misspelled function sel_loadlut() Lee Jones
2021-05-20 12:18 ` [PATCH 02/11] tty: serdev: core: Fix misspelled function name __serdev_device_driver_register() Lee Jones
2021-05-20 12:18 ` [PATCH 03/11] tty: tty_io: Fix a few kernel-doc related misdemeanours Lee Jones
2021-05-20 12:18 ` Lee Jones [this message]
2021-05-20 12:19 ` [PATCH 05/11] tty: tty_buffer: Fix incorrectly documented function __tty_buffer_request_room() Lee Jones
2021-05-20 12:19 ` [PATCH 06/11] tty: tty_jobctrl: Fix 2 incorrectly documented functions Lee Jones
2021-05-20 12:19 ` [PATCH 07/11] tty: pty: Fix incorrectly named function pty_resize() Lee Jones
2021-05-20 12:19 ` [PATCH 08/11] tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read() Lee Jones
2021-05-20 12:19 ` [PATCH 09/11] tty: serial: st-asc: Demote a kernel-doc formatting abuse Lee Jones
2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 10/11] tty: n_gsm: Fix function naming and provide missing param descriptions Lee Jones
2021-05-20 12:19 ` [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb() Lee Jones
2021-05-20 12:19 ` Lee Jones
2021-05-20 12:21 ` Michal Simek
2021-05-20 12:21 ` Michal Simek
2021-05-20 15:07 ` [PATCH 00/11] Rid W=1 warnings from TTY Greg Kroah-Hartman
2021-05-20 15:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520121906.3468725-5-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=ag784@freenet.buffalo.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sapan@corewars.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.