From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182D1C04FF3 for ; Mon, 24 May 2021 19:08:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8DB861411 for ; Mon, 24 May 2021 19:08:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8DB861411 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ratWL+uLAgsLQ3LIStjF3stM1UQmcG718Idn6rw2Rsg=; b=G6kayo8YZS7+3j QuJP/cEkjlYX6zHmfFLwboJxc0NUxs8YlHjUsAD0ckI0JOF8N2qhlY1N3EUo5yMqmcd/HIDWgkwk7 ydyDx5AHDulfGNcQKMtHl8hYjaAAgXQoXOx2RVIRQoIK6qcbSxqej3tjGWcjIBdQNgdn5IQKss95B Ln2q14ymWAIc4LornYZx82TApAviEZ/SPsQb3a9I+O0gCsn++3UyabmK1IRSEgvXBq4Z1TF1t1z+B fzi7YvItnXZM0SIsajLPqpXHMOXOpwwwwa3u8aCo70YLrUCMGTzBlrj0r4v0J1DStHYppDYd5Bstw j4N8Ps1fg303oPlqXAMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llFuf-001bGJ-Qa; Mon, 24 May 2021 19:06:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ll6xK-000nyY-43 for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 09:33:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45A81113E; Mon, 24 May 2021 02:32:53 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 821783F73B; Mon, 24 May 2021 02:32:52 -0700 (PDT) Date: Mon, 24 May 2021 10:32:39 +0100 From: Andre Przywara To: Jaxson Han Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, wei.chen@arm.com Subject: Re: [boot-wrapper PATCH v2 3/8] aarch64: Remove the redundant setup_stack Message-ID: <20210524103231.52a62d6e@slackpad.fritz.box> In-Reply-To: <20210521104807.138269-4-jaxson.han@arm.com> References: <20210521104807.138269-1-jaxson.han@arm.com> <20210521104807.138269-4-jaxson.han@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_023302_237979_83D8172F X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 21 May 2021 18:48:02 +0800 Jaxson Han wrote: > Since we already have set up a stack above, there is no need to do it > again. Indeed, in fact it's a bug: setup_stack expects the logical CPU ID in w0, and here we always call it with w0 being 1. > Signed-off-by: Jaxson Han Reviewed-by: Andre Przywara Thanks! Andre > --- > arch/aarch64/boot.S | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S > index e4f5f3d..ee9886b 100644 > --- a/arch/aarch64/boot.S > +++ b/arch/aarch64/boot.S > @@ -39,7 +39,6 @@ _start: > ldr x1, =flag_keep_el > str w0, [x1] > > - bl setup_stack > b start_keep_el > > /* _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel