From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8273C2B9F8 for ; Tue, 25 May 2021 11:20:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DC126140B for ; Tue, 25 May 2021 11:20:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DC126140B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ro47B95522Sgg/uCh69EehMPboOuZ5ncGEiC2wUDKns=; b=r4s4iZ+7lgTWsU 32mfqFKjH4SXaTcgKyJPvLr9Nu53JayceWWv59Epj0G3GEmqrOJ8GJUNp88nF3/ceCL4ul+aWniY/ 9dorAC1EjnBMuEfUypYAYuHUTEN35g79sTYQXaYq9i1qtfe48QDWm5Ttgl25gKYxG0q6QJAQr5hcd uyxYjgRcpjIDUnLrNsmAWd5iA9gmmNegi86Fut68MXj97dHzv5NyDJlewrR8HSUvm8KtJ0Os4FG2I bPjZIqxbmw5YHF01Zm+pCYzjkEouP8smZ3zdeA2YItHLyit80A4kgBMvN5wr3/fTkCZhq6zk9D2jk TyofY8urbd9vMeMOk32Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llV5H-004iTC-3B; Tue, 25 May 2021 11:18:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llV5D-004iRq-9z for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 11:18:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 067CB6141B; Tue, 25 May 2021 11:18:44 +0000 (UTC) Date: Tue, 25 May 2021 12:18:42 +0100 From: Catalin Marinas To: Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, mark.rutland@arm.com, maz@kernel.org, ardb@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, robin.murphy@arm.com Subject: Re: [PATCH v3 07/18] arm64: Downgrade flush_icache_range to invalidate Message-ID: <20210525111842.GG15564@arm.com> References: <20210520124406.2731873-1-tabba@google.com> <20210520124406.2731873-8-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520124406.2731873-8-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_041847_395767_E86B69F3 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 01:43:55PM +0100, Fuad Tabba wrote: > Since __flush_dcache_area is called right before, > invalidate_icache_range is sufficient in this case. > > Rewrite the comment to better explain the rationale behind the > cache maintenance operations used here. > > No functional change intended. > Possible performance impact due to invalidating only the icache > rather than invalidating and cleaning both caches. > > Reported-by: Catalin Marinas > Reported-by: Will Deacon > Link: https://lore.kernel.org/linux-arch/20200511110014.lb9PEahJ4hVOYrbwIb_qUHXyNy9KQzNFdb_I3YlzY6A@z/ > Signed-off-by: Fuad Tabba Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel