From: Fox Chen <foxhlchen@gmail.com>
To: neilb@suse.de
Cc: Fox Chen <foxhlchen@gmail.com>,
corbet@lwn.net, vegard.nossum@oracle.com,
viro@zeniv.linux.org.uk, rdunlap@infradead.org,
grandmaster@al2klimov.de, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: [PATCH v3 11/13] docs: path-lookup: update get_link() ->follow_link description
Date: Thu, 27 May 2021 17:16:16 +0800 [thread overview]
Message-ID: <20210527091618.287093-12-foxhlchen@gmail.com> (raw)
In-Reply-To: <20210527091618.287093-1-foxhlchen@gmail.com>
get_link() is merged into pick_link(). i_op->follow_link is
replaced with i_op->get_link(). get_link() can return ERR_PTR(0)
which equals NULL.
Signed-off-by: Fox Chen <foxhlchen@gmail.com>
---
Documentation/filesystems/path-lookup.rst | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/Documentation/filesystems/path-lookup.rst b/Documentation/filesystems/path-lookup.rst
index 08e6306af5b1..3f03fbbc9429 100644
--- a/Documentation/filesystems/path-lookup.rst
+++ b/Documentation/filesystems/path-lookup.rst
@@ -1136,10 +1136,10 @@ Symlinks with no final component
A pair of special-case symlinks deserve a little further explanation.
Both result in a new ``struct path`` (with mount and dentry) being set
-up in the ``nameidata``, and result in ``get_link()`` returning ``NULL``.
+up in the ``nameidata``, and result in ``pick_link()`` returning ``NULL``.
The more obvious case is a symlink to "``/``". All symlinks starting
-with "``/``" are detected in ``get_link()`` which resets the ``nameidata``
+with "``/``" are detected in ``pick_link()`` which resets the ``nameidata``
to point to the effective filesystem root. If the symlink only
contains "``/``" then there is nothing more to do, no components at all,
so ``NULL`` is returned to indicate that the symlink can be released and
@@ -1156,12 +1156,11 @@ something that looks like a symlink. It is really a reference to the
target file, not just the name of it. When you ``readlink`` these
objects you get a name that might refer to the same file - unless it
has been unlinked or mounted over. When ``walk_component()`` follows
-one of these, the ``->follow_link()`` method in "procfs" doesn't return
+one of these, the ``->get_link()`` method in "procfs" doesn't return
a string name, but instead calls ``nd_jump_link()`` which updates the
-``nameidata`` in place to point to that target. ``->follow_link()`` then
-returns ``NULL``. Again there is no final component and ``get_link()``
-reports this by leaving the ``last_type`` field of ``nameidata`` as
-``LAST_BIND``.
+``nameidata`` in place to point to that target. ``->get_link()`` then
+returns ``NULL``. Again there is no final component and ``pick_link()``
+returns ``NULL``.
Following the symlink in the final component
--------------------------------------------
--
2.31.1
next prev parent reply other threads:[~2021-05-27 9:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 9:16 [PATCH v3 00/13] docs: path-lookup: Update pathlookup docs Fox Chen
2021-05-27 9:16 ` [PATCH v3 01/13] docs: path-lookup: update follow_managed() part Fox Chen
2021-05-27 9:16 ` [PATCH v3 02/13] docs: path-lookup: update path_to_nameidata() part Fox Chen
2021-05-27 9:16 ` [PATCH v3 03/13] docs: path-lookup: update path_mountpoint() part Fox Chen
2021-05-27 9:16 ` [PATCH v3 04/13] docs: path-lookup: update do_last() part Fox Chen
2021-05-27 9:16 ` [PATCH v3 05/13] docs: path-lookup: remove filename_mountpoint Fox Chen
2021-05-27 9:16 ` [PATCH v3 06/13] docs: path-lookup: Add macro name to symlink limit description Fox Chen
2021-05-27 9:16 ` [PATCH v3 07/13] docs: path-lookup: i_op->follow_link replaced with i_op->get_link Fox Chen
2021-05-27 9:16 ` [PATCH v3 08/13] docs: path-lookup: update i_op->put_link and cookie description Fox Chen
2021-05-27 9:16 ` [PATCH v3 09/13] docs: path-lookup: no get_link() Fox Chen
2021-05-27 9:16 ` [PATCH v3 10/13] docs: path-lookup: update WALK_GET, WALK_PUT desc Fox Chen
2021-06-17 22:31 ` NeilBrown
2021-05-27 9:16 ` Fox Chen [this message]
2021-05-27 9:16 ` [PATCH v3 12/13] docs: path-lookup: update symlink description Fox Chen
2021-05-27 9:16 ` [PATCH v3 13/13] docs: path-lookup: use bare function() rather than literals Fox Chen
2021-06-17 22:35 ` [PATCH v3 00/13] docs: path-lookup: Update pathlookup docs NeilBrown
2021-06-18 1:00 ` Fox Chen
2021-06-18 17:39 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527091618.287093-12-foxhlchen@gmail.com \
--to=foxhlchen@gmail.com \
--cc=corbet@lwn.net \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rdunlap@infradead.org \
--cc=vegard.nossum@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.