From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C709CC47083 for ; Wed, 2 Jun 2021 12:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA33E613D2 for ; Wed, 2 Jun 2021 12:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbhFBMlY (ORCPT ); Wed, 2 Jun 2021 08:41:24 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:1824 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbhFBMlX (ORCPT ); Wed, 2 Jun 2021 08:41:23 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 152Ca3Hf015153; Wed, 2 Jun 2021 07:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=b+kZOYy8iFYeTlGyUQ+o3peomPw8V47ZU6e59cuq6sE=; b=cyF6i0qiCn65+uEcTZeUzTK3V40jyzAdgaZN/xGNc07zInlrfgo7LUfWL0RbiVLy1fGE JUB41adnpvpBTVhvcqSb/txapQlLS3K4lIWsfFXEzchawH0g2PyJ5a8KKYU0szs2jIn3 PtWlpHLEXKSwTLVgJbhsjYSG1xwZ97vLxlAKsBl7Lt0tFg07Hpzpo6vtYWtU672tg3X9 zQn+KYdB7cfVgKPUT2TRx4PI0e6PlRjay50yUXnz4HJslADIyrWL0GCikbgA7BVyy3ox VVQL3IbiHv7UyTBB7hgwgwZ/RQ229IJbraM1fkH0EyM+6ZQJzkPsbN4RSs1G3/ro4+AX YQ== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 38x650r8uw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 02 Jun 2021 07:39:27 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 2 Jun 2021 13:39:25 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.4 via Frontend Transport; Wed, 2 Jun 2021 13:39:25 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id ACFE52BA; Wed, 2 Jun 2021 12:39:25 +0000 (UTC) Date: Wed, 2 Jun 2021 12:39:25 +0000 From: Charles Keepax To: Zhen Lei CC: Lee Jones , patches , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 1/9] mfd: wm831x: use DEVICE_ATTR_RO macro Message-ID: <20210602123925.GE9223@ediswmail.ad.cirrus.com> References: <20210602114339.11223-1-thunder.leizhen@huawei.com> <20210602114339.11223-2-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210602114339.11223-2-thunder.leizhen@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: -OU_U1jVTOwYmAeYQ1d9ICfcPtKJJwPb X-Proofpoint-ORIG-GUID: -OU_U1jVTOwYmAeYQ1d9ICfcPtKJJwPb X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=936 impostorscore=0 spamscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020081 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 02, 2021 at 07:43:31PM +0800, Zhen Lei wrote: > Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes > the code a bit shorter and easier to read. > > Signed-off-by: Zhen Lei > --- Acked-by: Charles Keepax Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4241CC4708F for ; Wed, 2 Jun 2021 13:03:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F383613D7 for ; Wed, 2 Jun 2021 13:03:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F383613D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h5P5KyDRDtqtG/4sqHAiGbldV1GMI+ZEtYhKjFNecfo=; b=DgQt6aFUJPYBhW NBhrw5fu9cU/MVjUEZ2NyCvxAQWdtbgbLhmbRXJr7h+Q4DpqpAGX4HORtwbKJ4us146NUHwH7gUAV houaMj9iklKlWfOkZQZlXpJv9dik5mMnDy2+lQ8tOnJgTTgdnEPuUJZn7+mDNZILZjvzh1cdMyMbK o1NceFVQvNKNALeaZg8sRBS9Xv5w+wK7TDKQ2wuZLXc91SezpZ3VlvmOPmk2XOTihhijBj2IxOCAE kF1TlkcFYxy4JPvCQ4syrcmQB0ETOgQr7G/jLiAcE9L2JTeqo/nt3C7GwVGBA5e8st0YbQq9mygL4 69dPmyhSH3XhH/L7BEWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loQUw-004DcX-9Z; Wed, 02 Jun 2021 13:01:27 +0000 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loQ9o-00482G-5W for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 12:39:40 +0000 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 152Ca3Hf015153; Wed, 2 Jun 2021 07:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=b+kZOYy8iFYeTlGyUQ+o3peomPw8V47ZU6e59cuq6sE=; b=cyF6i0qiCn65+uEcTZeUzTK3V40jyzAdgaZN/xGNc07zInlrfgo7LUfWL0RbiVLy1fGE JUB41adnpvpBTVhvcqSb/txapQlLS3K4lIWsfFXEzchawH0g2PyJ5a8KKYU0szs2jIn3 PtWlpHLEXKSwTLVgJbhsjYSG1xwZ97vLxlAKsBl7Lt0tFg07Hpzpo6vtYWtU672tg3X9 zQn+KYdB7cfVgKPUT2TRx4PI0e6PlRjay50yUXnz4HJslADIyrWL0GCikbgA7BVyy3ox VVQL3IbiHv7UyTBB7hgwgwZ/RQ229IJbraM1fkH0EyM+6ZQJzkPsbN4RSs1G3/ro4+AX YQ== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 38x650r8uw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 02 Jun 2021 07:39:27 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 2 Jun 2021 13:39:25 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.4 via Frontend Transport; Wed, 2 Jun 2021 13:39:25 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id ACFE52BA; Wed, 2 Jun 2021 12:39:25 +0000 (UTC) Date: Wed, 2 Jun 2021 12:39:25 +0000 From: Charles Keepax To: Zhen Lei CC: Lee Jones , patches , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 1/9] mfd: wm831x: use DEVICE_ATTR_RO macro Message-ID: <20210602123925.GE9223@ediswmail.ad.cirrus.com> References: <20210602114339.11223-1-thunder.leizhen@huawei.com> <20210602114339.11223-2-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602114339.11223-2-thunder.leizhen@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: -OU_U1jVTOwYmAeYQ1d9ICfcPtKJJwPb X-Proofpoint-ORIG-GUID: -OU_U1jVTOwYmAeYQ1d9ICfcPtKJJwPb X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=936 impostorscore=0 spamscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020081 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_053936_374657_80020433 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 02, 2021 at 07:43:31PM +0800, Zhen Lei wrote: > Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes > the code a bit shorter and easier to read. > > Signed-off-by: Zhen Lei > --- Acked-by: Charles Keepax Thanks, Charles _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel