* [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_*
@ 2021-06-10 16:41 Richard Henderson
2021-06-10 17:25 ` Luis Fernando Fujita Pires
2021-06-11 11:17 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2021-06-10 16:41 UTC (permalink / raw
To: qemu-devel; +Cc: Peter Maydell
At some point during the development of tcg_constant_*, I changed
my mind about whether such temps should be able to be passed to
tcg_temp_free_*. The final version committed allows this, but the
commentary was not updated to match.
Fixes: c0522136adf
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/tcg/tcg.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
index 1d056ed0ed..064dab383b 100644
--- a/include/tcg/tcg.h
+++ b/include/tcg/tcg.h
@@ -1095,7 +1095,8 @@ TCGv_vec tcg_const_ones_vec_matching(TCGv_vec);
/*
* Locate or create a read-only temporary that is a constant.
- * This kind of temporary need not and should not be freed.
+ * This kind of temporary need not be freed, but for convenience
+ * will be silently ignored by tcg_temp_free_*.
*/
TCGTemp *tcg_constant_internal(TCGType type, int64_t val);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_*
2021-06-10 16:41 [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_* Richard Henderson
@ 2021-06-10 17:25 ` Luis Fernando Fujita Pires
2021-06-11 11:17 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Luis Fernando Fujita Pires @ 2021-06-10 17:25 UTC (permalink / raw
To: Richard Henderson, qemu-devel@nongnu.org; +Cc: Peter Maydell
From: Richard Henderson <richard.henderson@linaro.org>
> At some point during the development of tcg_constant_*, I changed my mind
> about whether such temps should be able to be passed to tcg_temp_free_*.
> The final version committed allows this, but the commentary was not updated
> to match.
>
> Fixes: c0522136adf
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/tcg/tcg.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_*
2021-06-10 16:41 [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_* Richard Henderson
2021-06-10 17:25 ` Luis Fernando Fujita Pires
@ 2021-06-11 11:17 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2021-06-11 11:17 UTC (permalink / raw
To: Richard Henderson; +Cc: Peter Maydell, qemu-devel
Richard Henderson <richard.henderson@linaro.org> writes:
> At some point during the development of tcg_constant_*, I changed
> my mind about whether such temps should be able to be passed to
> tcg_temp_free_*. The final version committed allows this, but the
> commentary was not updated to match.
>
> Fixes: c0522136adf
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-11 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-10 16:41 [PATCH] tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_* Richard Henderson
2021-06-10 17:25 ` Luis Fernando Fujita Pires
2021-06-11 11:17 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.