From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B99CC48BE5 for ; Tue, 15 Jun 2021 09:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D2DC6115C for ; Tue, 15 Jun 2021 09:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhFOJ2P (ORCPT ); Tue, 15 Jun 2021 05:28:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbhFOJ2L (ORCPT ); Tue, 15 Jun 2021 05:28:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3C4C61432; Tue, 15 Jun 2021 09:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623749167; bh=ysXE/y+QAGb8h7lBlVwFdUaiG4ulp9691EwnClnpiPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ltj3upRZDSv0lisL9uSpML8p7k8nql/Kcs9bD6lVWV1r+GEaBA9GzFRpJAq+LumR1 YqkzCIOkfqEBfg2SfNqm9bFcc2MdJvUv0OcF1sduLdF/YrdkPveXM0q+I+qSkzdPWO eBPAhtfMYs93tQ4HweLwCgq+xubZnHZrLl+sPkYD3q/0wKWAgbE2X0ot8k6DLCiEoS d1qy9dBnOg/3YDuMnZvhZ8W7WGfO7Z7ToB3K61HfxsAKkOAkur/lNg7vkFRim+vdl5 K0SSGz1+gKrGp27mHThH3Z0RefL3RApX3ro6SxGh/eCRyJ9ckfE9yhkTeGDOPwlVlx ODE0elsN2657Q== Date: Tue, 15 Jun 2021 10:26:02 +0100 From: Will Deacon To: Jonathan Cameron Cc: Qi Liu , mark.rutland@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhangshaokun@hisilicon.com Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20210615092601.GA19878@willie-the-truck> References: <1622467951-32114-1-git-send-email-liuqi115@huawei.com> <1622467951-32114-3-git-send-email-liuqi115@huawei.com> <20210611162347.GA16284@willie-the-truck> <20210614102025.0000222b@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614102025.0000222b@Huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 10:20:25AM +0100, Jonathan Cameron wrote: > On Fri, 11 Jun 2021 17:23:48 +0100 > Will Deacon wrote: > > > On Mon, May 31, 2021 at 09:32:31PM +0800, Qi Liu wrote: > > > PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported > > > to sample bandwidth, latency, buffer occupation etc. > > > > > > Each PMU RCiEP device monitors multiple Root Ports, and each RCiEP is > > > registered as a PMU in /sys/bus/event_source/devices, so users can > > > select target PMU, and use filter to do further sets. > > > > > > Filtering options contains: > > > event - select the event. > > > subevent - select the subevent. > > > port - select target Root Ports. Information of Root Ports > > > are shown under sysfs. > > > bdf - select requester_id of target EP device. > > > trig_len - set trigger condition for starting event statistics. > > > trigger_mode - set trigger mode. 0 means starting to statistic when > > > bigger than trigger condition, and 1 means smaller. > > > thr_len - set threshold for statistics. > > > thr_mode - set threshold mode. 0 means count when bigger than > > > threshold, and 1 means smaller. > > > > > > Reviewed-by: John Garry > > > Signed-off-by: Qi Liu > > > --- > > > MAINTAINERS | 6 + > > > drivers/perf/Kconfig | 2 + > > > drivers/perf/Makefile | 1 + > > > drivers/perf/pci/Kconfig | 16 + > > > drivers/perf/pci/Makefile | 2 + > > > drivers/perf/pci/hisilicon/Makefile | 3 + > > > drivers/perf/pci/hisilicon/hisi_pcie_pmu.c | 1019 ++++++++++++++++++++++++++++ > > > > Can we keep this under drivers/perf/hisilicon/ please? I don't see the > > need to create a 'pci' directory here. > > https://lore.kernel.org/linux-pci/20190103154439.GC16311@edgewater-inn.cambridge.arm.com/ > > Discussion back in 2018 about where to put these... I don't remember that at all :) > Though, perf/pci/hisilicon does seem over the top in terms of depth, maybe perf/pci/ > or just give up on that plan and put them (for now at least) in per company directories. I think perf/hisilicon makes the most sense. We can always move it later if we need to. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F35CC48BDF for ; Tue, 15 Jun 2021 16:13:58 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A00D61603 for ; Tue, 15 Jun 2021 16:13:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A00D61603 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nVzdYNM9+qfE/tCmdP7Ia4PjThXs98pqM6mSqYaupjg=; b=bJl4BNo2RUpom/ NO8BXL25EE1X0WqgQTMtIm3/kGWq7UCC0CiFYwWf1UYbys7tfkjMBggwtOnAQ1QDYihk+XPeGzhYc UBvvPG7b0BYqrMucBEx/oBKZMl8sVcQasa3nhPdNT5nBNUuYovTtxjzsFAEcaIqXObEVp4J/A0eIQ 2c43sLLoDd4JXuCSeW+BFENDWdib5BF6qKsc5rkAoq7RZyZR/8Q8lRpbR4JTn3U9ytc+5BYmfX5hn i84EEUWcevHUQ20BrZd3tTHFjAMsts7CT6CR80IK9Xa3lrLVvyoWorl759lJ3hEos9Ak3pvdZakni kOxrjY3MIeJUnDQSVz1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltBaS-001DYS-6e; Tue, 15 Jun 2021 16:06:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9I9-000E8e-6N for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:39:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E7kBuCJ46hCNrTIrvLH7dFAWQrj6U1zbiK+BHu083HU=; b=LGLpJHeWaq1L+wb8+ZQAfAEHPp 0vmXvpPpk9uC/u/b6/GSOmwapt8HOqW12knBmOcFp878PuijLVhVyDKz+XmUA7bUNmo9BqvWkl0Ha N1F75cZ6+CVo4rZ7NN8T7q+3IV0oDjacaXnOgfwUgJKlfRjQbFfFnQjTFvjg7dh81rZ4V7OJcGDXj k01hncYDJAb4HuY71zfw+UWUe4KcJTKpINBRbdeW9c6Ow6A1cps0wTiA2ltHo4a34/WPa4i3h/k3M 929LyXcnB+zdgKnCURZg+KyWsg/GeJUThdulJaMA+9RU7USH0RRSwhKlAhjwtNueX4GJg5BK5fxbG PksGEVZg==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt5Kf-007ZFV-Om for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 09:26:14 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3C4C61432; Tue, 15 Jun 2021 09:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623749167; bh=ysXE/y+QAGb8h7lBlVwFdUaiG4ulp9691EwnClnpiPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ltj3upRZDSv0lisL9uSpML8p7k8nql/Kcs9bD6lVWV1r+GEaBA9GzFRpJAq+LumR1 YqkzCIOkfqEBfg2SfNqm9bFcc2MdJvUv0OcF1sduLdF/YrdkPveXM0q+I+qSkzdPWO eBPAhtfMYs93tQ4HweLwCgq+xubZnHZrLl+sPkYD3q/0wKWAgbE2X0ot8k6DLCiEoS d1qy9dBnOg/3YDuMnZvhZ8W7WGfO7Z7ToB3K61HfxsAKkOAkur/lNg7vkFRim+vdl5 K0SSGz1+gKrGp27mHThH3Z0RefL3RApX3ro6SxGh/eCRyJ9ckfE9yhkTeGDOPwlVlx ODE0elsN2657Q== Date: Tue, 15 Jun 2021 10:26:02 +0100 From: Will Deacon To: Jonathan Cameron Cc: Qi Liu , mark.rutland@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhangshaokun@hisilicon.com Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20210615092601.GA19878@willie-the-truck> References: <1622467951-32114-1-git-send-email-liuqi115@huawei.com> <1622467951-32114-3-git-send-email-liuqi115@huawei.com> <20210611162347.GA16284@willie-the-truck> <20210614102025.0000222b@Huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210614102025.0000222b@Huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_102612_821920_88A62F0F X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 10:20:25AM +0100, Jonathan Cameron wrote: > On Fri, 11 Jun 2021 17:23:48 +0100 > Will Deacon wrote: > > > On Mon, May 31, 2021 at 09:32:31PM +0800, Qi Liu wrote: > > > PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported > > > to sample bandwidth, latency, buffer occupation etc. > > > > > > Each PMU RCiEP device monitors multiple Root Ports, and each RCiEP is > > > registered as a PMU in /sys/bus/event_source/devices, so users can > > > select target PMU, and use filter to do further sets. > > > > > > Filtering options contains: > > > event - select the event. > > > subevent - select the subevent. > > > port - select target Root Ports. Information of Root Ports > > > are shown under sysfs. > > > bdf - select requester_id of target EP device. > > > trig_len - set trigger condition for starting event statistics. > > > trigger_mode - set trigger mode. 0 means starting to statistic when > > > bigger than trigger condition, and 1 means smaller. > > > thr_len - set threshold for statistics. > > > thr_mode - set threshold mode. 0 means count when bigger than > > > threshold, and 1 means smaller. > > > > > > Reviewed-by: John Garry > > > Signed-off-by: Qi Liu > > > --- > > > MAINTAINERS | 6 + > > > drivers/perf/Kconfig | 2 + > > > drivers/perf/Makefile | 1 + > > > drivers/perf/pci/Kconfig | 16 + > > > drivers/perf/pci/Makefile | 2 + > > > drivers/perf/pci/hisilicon/Makefile | 3 + > > > drivers/perf/pci/hisilicon/hisi_pcie_pmu.c | 1019 ++++++++++++++++++++++++++++ > > > > Can we keep this under drivers/perf/hisilicon/ please? I don't see the > > need to create a 'pci' directory here. > > https://lore.kernel.org/linux-pci/20190103154439.GC16311@edgewater-inn.cambridge.arm.com/ > > Discussion back in 2018 about where to put these... I don't remember that at all :) > Though, perf/pci/hisilicon does seem over the top in terms of depth, maybe perf/pci/ > or just give up on that plan and put them (for now at least) in per company directories. I think perf/hisilicon makes the most sense. We can always move it later if we need to. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel