From: Ioana Ciornei <ciorneiioana@gmail.com>
To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org
Cc: calvin.johnson@oss.nxp.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: [PATCH net-next] mdio: mdiobus: setup of_node for the MDIO device
Date: Tue, 15 Jun 2021 18:44:01 +0300 [thread overview]
Message-ID: <20210615154401.1274322-1-ciorneiioana@gmail.com> (raw)
From: Ioana Ciornei <ioana.ciornei@nxp.com>
By mistake, the of_node of the MDIO device was not setup in the patch
linked below. As a consequence, any PHY driver that depends on the
of_node in its probe callback was not be able to successfully finish its
probe on a PHY, thus the Generic PHY driver was used instead.
Fix this by actually setting up the of_node.
Fixes: bc1bee3b87ee ("net: mdiobus: Introduce fwnode_mdiobus_register_phy()")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
drivers/net/mdio/fwnode_mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
index e96766da8de4..283ddb1185bd 100644
--- a/drivers/net/mdio/fwnode_mdio.c
+++ b/drivers/net/mdio/fwnode_mdio.c
@@ -65,6 +65,7 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
* can be looked up later
*/
fwnode_handle_get(child);
+ phy->mdio.dev.of_node = to_of_node(child);
phy->mdio.dev.fwnode = child;
/* All data is now stored in the phy struct;
--
2.31.1
next reply other threads:[~2021-06-15 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 15:44 Ioana Ciornei [this message]
2021-06-15 16:19 ` [PATCH net-next] mdio: mdiobus: setup of_node for the MDIO device Andrew Lunn
2021-06-15 16:49 ` Ioana Ciornei
2021-06-15 17:13 ` Russell King (Oracle)
2021-06-15 17:24 ` Ioana Ciornei
2021-06-15 18:25 ` Russell King (Oracle)
2021-06-15 18:31 ` Andrew Lunn
2021-06-15 21:09 ` Russell King (Oracle)
2021-06-15 21:21 ` Ioana Ciornei
2021-06-15 21:31 ` Andrew Lunn
2021-06-16 8:20 ` Ioana Ciornei
2021-06-16 9:40 ` Russell King (Oracle)
2021-06-16 11:01 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615154401.1274322-1-ciorneiioana@gmail.com \
--to=ciorneiioana@gmail.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.