From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Subject: Re: [PATCH 0/4] nvme-fabrics: remove struct zeroout memset calls
Date: Tue, 15 Jun 2021 11:42:26 -0700 [thread overview]
Message-ID: <20210615184226.GC646237@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20210615024554.42585-1-chaitanya.kulkarni@wdc.com>
On Mon, Jun 14, 2021 at 07:45:50PM -0700, Chaitanya Kulkarni wrote:
> Hi,
>
> While reviewing the code I did removed the calls to zero out structures
> using memset() for the lio target, which are reviewed and accepted in
> the linux kernel tree. (see [1])
>
> This patch series is based on the same cleanup pattern for NVMe host.
> This will allow us to have uniform pattern in the future code review to
> avoid similar calls which seems unnecessary.
>
> If this is accepted I'll gradually convert the rest of the host code
> mainly core and pci.
This looks good, and aligns with the local style. For future cleanups, I
think it would be fine to do it a single patch instead of individual
patches per function.
Reviewed-by: Keith Busch <kbusch@kernel.org>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-15 21:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 2:45 [PATCH 0/4] nvme-fabrics: remove struct zeroout memset calls Chaitanya Kulkarni
2021-06-15 2:45 ` [PATCH 1/4] nvme-fabrics: remove memset in nvmf_reg_read64() Chaitanya Kulkarni
2021-06-15 2:45 ` [PATCH 2/4] nvme-fabrics: remove memset in nvmf_reg_write32() Chaitanya Kulkarni
2021-06-15 2:45 ` [PATCH 3/4] nvme-fabrics: remove memset in connect admin q Chaitanya Kulkarni
2021-06-15 2:45 ` [PATCH 4/4] nvme-fabrics: remove memset in connect io q Chaitanya Kulkarni
2021-06-15 16:19 ` [PATCH 0/4] nvme-fabrics: remove struct zeroout memset calls Christoph Hellwig
2021-06-15 18:42 ` Keith Busch [this message]
2021-06-15 20:07 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615184226.GC646237@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.