From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20365C48BE5 for ; Tue, 15 Jun 2021 23:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A2EB613B1 for ; Tue, 15 Jun 2021 23:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231614AbhFOXgf (ORCPT ); Tue, 15 Jun 2021 19:36:35 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:33029 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbhFOXge (ORCPT ); Tue, 15 Jun 2021 19:36:34 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4G4PmJ58Blz9sWQ; Wed, 16 Jun 2021 09:34:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1623800067; bh=lQtc2x7Rh4AHu/IUpmiEi/JQeUlvvr0kX8hNOKZGzYc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FN2JY0g7acv2zSNUbzouZpgO2F7oprdphW8MILnz3QnFeEUnB5J1fXA9MrJ2cvM46 +s1Dj6INl0KZ7gbSqwBFPZOtjEfeohrkQyrswTF2L4aAESGVQOPatezBCmLycAElui kPafKm4+f2sUPUqzDLAocB9ux5lsSNl4xw8+NOBzhy8TnZUSz+We8IQUj73MIp8vIU YyYRB8C8MhzXONoF5PEoXzicttkMCOb9jHYoSRUGwQ6QOp+PCIZH3An8DDQOupYjIo gMMbdko9ahb2yNCRk5p7kNACmHJXErg7izNajuDoE7bqp97IuygXZRUQtpyfvfNGiV nK0yMWo3g4+Ig== Date: Wed, 16 Jun 2021 09:34:22 +1000 From: Stephen Rothwell To: Mike Rapoport Cc: Qian Cai , Andrew Morton , Mark Rutland , Naresh Kamboju , Miles Chen , Linux-Next Mailing List , linux-mm , Linux ARM , open list , Will Deacon , lkft-triage@lists.linaro.org, regressions@lists.linux.dev, Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Christophe Leroy , Alistair Popple Subject: Re: [next] [arm64] kernel BUG at arch/arm64/mm/physaddr.c Message-ID: <20210616093422.31270f1e@canb.auug.org.au> In-Reply-To: References: <20210615124745.GA47121@C02TD0UTHF1T.local> <20210615131902.GB47121@C02TD0UTHF1T.local> <076665b9-9fb1-71da-5f7d-4d2c7f892103@quicinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/DtR4FonmnT/mKaEeFXLn3BZ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/DtR4FonmnT/mKaEeFXLn3BZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Tue, 15 Jun 2021 22:21:32 +0300 Mike Rapoport wrote: > > On Tue, Jun 15, 2021 at 10:50:31AM -0400, Qian Cai wrote: > >=20 > > On 6/15/2021 9:19 AM, Mark Rutland wrote: =20 > > > Looking some more, it looks like that's correct in isolation, but it > > > clashes with commit: > > >=20 > > > 5831eedad2ac6f38 ("mm: replace CONFIG_NEED_MULTIPLE_NODES with CONF= IG_NUMA") =20 > >=20 > > Just a data point. Reverting the commit alone fixed the same crash for = me. =20 >=20 > Yeah, that commit didn't take into the account the change in > pgdat_to_phys(). >=20 > The patch below should fix it. In the long run I think we should get rid = of > contig_page_data and allocate NODE_DATA(0) for !NUMA case as well. >=20 > Andrew, can you please add this as a fixup to "mm: replace > CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA"? >=20 >=20 > diff --git a/mm/sparse.c b/mm/sparse.c > index a0e9cdb5bc38..6326cdf36c4f 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -347,7 +347,7 @@ size_t mem_section_usage_size(void) > =20 > static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > { > -#ifndef CONFIG_NEED_MULTIPLE_NODES > +#ifndef CONFIG_NUMA > return __pa_symbol(pgdat); > #else > return __pa(pgdat); Added to linux-next today. --=20 Cheers, Stephen Rothwell --Sig_/DtR4FonmnT/mKaEeFXLn3BZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmDJOP4ACgkQAVBC80lX 0Gwvfwf/YixMUZJCuQBbmrJVUsBfG8dmEZFa/OYgYQX2Riv//8RQGxX25K7aD5nZ C35SPhEzfkH8aeB4Cgap679QDBB1Ds4IJ1V/nkiOLU4/qzEZXLKfd5PHEYt5CsIY x6WD4Qu/5o7BjaCqaQsyAXyzaM8kdysb3JXlUvPVcM5vusSbzERDFo7RoFXchody zRHaM88nA1oVuTGJdPlIuiSfeU278NOU8YKxhsbVYGt/OhPgJHNh/c2fh1HyXa+B ZaEcLS95uEHdflq4Uzkb9D3+X9hWpCbjc4UyME1LuvRkHR44vCOy6WGjQ4M7R3w7 D0DqEO6s+/otsRuqov3u4LupNJTOUg== =K0mT -----END PGP SIGNATURE----- --Sig_/DtR4FonmnT/mKaEeFXLn3BZ-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3835BC48BDF for ; Tue, 15 Jun 2021 23:51:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDED86023C for ; Tue, 15 Jun 2021 23:51:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDED86023C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xji78YhMUD8Ls1KOOnpnH7FYnRC3JgpMhLLmKsBCG1A=; b=RYSwzY7+60VsTxrARiqODWLqDx I1psL730gTRs5iTO/yPpaIlvzt1tPSHmdNJwFto4aIodlwpXqGfKi6uCW6PKxiOrzKm/CcTtdvn01 yrUhLIj/Ob6GtQQejRh80bi0J/rTxW2Qp0uUjG+WL88Yk9Ppv4ty+3S89pQBMyCrsYtgEvNoeYmmn IzEEJMrVfKxodx3DZWXz/Udd+ceCpAx5LjS2/aajKqqUhZvVOfHFIOeyp+eX824361v2VtlC0TAQo 7czF5mKOAqGQ+MSpA2pTCL5qMHjJF7KZny4kEpTU5+fzRhe2YN1XvpTrwC+Uru3gWWsUY3mOCeWl9 4Sq1vFbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltInh-003yKB-0W; Tue, 15 Jun 2021 23:48:57 +0000 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2] helo=ozlabs.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltIZv-003tlV-Ky for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 23:34:45 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4G4PmJ58Blz9sWQ; Wed, 16 Jun 2021 09:34:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1623800067; bh=lQtc2x7Rh4AHu/IUpmiEi/JQeUlvvr0kX8hNOKZGzYc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FN2JY0g7acv2zSNUbzouZpgO2F7oprdphW8MILnz3QnFeEUnB5J1fXA9MrJ2cvM46 +s1Dj6INl0KZ7gbSqwBFPZOtjEfeohrkQyrswTF2L4aAESGVQOPatezBCmLycAElui kPafKm4+f2sUPUqzDLAocB9ux5lsSNl4xw8+NOBzhy8TnZUSz+We8IQUj73MIp8vIU YyYRB8C8MhzXONoF5PEoXzicttkMCOb9jHYoSRUGwQ6QOp+PCIZH3An8DDQOupYjIo gMMbdko9ahb2yNCRk5p7kNACmHJXErg7izNajuDoE7bqp97IuygXZRUQtpyfvfNGiV nK0yMWo3g4+Ig== Date: Wed, 16 Jun 2021 09:34:22 +1000 From: Stephen Rothwell To: Mike Rapoport Cc: Qian Cai , Andrew Morton , Mark Rutland , Naresh Kamboju , Miles Chen , Linux-Next Mailing List , linux-mm , Linux ARM , open list , Will Deacon , lkft-triage@lists.linaro.org, regressions@lists.linux.dev, Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Christophe Leroy , Alistair Popple Subject: Re: [next] [arm64] kernel BUG at arch/arm64/mm/physaddr.c Message-ID: <20210616093422.31270f1e@canb.auug.org.au> In-Reply-To: References: <20210615124745.GA47121@C02TD0UTHF1T.local> <20210615131902.GB47121@C02TD0UTHF1T.local> <076665b9-9fb1-71da-5f7d-4d2c7f892103@quicinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_163443_971499_30C32FDD X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0035599619886090626==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0035599619886090626== Content-Type: multipart/signed; boundary="Sig_/DtR4FonmnT/mKaEeFXLn3BZ"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/DtR4FonmnT/mKaEeFXLn3BZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Tue, 15 Jun 2021 22:21:32 +0300 Mike Rapoport wrote: > > On Tue, Jun 15, 2021 at 10:50:31AM -0400, Qian Cai wrote: > >=20 > > On 6/15/2021 9:19 AM, Mark Rutland wrote: =20 > > > Looking some more, it looks like that's correct in isolation, but it > > > clashes with commit: > > >=20 > > > 5831eedad2ac6f38 ("mm: replace CONFIG_NEED_MULTIPLE_NODES with CONF= IG_NUMA") =20 > >=20 > > Just a data point. Reverting the commit alone fixed the same crash for = me. =20 >=20 > Yeah, that commit didn't take into the account the change in > pgdat_to_phys(). >=20 > The patch below should fix it. In the long run I think we should get rid = of > contig_page_data and allocate NODE_DATA(0) for !NUMA case as well. >=20 > Andrew, can you please add this as a fixup to "mm: replace > CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA"? >=20 >=20 > diff --git a/mm/sparse.c b/mm/sparse.c > index a0e9cdb5bc38..6326cdf36c4f 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -347,7 +347,7 @@ size_t mem_section_usage_size(void) > =20 > static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > { > -#ifndef CONFIG_NEED_MULTIPLE_NODES > +#ifndef CONFIG_NUMA > return __pa_symbol(pgdat); > #else > return __pa(pgdat); Added to linux-next today. --=20 Cheers, Stephen Rothwell --Sig_/DtR4FonmnT/mKaEeFXLn3BZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmDJOP4ACgkQAVBC80lX 0Gwvfwf/YixMUZJCuQBbmrJVUsBfG8dmEZFa/OYgYQX2Riv//8RQGxX25K7aD5nZ C35SPhEzfkH8aeB4Cgap679QDBB1Ds4IJ1V/nkiOLU4/qzEZXLKfd5PHEYt5CsIY x6WD4Qu/5o7BjaCqaQsyAXyzaM8kdysb3JXlUvPVcM5vusSbzERDFo7RoFXchody zRHaM88nA1oVuTGJdPlIuiSfeU278NOU8YKxhsbVYGt/OhPgJHNh/c2fh1HyXa+B ZaEcLS95uEHdflq4Uzkb9D3+X9hWpCbjc4UyME1LuvRkHR44vCOy6WGjQ4M7R3w7 D0DqEO6s+/otsRuqov3u4LupNJTOUg== =K0mT -----END PGP SIGNATURE----- --Sig_/DtR4FonmnT/mKaEeFXLn3BZ-- --===============0035599619886090626== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0035599619886090626==--