From: liuhailong <liuhailong@oppo.com>
To: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, christian@brauner.io,
hridya@google.com, surenb@google.com
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
liuhailong <liuhailong@oppo.com>
Subject: [PATCH] staging: android: ashmem: add size field in procfs fdinfo
Date: Fri, 18 Jun 2021 17:50:35 +0800 [thread overview]
Message-ID: <20210618095035.32410-1-liuhailong@oppo.com> (raw)
add this information to help user to find ashmem problem.
ashmem leak scenario:
-000|fd = ashmem_create_region
-001|mmap and pagefault
-002|munmap
-003|forget close(fd) <---- which lead to ashmem leak
Signed-off-by: liuhailong <liuhailong@oppo.com>
---
drivers/staging/android/ashmem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..ee2fd75111d8 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -894,6 +894,8 @@ static void ashmem_show_fdinfo(struct seq_file *m, struct file *file)
seq_printf(m, "name:\t%s\n",
asma->name + ASHMEM_NAME_PREFIX_LEN);
+ seq_printf(m, "size:\t%zu\n", asma->size);
+
mutex_unlock(&ashmem_mutex);
}
#endif
--
2.30.2
next reply other threads:[~2021-06-18 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 9:50 liuhailong [this message]
2021-06-18 10:23 ` [PATCH] staging: android: ashmem: add size field in procfs fdinfo Greg KH
2021-06-18 10:40 ` 回复: " 刘海龙(DuckBuBee)
2021-06-18 11:04 ` Greg KH
2021-06-18 11:04 ` 刘海龙(DuckBuBee)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618095035.32410-1-liuhailong@oppo.com \
--to=liuhailong@oppo.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.