From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A69C48BDF for ; Thu, 24 Jun 2021 05:30:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1DA3613E1 for ; Thu, 24 Jun 2021 05:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbhFXFdM (ORCPT ); Thu, 24 Jun 2021 01:33:12 -0400 Received: from verein.lst.de ([213.95.11.211]:53053 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230093AbhFXFdM (ORCPT ); Thu, 24 Jun 2021 01:33:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 244BF68AFE; Thu, 24 Jun 2021 07:30:49 +0200 (CEST) Date: Thu, 24 Jun 2021 07:30:48 +0200 From: Christoph Hellwig To: Felix Kuehling Cc: Theodore Ts'o , Alex Sierra , akpm@linux-foundation.org, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v3 0/8] Support DEVICE_GENERIC memory in migrate_vma_* Message-ID: <20210624053048.GB25004@lst.de> References: <20210617151705.15367-1-alex.sierra@amd.com> <905418d1-9099-0ea8-a6e6-84cc8ef3d0b0@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <905418d1-9099-0ea8-a6e6-84cc8ef3d0b0@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jun 23, 2021 at 05:49:55PM -0400, Felix Kuehling wrote: > For the reference counting changes we could use the dax driver with hmem > and use efi_fake_mem on the kernel command line to create some > DEVICE_GENERIC pages. I'm open to suggestions for good user mode tests to > exercise dax functionality on this type of memory. > > For the migration helper changes we could modify or parametrize > lib/hmm_test.c to create DEVICE_GENERIC pages instead of DEVICE_PRIVATE. > Then run tools/testing/selftests/vm/hmm-tests.c. We'll also need a real in-tree user of the enhanced DEVICE_GENERIC memory. So while the refcounting cleanups early in the series are something I'd really like to see upstream as soon as everything is sorted out, the actual bits that can't only be used by your updated driver should wait for that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CEE0C49EAF for ; Thu, 24 Jun 2021 07:06:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E583613D3 for ; Thu, 24 Jun 2021 07:06:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E583613D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6596B6EA1E; Thu, 24 Jun 2021 07:06:19 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 844806E9E3; Thu, 24 Jun 2021 05:30:53 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 244BF68AFE; Thu, 24 Jun 2021 07:30:49 +0200 (CEST) Date: Thu, 24 Jun 2021 07:30:48 +0200 From: Christoph Hellwig To: Felix Kuehling Subject: Re: [PATCH v3 0/8] Support DEVICE_GENERIC memory in migrate_vma_* Message-ID: <20210624053048.GB25004@lst.de> References: <20210617151705.15367-1-alex.sierra@amd.com> <905418d1-9099-0ea8-a6e6-84cc8ef3d0b0@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <905418d1-9099-0ea8-a6e6-84cc8ef3d0b0@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Thu, 24 Jun 2021 07:06:12 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Sierra , rcampbell@nvidia.com, Theodore Ts'o , amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com, dri-devel@lists.freedesktop.org, jgg@nvidia.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Jun 23, 2021 at 05:49:55PM -0400, Felix Kuehling wrote: > For the reference counting changes we could use the dax driver with hmem > and use efi_fake_mem on the kernel command line to create some > DEVICE_GENERIC pages. I'm open to suggestions for good user mode tests to > exercise dax functionality on this type of memory. > > For the migration helper changes we could modify or parametrize > lib/hmm_test.c to create DEVICE_GENERIC pages instead of DEVICE_PRIVATE. > Then run tools/testing/selftests/vm/hmm-tests.c. We'll also need a real in-tree user of the enhanced DEVICE_GENERIC memory. So while the refcounting cleanups early in the series are something I'd really like to see upstream as soon as everything is sorted out, the actual bits that can't only be used by your updated driver should wait for that. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx