From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v6 3/3] ima-evm-utils: Read keyid from the cert appended to the key file
Date: Wed, 30 Jun 2021 22:10:55 +0300 [thread overview]
Message-ID: <20210630191055.xpjsooduv7dfo6vc@altlinux.org> (raw)
In-Reply-To: <9e3eff6a1aecbf609bf3759addf32848177a08d9.camel@linux.ibm.com>
Mimi,
On Wed, Jun 30, 2021 at 01:38:02PM -0400, Mimi Zohar wrote:
> On Tue, 2021-05-11 at 14:56 +0300, Vitaly Chikunov wrote:
> >
> > diff --git a/src/libimaevm.c b/src/libimaevm.c
> > index 1c03768..bfce7ef 100644
> > --- a/src/libimaevm.c
> > +++ b/src/libimaevm.c
> > @@ -1021,10 +1021,12 @@ static int sign_hash_v2(const char *algo, const unsigned char *hash,
> > return -1;
> > }
> >
> > - if (imaevm_params.keyid)
> > + if (imaevm_params.keyid) {
> > hdr->keyid = htonl(imaevm_params.keyid);
> > - else
> > - calc_keyid_v2(&hdr->keyid, name, pkey);
> > + } else {
> > + if (__read_keyid(&hdr->keyid, keyfile, KEYID_FILE_PEM_KEY))
> > + calc_keyid_v2(&hdr->keyid, name, pkey);
> > + }
>
> If the call to __read_keyid() was independent of the test and call to
> calc_keyid_v2(), it would make reading code the easier to understand.
>
> result = __read_keyid(...);
> if (result < 0)
> calc_keyid_v2(...);
No problem to add additional variable and check __read_keyid indirectly.
But, how is this independent? Call to calc_keyid_v2 is dependent to
__read_keyid result.
Thanks,
>
> thanks,
>
> Mimi
>
> >
> > st = "EVP_PKEY_CTX_new";
> > if (!(ctx = EVP_PKEY_CTX_new(pkey, NULL)))
>
next prev parent reply other threads:[~2021-06-30 19:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 11:56 [PATCH v6 0/3] ima-evm-utils: Add --keyid option Vitaly Chikunov
2021-05-11 11:56 ` [PATCH v6 1/3] ima-evm-utils: Allow manual setting keyid for signing Vitaly Chikunov
2021-06-25 12:21 ` Mimi Zohar
2021-06-26 0:42 ` Vitaly Chikunov
2021-06-28 20:50 ` Mimi Zohar
2021-06-29 1:32 ` Vitaly Chikunov
2021-06-30 16:39 ` Mimi Zohar
2021-06-30 19:44 ` Vitaly Chikunov
2021-06-30 20:47 ` Mimi Zohar
2021-06-30 21:10 ` Vitaly Chikunov
2021-06-30 21:32 ` Mimi Zohar
2021-05-11 11:56 ` [PATCH v6 2/3] ima-evm-utils: Allow manual setting keyid from a cert file Vitaly Chikunov
2021-06-25 12:22 ` Mimi Zohar
2021-06-26 0:27 ` Vitaly Chikunov
2021-06-30 16:39 ` Mimi Zohar
2021-05-11 11:56 ` [PATCH v6 3/3] ima-evm-utils: Read keyid from the cert appended to the key file Vitaly Chikunov
2021-06-25 12:22 ` Mimi Zohar
2021-06-26 0:21 ` Vitaly Chikunov
2021-06-30 17:38 ` Mimi Zohar
2021-06-30 19:10 ` Vitaly Chikunov [this message]
2021-06-30 19:26 ` Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630191055.xpjsooduv7dfo6vc@altlinux.org \
--to=vt@altlinux.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.