From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFA3C11F65 for ; Wed, 30 Jun 2021 21:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0503A61425 for ; Wed, 30 Jun 2021 21:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235441AbhF3VNe (ORCPT ); Wed, 30 Jun 2021 17:13:34 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:51124 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235414AbhF3VNU (ORCPT ); Wed, 30 Jun 2021 17:13:20 -0400 Received: from imap.altlinux.org (imap.altlinux.org [194.107.17.38]) by vmicros1.altlinux.org (Postfix) with ESMTP id 0EDDC72C8B4; Thu, 1 Jul 2021 00:10:49 +0300 (MSK) Received: from altlinux.org (sole.flsd.net [185.75.180.6]) by imap.altlinux.org (Postfix) with ESMTPSA id C65814A46ED; Thu, 1 Jul 2021 00:10:48 +0300 (MSK) Date: Thu, 1 Jul 2021 00:10:48 +0300 From: Vitaly Chikunov To: Mimi Zohar Cc: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org, "Dmitry V. Levin" Subject: Re: [PATCH v6 1/3] ima-evm-utils: Allow manual setting keyid for signing Message-ID: <20210630211048.yx5vwneymszr5ssj@altlinux.org> References: <20210511115630.795208-1-vt@altlinux.org> <20210511115630.795208-2-vt@altlinux.org> <004b55594ab1d944e42dd7fd0d87df47b3c09114.camel@linux.ibm.com> <20210626004241.wkkjsbbesakszfkj@altlinux.org> <20210629013201.xelhje2hmiuqybrt@altlinux.org> <2f494e1d5c2c99a4b7c0912faa4c3be3de682afc.camel@linux.ibm.com> <20210630194451.laico5ziqy3fw4eh@altlinux.org> <3aa852febc49d159783597b0de56060cf5efb269.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <3aa852febc49d159783597b0de56060cf5efb269.camel@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Mimi, On Wed, Jun 30, 2021 at 04:47:53PM -0400, Mimi Zohar wrote: > On Wed, 2021-06-30 at 22:44 +0300, Vitaly Chikunov wrote: > > On Wed, Jun 30, 2021 at 12:39:02PM -0400, Mimi Zohar wrote: > > > On Tue, 2021-06-29 at 04:32 +0300, Vitaly Chikunov wrote: > > > > On Mon, Jun 28, 2021 at 04:50:42PM -0400, Mimi Zohar wrote: > > > > > > > > > > Thank you for the detailed explanation. > > > > > > > > > > On Sat, 2021-06-26 at 03:42 +0300, Vitaly Chikunov wrote: > > > > > > > > > > > > Requiring the optarg value to be prefixed with "0x" would > > > > > > > simplify the strlen test. > > > > > > > (The subsequent patch wouldn't need a contrived prefix.) > > > > > > > > > > > > (I do not understand this remark at the moment.) > > > > > > > > > > > > Base 16 will let user pass keyid just as a string, copy-pasting from > > > > > > somewhere else. > > > > > > > > > > strtoul() supports prefixing the ascii-hex string with "0x". To > > > > > differentiate between a keyid and pathname, why not require the keyid > > > > > be prefixed with "0x", as opposed to requiring the pathname to be > > > > > prefixed with '@', like "--keyid @/path/to/cert.pem". > > > > > > > > I wanted to avoid (filename vs keyid) ambiguity of the argument to > > > > `--keyid' - if user have file named "0x00112233" they would have hard > > > > time passing it to `--keyid'. But, it's impossible to have keyid string > > > > starting with "@". So, "@" perfectly distinguish type of `--keyid' > > > > argument but "0x" isn't. > > > > > > > > Also, in some software (zip, rar) "@" is common prefix meaning value > > > > should be taken from the specified file. But, yes, "@" is not common > > > > in Unix environments. Do you want me to create separate option like > > > > `--keyid-from-file'? > > > > > > It's highly unlikely that both the filename and pathname would be > > > prefixed with "0x". Defining a new option might be a good idea. > > > Possibly naming it --extract-cert-keyid, ---cert-keyid, or --keyid- > > > from-cert. > > > > It's not unlikely, because people may want to keep cert files named or > > symlinked by keyid. (For example, local cert database keep cert files > > symlinked like `f30dd6ad.0'.) > > > > I will add an option, most understandable, perhaps, is `--keyid-from-cert'. > > > > Also, I will remove base 16 from --keyid argument. > > I must be missing something. "openssl x509", "keyctl show > %keyring:", and "getfattr -m security.ima -e hex --dump" > all display the skid in hex. Why would anyone provide the skid as > something other than in hex? Ah, I thought you want '0x' prefix mandatory. Will not remove base 16 then. Also, /proc/keys shows keyid without '0x' prefix. Thanks, > > thanks, > > Mimi >