From: Xu Yilun <yilun.xu@intel.com>
To: Tom Rix <trix@redhat.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, "Wu Hao" <hao.wu@intel.com>,
"Moritz Fischer" <mdf@kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH] bus: Make remove callback return void
Date: Thu, 8 Jul 2021 10:19:13 +0800 [thread overview]
Message-ID: <20210708021913.GB12358@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <4c7210e4-76e4-07fe-a40c-a58e331d0a6e@redhat.com>
On Tue, Jul 06, 2021 at 06:52:09AM -0700, Tom Rix wrote:
>
> On 7/6/21 2:50 AM, Uwe Kleine-König wrote:
> > The driver core ignores the return value of this callback because there
> > is only little it can do when a device disappears.
> >
> > This is the final bit of a long lasting cleanup quest where several
> > buses were converted to also return void from their remove callback.
> > Additionally some resource leaks were fixed that were caused by drivers
> > returning an error code in the expectation that the driver won't go
> > away.
> >
> > With struct bus_type::remove returning void it's prevented that newly
> > implemented buses return an ignored error code and so don't anticipate
> > wrong expectations for driver authors.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> >
> > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
> > return void" that is not yet applied, see
> > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutronix.de.
> >
> > I tested it using allmodconfig on amd64 and arm, but I wouldn't be
> > surprised if I still missed to convert a driver. So it would be great to
> > get this into next early after the merge window closes.
> >
> > I send this mail to all people that get_maintainer.pl emits for this
> > patch. I wonder how many recipents will refuse this mail because of the
> > long Cc: list :-)
> >
> > Best regards
> > Uwe
>
> > drivers/fpga/dfl.c | 4 +---
> Reviewed-by: Tom Rix <trix@redhat.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
next prev parent reply other threads:[~2021-07-08 2:24 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:50 [PATCH] bus: Make remove callback return void Uwe Kleine-König
2021-07-06 9:50 ` Uwe Kleine-König
2021-07-06 9:50 ` Uwe Kleine-König
2021-07-06 9:50 ` Uwe Kleine-König
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:24 ` Chen-Yu Tsai
2021-07-06 10:24 ` Chen-Yu Tsai
2021-07-06 10:24 ` Chen-Yu Tsai
2021-07-06 10:24 ` Chen-Yu Tsai
2021-07-06 10:25 ` Pali Rohár
2021-07-06 10:25 ` Pali Rohár
2021-07-06 10:25 ` Pali Rohár
2021-07-06 10:25 ` Pali Rohár
2021-07-06 10:26 ` Mauro Carvalho Chehab
2021-07-06 10:26 ` Mauro Carvalho Chehab
2021-07-06 10:26 ` Mauro Carvalho Chehab
2021-07-06 10:26 ` Mauro Carvalho Chehab
2021-07-06 10:28 ` Hans de Goede
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:47 ` Johannes Thumshirn
2021-07-06 10:47 ` Johannes Thumshirn
2021-07-06 10:47 ` Johannes Thumshirn
2021-07-06 10:47 ` Johannes Thumshirn
2021-07-06 10:47 ` Johannes Thumshirn
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:46 ` Juergen Gross
2021-07-06 10:46 ` Juergen Gross
2021-07-06 10:46 ` Juergen Gross
2021-07-06 10:46 ` Juergen Gross
2021-07-06 10:46 ` Juergen Gross via Virtualization
2021-07-06 10:49 ` Johan Hovold
2021-07-06 10:49 ` Johan Hovold
2021-07-06 10:49 ` Johan Hovold
2021-07-06 10:49 ` Johan Hovold
2021-07-06 10:56 ` Srinivas Kandagatla
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 11:17 ` Cornelia Huck
2021-07-06 11:17 ` Cornelia Huck
2021-07-06 11:17 ` Cornelia Huck
2021-07-06 11:17 ` Cornelia Huck
2021-07-06 11:17 ` Cornelia Huck
2021-07-06 12:14 ` Uwe Kleine-König
2021-07-06 12:14 ` Uwe Kleine-König
2021-07-06 12:14 ` Uwe Kleine-König
2021-07-06 12:14 ` Uwe Kleine-König
2021-07-06 11:16 ` Kirti Wankhede
2021-07-06 11:16 ` Kirti Wankhede
2021-07-06 11:16 ` Kirti Wankhede
2021-07-06 11:16 ` Kirti Wankhede
2021-07-06 11:41 ` Heikki Krogerus
2021-07-06 11:41 ` Heikki Krogerus
2021-07-06 11:41 ` Heikki Krogerus
2021-07-06 12:50 ` Samuel Iglesias Gonsálvez
2021-07-06 11:42 ` Maximilian Luz
2021-07-06 11:42 ` Maximilian Luz
2021-07-06 11:42 ` Maximilian Luz
2021-07-06 13:52 ` Tom Rix
2021-07-08 2:19 ` Xu Yilun [this message]
2021-07-08 5:32 ` Uwe Kleine-König
2021-07-06 14:51 ` Geoff Levand
2021-07-06 14:51 ` Geoff Levand
2021-07-06 14:51 ` Geoff Levand
2021-07-06 14:51 ` Geoff Levand
2021-07-06 15:06 ` Yehezkel Bernat
2021-07-06 15:06 ` Yehezkel Bernat
2021-07-06 15:06 ` Yehezkel Bernat
2021-07-06 15:06 ` Yehezkel Bernat
2021-07-06 15:11 ` Mathieu Poirier
2021-07-06 15:11 ` Mathieu Poirier
2021-07-06 15:11 ` Mathieu Poirier
2021-07-06 15:11 ` Mathieu Poirier
2021-07-06 15:11 ` Alexander Shishkin
2021-07-06 15:11 ` Alexander Shishkin
2021-07-06 15:11 ` Alexander Shishkin
2021-07-06 15:11 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708021913.GB12358@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.