From: Gerd Hoffmann <kraxel@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: pbonzini@redhat.com, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
"Jose R. Ziviani" <jziviani@suse.de>
Subject: Re: [PATCH v2 1/1] modules: Improve error message when module is not found
Date: Fri, 23 Jul 2021 11:52:31 +0200 [thread overview]
Message-ID: <20210723095231.sfbkhdwdg43nedkk@sirius.home.kraxel.org> (raw)
In-Reply-To: <c26fc6f4-341f-c66f-5384-c811e1342891@suse.de>
> > - g_assert(ops != NULL);
> > + if (ops == NULL) {
> > + exit(1);
> > + }
> > +
>
>
> Ah, again, why?
> This change looks wrong to me,
>
> the ops code should be present when ops interfaces are initialized:
> it should be a code level assertion, as it has to do with the proper order of initializations in QEMU,
>
> why would we want to do anything else but to assert here?
>
> Am I blind to something obvious?
Building tcg accel ops modular moves that from coding error to possible
user error (user wants use tcg but has qemu-accel-tcg-$arch.rpm not
installed).
The second part of the patch makes qemu print a message on the failed
module load, so the user would have a chance to figure where the assert
comes from, but replacing the assert with a more friendly message still
makes sense to me.
take care,
Gerd
next prev parent reply other threads:[~2021-07-23 9:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 22:09 [PATCH v2 0/1] Improve module accelerator error message Jose R. Ziviani
2021-07-22 22:09 ` [PATCH v2 1/1] modules: Improve error message when module is not found Jose R. Ziviani
2021-07-23 6:25 ` Gerd Hoffmann
2021-07-23 8:04 ` Claudio Fontana
2021-07-23 8:28 ` Markus Armbruster
2021-07-23 8:32 ` Claudio Fontana
2021-07-23 9:41 ` Claudio Fontana
2021-07-23 9:52 ` Gerd Hoffmann [this message]
2021-07-23 11:20 ` Claudio Fontana
2021-07-23 12:20 ` Claudio Fontana
2021-07-23 12:48 ` Gerd Hoffmann
2021-07-29 9:14 ` modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found Gerd Hoffmann
2021-07-29 9:40 ` modular tcg Claudio Fontana
2021-07-29 10:26 ` Gerd Hoffmann
2021-07-29 10:42 ` Claudio Fontana
2021-07-29 9:42 ` Claudio Fontana
2021-07-29 10:29 ` Gerd Hoffmann
2021-07-29 10:44 ` Claudio Fontana
2021-07-29 11:34 ` Philippe Mathieu-Daudé
2021-07-29 11:39 ` Claudio Fontana
2021-07-29 14:22 ` Claudio Fontana
2021-07-29 14:59 ` Philippe Mathieu-Daudé
2021-07-29 16:35 ` Claudio Fontana
2021-07-29 16:40 ` modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found Paolo Bonzini
2021-07-30 9:05 ` modular tcg Gerd Hoffmann
2021-07-30 10:02 ` Claudio Fontana
2022-09-02 9:50 ` modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found Claudio Fontana
2021-07-23 13:50 ` [PATCH v2 1/1] modules: Improve error message when module is not found Jose R. Ziviani
2021-07-23 14:02 ` Claudio Fontana
2021-07-23 14:14 ` Philippe Mathieu-Daudé
2021-07-23 14:36 ` Jose R. Ziviani
2021-07-23 15:27 ` Claudio Fontana
2021-07-23 15:46 ` Jose R. Ziviani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723095231.sfbkhdwdg43nedkk@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=jziviani@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.