All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2367:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
@ 2021-07-25  9:59 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-25  9:59 UTC (permalink / raw
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4510 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Naveen Mamindlapalli <naveenm@marvell.com>
CC: Sunil Kovvuri Goutham <Sunil.Goutham@marvell.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d8079fac168168b25677dc16c00ffaf9fb7df723
commit: 967db3529ecac305d230aa4e60abddf6ab63543a octeontx2-af: add support for multicast/promisc packet replication feature
date:   6 weeks ago
:::::: branch date: 10 hours ago
:::::: commit date: 6 weeks ago
compiler: s390-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2367:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
     *mce_list = &pfvf->bcast_mce_list;
     ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2370:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
     *mce_list = &pfvf->mcast_mce_list;
     ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2373:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
     *mce_list = &pfvf->promisc_mce_list;
     ^
>> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:700:6: warning: Uninitialized struct member: action.op [uninitStructMember]
    if (action.op != NIX_RX_ACTIONOP_RSS) {
        ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:865:6: warning: Uninitialized struct member: action.op [uninitStructMember]
    if (action.op != NIX_RX_ACTIONOP_RSS) {
        ^

vim +2367 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c

4b05528ebf0c3f Sunil Goutham        2018-10-22  2349  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2350  void nix_get_mce_list(struct rvu *rvu, u16 pcifunc, int type,
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2351  		      struct nix_mce_list **mce_list, int *mce_idx)
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2352  {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2353  	struct rvu_hwinfo *hw = rvu->hw;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2354  	struct rvu_pfvf *pfvf;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2355  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2356  	if (!hw->cap.nix_rx_multicast ||
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2357  	    !is_pf_cgxmapped(rvu, rvu_get_pf(pcifunc & ~RVU_PFVF_FUNC_MASK))) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2358  		*mce_list = NULL;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2359  		*mce_idx = 0;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2360  		return;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2361  	}
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2362  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2363  	/* Get this PF/VF func's MCE index */
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2364  	pfvf = rvu_get_pfvf(rvu, pcifunc & ~RVU_PFVF_FUNC_MASK);
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2365  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2366  	if (type == NIXLF_BCAST_ENTRY) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11 @2367  		*mce_list = &pfvf->bcast_mce_list;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2368  		*mce_idx = pfvf->bcast_mce_idx;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2369  	} else if (type == NIXLF_ALLMULTI_ENTRY) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2370  		*mce_list = &pfvf->mcast_mce_list;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2371  		*mce_idx = pfvf->mcast_mce_idx;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2372  	} else if (type == NIXLF_PROMISC_ENTRY) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2373  		*mce_list = &pfvf->promisc_mce_list;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2374  		*mce_idx = pfvf->promisc_mce_idx;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2375  	}  else {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2376  		*mce_list = NULL;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2377  		*mce_idx = 0;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2378  	}
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2379  }
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2380  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2367:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
@ 2021-07-27 19:48 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-27 19:48 UTC (permalink / raw
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4508 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Naveen Mamindlapalli <naveenm@marvell.com>
CC: Sunil Kovvuri Goutham <Sunil.Goutham@marvell.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ff1176468d368232b684f75e82563369208bc371
commit: 967db3529ecac305d230aa4e60abddf6ab63543a octeontx2-af: add support for multicast/promisc packet replication feature
date:   7 weeks ago
:::::: branch date: 2 days ago
:::::: commit date: 7 weeks ago
compiler: s390-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2367:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
     *mce_list = &pfvf->bcast_mce_list;
     ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2370:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
     *mce_list = &pfvf->mcast_mce_list;
     ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2373:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables]
     *mce_list = &pfvf->promisc_mce_list;
     ^
>> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:700:6: warning: Uninitialized struct member: action.op [uninitStructMember]
    if (action.op != NIX_RX_ACTIONOP_RSS) {
        ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:865:6: warning: Uninitialized struct member: action.op [uninitStructMember]
    if (action.op != NIX_RX_ACTIONOP_RSS) {
        ^

vim +2367 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c

4b05528ebf0c3f Sunil Goutham        2018-10-22  2349  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2350  void nix_get_mce_list(struct rvu *rvu, u16 pcifunc, int type,
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2351  		      struct nix_mce_list **mce_list, int *mce_idx)
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2352  {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2353  	struct rvu_hwinfo *hw = rvu->hw;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2354  	struct rvu_pfvf *pfvf;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2355  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2356  	if (!hw->cap.nix_rx_multicast ||
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2357  	    !is_pf_cgxmapped(rvu, rvu_get_pf(pcifunc & ~RVU_PFVF_FUNC_MASK))) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2358  		*mce_list = NULL;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2359  		*mce_idx = 0;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2360  		return;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2361  	}
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2362  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2363  	/* Get this PF/VF func's MCE index */
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2364  	pfvf = rvu_get_pfvf(rvu, pcifunc & ~RVU_PFVF_FUNC_MASK);
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2365  
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2366  	if (type == NIXLF_BCAST_ENTRY) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11 @2367  		*mce_list = &pfvf->bcast_mce_list;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2368  		*mce_idx = pfvf->bcast_mce_idx;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2369  	} else if (type == NIXLF_ALLMULTI_ENTRY) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2370  		*mce_list = &pfvf->mcast_mce_list;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2371  		*mce_idx = pfvf->mcast_mce_idx;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2372  	} else if (type == NIXLF_PROMISC_ENTRY) {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2373  		*mce_list = &pfvf->promisc_mce_list;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2374  		*mce_idx = pfvf->promisc_mce_idx;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2375  	}  else {
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2376  		*mce_list = NULL;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2377  		*mce_idx = 0;
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2378  	}
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2379  }
967db3529ecac3 Naveen Mamindlapalli 2021-06-11  2380  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-27 19:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-25  9:59 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c:2367:3: warning: Address of local auto-variable assigned to a function parameter. [autoVariables] kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-07-27 19:48 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.