From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AA7C4338F for ; Mon, 26 Jul 2021 22:07:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C690760F6E for ; Mon, 26 Jul 2021 22:07:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C690760F6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 48467833DC; Tue, 27 Jul 2021 00:07:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="oTYz8z3Z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4EFD4833E2; Tue, 27 Jul 2021 00:07:43 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C33C2833DA for ; Tue, 27 Jul 2021 00:07:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id x3so10444137qkl.6 for ; Mon, 26 Jul 2021 15:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aFZjpm+HZ0dvSigohUZdBXzKSpE+FNOghYH0KFMCuEA=; b=oTYz8z3ZOMvNNk8rwZtFR8Wz63GB0EYfAa+aoHmkn1IjUORFVHhJGyAmdjv1oBWx4n 4M3xTV0vAqIWLBOHt+1xoUiChUgbvkVb69/M3PyvBnSIRrDyLqQoch5TozErqsZRZJx5 r4eDEu2QhnUDIu5jw/b4/GrMBgk4qnWMEa8Us= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aFZjpm+HZ0dvSigohUZdBXzKSpE+FNOghYH0KFMCuEA=; b=rHFVQ6RFqtqsXrG9MmF0MFapdWnYRjdA6BmCa/Gf5/LRpf8RkSOQ4gpng+8m3oHXNA hKbTMEiQUeMuN4LQ8omVZH4GAbRQuEiPQsXVIyue2PkjlR3eL5WNsheai6t2i0v9P09C jgFfYhdJpIHHVucYJ2ioyrREVS/Li3jwFaIDOWDDear+28qEtfQT+3aOxdPWtkPBeCia ZDXac7wP14xggR+NVIKsE9FEMoQNNHRmbHjjLp1bUi16vyqaJTNqNvAuPEjuOz9WKqPZ GTwuZXHHUbgBFzXDIeVxmLlUxs6W40bVIwlOovhG2olo3a1mCUYNGxIcbv4QtUKOgfdh l+LA== X-Gm-Message-State: AOAM5331gGiZcVGKFRl75ETcHT7tf4iuL5HTmAOJ7/I9K20/gYLTzIyc 5+iGwtjh2B15MBt7p/qLaQC2tw== X-Google-Smtp-Source: ABdhPJxXM+iuh7cU5b9PBBc4BLJ+D0d2mfRv16OzwiRvaJGR2tWjzGu1+eO5/DdsljK33Ujmtw0Ajg== X-Received: by 2002:a37:9244:: with SMTP id u65mr19389236qkd.46.1627337258525; Mon, 26 Jul 2021 15:07:38 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f53f-8332-072c-4f35.res6.spectrum.com. [2603:6081:7b01:cbda:f53f:8332:72c:4f35]) by smtp.gmail.com with ESMTPSA id x7sm695591qki.102.2021.07.26.15.07.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jul 2021 15:07:37 -0700 (PDT) Date: Mon, 26 Jul 2021 18:07:35 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Ilias Apalodimas , Pali =?iso-8859-1?Q?Roh=E1r?= , Mark Kettenis , Heinrich Schuchardt Subject: Re: [PATCH v2 7/9] Make EFI_LOADER depend on DM and OF_CONTROL Message-ID: <20210726220735.GA8013@bill-the-cat> References: <20210702183620.1542680-1-sjg@chromium.org> <20210702183620.1542680-4-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline In-Reply-To: <20210702183620.1542680-4-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 02, 2021 at 12:36:18PM -0600, Simon Glass wrote: > This feature should never have been made available when driver model > or devicetree are disabled. Add these as conditions, so that we don't > create even more barriers to migration. >=20 > Add a note about the substantial size increment associated with this > option. >=20 > Signed-off-by: Simon Glass > --- >=20 > Changes in v2: > - Split out new patch to make EFI_LOADER depend on DM and OF_CONTROL > - Note the approximate size of this feature in the help >=20 > lib/efi_loader/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 6242caceb7f..466abfed300 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -1,6 +1,6 @@ > config EFI_LOADER > bool "Support running UEFI applications" > - depends on OF_LIBFDT && ( \ > + depends on OF_LIBFDT && DM && OF_CONTROL && ( \ > ARM && (SYS_CPU =3D arm1136 || \ > SYS_CPU =3D arm1176 || \ > SYS_CPU =3D armv7 || \ > @@ -25,6 +25,8 @@ config EFI_LOADER > will expose the UEFI API to a loaded application, enabling it to > reuse U-Boot's device drivers. > =20 > + For ARM 32-bit, this adds about 90KB to the size of U-Boot. > + > if EFI_LOADER > =20 > config CMD_BOOTEFI_BOOTMGR Note that we have platforms today with EFI_LOADER without OF_CONTROL, so this isn't strictly the right requirements. What do you think here Heinrich? --=20 Tom --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD/MiMACgkQFHw5/5Y0 tyyMAwv/Qel885XvdD1dtBJmQXlzeo8olTiOzqsG0rjuuSLVBArJg5+YsoHVp4mc 8filOGqp7s3s25ila+CO7nug1YVhEnsfRPt6ZCRJ+vUXUICGgj3sO6jzq4BUz+0C vCYwoBAt/NPw4ARO2gbGLlKiinbVc0RRlhOi+DoGTnwBT8Q1CeKIpf3ufoCq4SXF z/CmCRS+9ir2E7jOT28l2esY91ZsntdyOz4spfY8CV7NdMeqyRlx3FIpAGS1awes 0MBYsLnVbpVotieS/F5bDkvXg3xND422eeGpCBH79g7MPRAmf+Z26ncxN+G9cOsb brTfnQK+K1dait/SBLjCUOkZ3yPEJPrE99VnHZ0B1WefJfhMuTCx0FOfbopSc7I9 k4i8VGzODB0di86y4h8C1ebNB2/FYSokpxyBuohjB0s2ig5s7xqn8LOLqQi4vJkQ 9/IWSkFeuKN2rTOorpy+AhVT9p19OivhM+BgDLxi6nQXPExixs4OnEHkmpNWakKV +EJ7QDeT =y3TE -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24--