From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4C85C4320A for ; Wed, 28 Jul 2021 01:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF3660FE5 for ; Wed, 28 Jul 2021 01:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234421AbhG1BaR (ORCPT ); Tue, 27 Jul 2021 21:30:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234447AbhG1BaP (ORCPT ); Tue, 27 Jul 2021 21:30:15 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E094C061765 for ; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id a20so803768plm.0 for ; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F/W78E3w8bd3psxYX0IIxref8Eo+wzHY8m4KRkXjPMs=; b=fSpVrx2KFTwbTxZxaxYBjKJ9a3HRRpiHfBG8wD07VjuWC7mdbYEQ/7GkiPoSY+/g36 +TtB+dCcoMKG1TPpgjH+W/O2nqputas/NPxb5d/iKCDtXteeWA5Muau5Hiw7k0rZrmBp XaotHXeRLZbN2gC+C3tJaqkKc+t5iWRCRbObY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F/W78E3w8bd3psxYX0IIxref8Eo+wzHY8m4KRkXjPMs=; b=LfUhzPCNkhIonT8lsgsQUIH1OoKgrRO8IwaIv3p1NlH8AfwzFEIEKoU+4RHr81hnxt xOn/aXhFwj4C2j4LAKakZ4u3eokMAEv234OQHePnlIud6oA/vQ1jFlKCVepSy9Btt9/H NEHKUMpYUk9Th2GjCDrYHtnW8IyeoVY7RhpvEVkgvOgTzAe6IAW5rpdv3dSA7wmUNZwa 0mvOt76Ob5MgaeBkwFYOGHwMJ43YSjy8QwNhozN2CQ9YxjoZ3r3ZQlzxoCI2vUnWoTtF VuhYnFSTTIuiADhAjMrh+yIcb0wIOZX/njNRtV7M8rYa9bdGPJavVK+ufHmUwda6f1DW 0pVQ== X-Gm-Message-State: AOAM533w8+jNuXaqi5zVmSE35oNxPYmPyO0D49gl1AdTKV+Al8tk/QYH mz25tzmLoU2MXPoF4l/Ap66N1w== X-Google-Smtp-Source: ABdhPJwJtaC/+3L1bVkg9P8zv+anpCg9BvvGSgBVtWnX3lLVWENuhM7S6jL/vTi/ew8TMCXVE//XxA== X-Received: by 2002:a17:90a:ca93:: with SMTP id y19mr7226022pjt.142.1627435813032; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r13sm5628761pgi.78.2021.07.27.18.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 18:30:12 -0700 (PDT) Date: Tue, 27 Jul 2021 18:30:11 -0700 From: Kees Cook To: Bart Van Assche Cc: linux-hardening@vger.kernel.org, "Gustavo A. R. Silva" , Keith Packard , Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 33/64] lib: Introduce CONFIG_TEST_MEMCPY Message-ID: <202107271829.CE9BADDB@keescook> References: <20210727205855.411487-1-keescook@chromium.org> <20210727205855.411487-34-keescook@chromium.org> <9827144a-dacf-61dc-d554-6c69434708de@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9827144a-dacf-61dc-d554-6c69434708de@acm.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 04:31:03PM -0700, Bart Van Assche wrote: > On 7/27/21 1:58 PM, Kees Cook wrote: > > +static int __init test_memcpy_init(void) > > +{ > > + int err = 0; > > + > > + err |= test_memcpy(); > > + err |= test_memmove(); > > + err |= test_memset(); > > + > > + if (err) { > > + pr_warn("FAIL!\n"); > > + err = -EINVAL; > > + } else { > > + pr_info("all tests passed\n"); > > + } > > + > > + return err; > > +} > > + > > +static void __exit test_memcpy_exit(void) > > +{ } > > + > > +module_init(test_memcpy_init); > > +module_exit(test_memcpy_exit); > > +MODULE_LICENSE("GPL"); > > Has it been considered to implement this test using the Kunit framework? Good point! I will see if that works here; it would make sense to make this KUnit from the start. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1812C4320A for ; Wed, 28 Jul 2021 01:30:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A89860F9D for ; Wed, 28 Jul 2021 01:30:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A89860F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC4896EC30; Wed, 28 Jul 2021 01:30:14 +0000 (UTC) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 653CB6EC30 for ; Wed, 28 Jul 2021 01:30:13 +0000 (UTC) Received: by mail-pl1-x636.google.com with SMTP id t21so695100plr.13 for ; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F/W78E3w8bd3psxYX0IIxref8Eo+wzHY8m4KRkXjPMs=; b=fSpVrx2KFTwbTxZxaxYBjKJ9a3HRRpiHfBG8wD07VjuWC7mdbYEQ/7GkiPoSY+/g36 +TtB+dCcoMKG1TPpgjH+W/O2nqputas/NPxb5d/iKCDtXteeWA5Muau5Hiw7k0rZrmBp XaotHXeRLZbN2gC+C3tJaqkKc+t5iWRCRbObY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F/W78E3w8bd3psxYX0IIxref8Eo+wzHY8m4KRkXjPMs=; b=okKYqYW09NlbcYytC7QDGZRyBi9XbOFFKUKSt/iCf36r320bU0UR9DJhrumpoBzzER GuhWVptV+hYPXQ2DtabsDI/IJm2gIucWdGtwKDUQoqAXVp/A4uk6mbChBOmtMuOBfg1d cbIkrU1EpD8WUEowLuUTVTiTfV+P396ihMIsDSJtceUkV/IWMG47wV8japr/w9MRxHSf 3goLELzInLdw96JYRz9M9dbiTeV7i84W4Sv2wf9q8dBVdqDxlmhHjaJVSmaqZluK8Ssv H0k+F2eqI4utNn55C2SqQhcQdP0GNiqZdinGNKcJeauGcr1Sp9zXoCwp17TAKXFjrsY3 Z3QA== X-Gm-Message-State: AOAM533yT+hyFED10nLCkZzrMTDCsfX1WXm33GoEpia8KdW/8IzqK2i3 aTXaiHNccTUSbTcv+R2Gaz0rTw== X-Google-Smtp-Source: ABdhPJwJtaC/+3L1bVkg9P8zv+anpCg9BvvGSgBVtWnX3lLVWENuhM7S6jL/vTi/ew8TMCXVE//XxA== X-Received: by 2002:a17:90a:ca93:: with SMTP id y19mr7226022pjt.142.1627435813032; Tue, 27 Jul 2021 18:30:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r13sm5628761pgi.78.2021.07.27.18.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 18:30:12 -0700 (PDT) Date: Tue, 27 Jul 2021 18:30:11 -0700 From: Kees Cook To: Bart Van Assche Subject: Re: [PATCH 33/64] lib: Introduce CONFIG_TEST_MEMCPY Message-ID: <202107271829.CE9BADDB@keescook> References: <20210727205855.411487-1-keescook@chromium.org> <20210727205855.411487-34-keescook@chromium.org> <9827144a-dacf-61dc-d554-6c69434708de@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9827144a-dacf-61dc-d554-6c69434708de@acm.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kbuild@vger.kernel.org, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" , linux-block@vger.kernel.org, clang-built-linux@googlegroups.com, Keith Packard , linux-hardening@vger.kernel.org, netdev@vger.kernel.org, Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 27, 2021 at 04:31:03PM -0700, Bart Van Assche wrote: > On 7/27/21 1:58 PM, Kees Cook wrote: > > +static int __init test_memcpy_init(void) > > +{ > > + int err = 0; > > + > > + err |= test_memcpy(); > > + err |= test_memmove(); > > + err |= test_memset(); > > + > > + if (err) { > > + pr_warn("FAIL!\n"); > > + err = -EINVAL; > > + } else { > > + pr_info("all tests passed\n"); > > + } > > + > > + return err; > > +} > > + > > +static void __exit test_memcpy_exit(void) > > +{ } > > + > > +module_init(test_memcpy_init); > > +module_exit(test_memcpy_exit); > > +MODULE_LICENSE("GPL"); > > Has it been considered to implement this test using the Kunit framework? Good point! I will see if that works here; it would make sense to make this KUnit from the start. -- Kees Cook