From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308D5C4338F for ; Wed, 28 Jul 2021 22:58:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 590256101B for ; Wed, 28 Jul 2021 22:58:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 590256101B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AB56982DC0; Thu, 29 Jul 2021 00:58:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Y80QHi/c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E1B7582DB4; Thu, 29 Jul 2021 00:57:04 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 21A1082DB0 for ; Thu, 29 Jul 2021 00:57:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id db14so2433830qvb.10 for ; Wed, 28 Jul 2021 15:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zmMl1kwRRTrO9xpdsVIkzoDGyGJJLM0hsOZsUlbQLVE=; b=Y80QHi/cBtMMOFizVcRywZS/jbXHZ2UAMSTSpeaHorbY1DdTIjQQ+iqS7UDLvHljep KGFgOYgmT0K3PVlu4HYSD7KZw7V5MJITV2IAv2vXiQE3ci0wn3vFC5oFvGHh97B5YuJo xtZJZjUq4iyfJ8fhilOw0q/5uS0Y/o/0BDt/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zmMl1kwRRTrO9xpdsVIkzoDGyGJJLM0hsOZsUlbQLVE=; b=jqz3l5Wsl565sWAmLuS2/1H+rcXRSZvVsS4ChqbJfmStdXeAAW+DD9mQG+D8g+pY3R I73I5VXKe3UDv7/Jh5qVy4iEDDdOXD+P+IrQ83gzrVxNHbRflk/w2JuyAYfOOzL+JaYz 9Sc1nWVapGEBecsCM5fV928eTIz2mcum13eHmIMLCs03hJH+8n/xpciNk9YOwjXYi7r2 nsN8+K7olAn03LeGvL5DU9oYuGAUcglmp4GUftBxy3Sm4VO+FdJB81ODrIxAXwgY3D5R svIf7WSy69u9/60+gbzQnwaqEYdlsR43JfFM/p7RMbUQM7QDIx4BRmr2C4oE0a8VHCZf EGIw== X-Gm-Message-State: AOAM532LhGqZszfRx188hLGRV326FOg5QG2fuefEZiLkKq0Obn8F1Bc0 EYcVAwB6mlCR0JvPqLjrpgtsQg== X-Google-Smtp-Source: ABdhPJydnDn6sEo4ee0XP3vGgt2BtgQvRVEt/7/TKc+9Tz8ePv9FWM5JmflXU1ZcnSZyrvdwkRF8Ug== X-Received: by 2002:ad4:5b85:: with SMTP id 5mr2491671qvp.24.1627513019035; Wed, 28 Jul 2021 15:56:59 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id o17sm754655qko.100.2021.07.28.15.56.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jul 2021 15:56:58 -0700 (PDT) Date: Wed, 28 Jul 2021 18:56:56 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Ilias Apalodimas , Pali =?iso-8859-1?Q?Roh=E1r?= , Mark Kettenis , Heinrich Schuchardt Subject: Re: [PATCH v2 5/9] Allow efi_loader header to be included always Message-ID: <20210728225656.GG9379@bill-the-cat> References: <20210702183620.1542680-1-sjg@chromium.org> <20210702183620.1542680-3-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tOEJyvZxeaoVWcY4" Content-Disposition: inline In-Reply-To: <20210702183620.1542680-3-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --tOEJyvZxeaoVWcY4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 02, 2021 at 12:36:16PM -0600, Simon Glass wrote: > It is bad practice to put function declarations behind an #ifdef since > it makes it impossible to use IS_ENABLED() in the C code. The main reason > for doing this is when an empty static inline function is desired when > the feature is disabled. >=20 > To this end, this header provides two different versions of various > functions and macros. Collect them together in one place for clarity. > Allow all the rest of the header to be included, regardless of the > setting of EFI_LOADER. >=20 > With the inclusion of blk.h the 'struct blk_desc' declaration is > unnecessary. Drop it while we are here. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --tOEJyvZxeaoVWcY4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEB4LgACgkQFHw5/5Y0 tyxyWwv8CbzxhktEsx2aMgMD/BUyB/pTji5rNA5EVYhzoOzRvc6jGsEqu6y5glbe Gbnexvk8JpnkzJrf+JB+IGlDogIA4rdxMvH2ZkZKbWPOkRtDXatQWr7MSjUeP5l7 rGnPlyQSOFMaeRnKLTURRBxcsA9Zz7s0ur0PfIJUeFagco1zFCnrp+dcfTYmWqmV loUjekJawJvMrv+Khjr6edO4zv/0btIWoexSuKStpr8pqLJ0Br3ZSjB5y60eMzEp midDaNMQaxyI/MxeHYEUyjW3LvlTuneNoAeRuH7lZKBzgpoc7d5vpCCHTulL/Eg/ yZ2kNBVl/AjZd+SFhbd0fNuetUCL6w8uuE32/uGMbXkL/kpFI8gEjjxyr9R95LK7 JwO4La0xO0/q6dXGC4/muqrCLhGZdZiTEtvtkXllUUMi4af3c/lrerivvoYkPT3M +OnmxthRxMMxb37u6URJYVrRDXKHMVoptItR0g1QRA761HAKQJjjPidNIk7u80Ka N/3YwE2Q =08bJ -----END PGP SIGNATURE----- --tOEJyvZxeaoVWcY4--