From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C88FC4338F for ; Wed, 28 Jul 2021 23:55:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70AA660ED4 for ; Wed, 28 Jul 2021 23:55:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 70AA660ED4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9214982D73; Thu, 29 Jul 2021 01:55:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nT1rpBqd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A96C782D82; Thu, 29 Jul 2021 01:55:20 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 204A082CDA for ; Thu, 29 Jul 2021 01:55:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id t68so4091654qkf.8 for ; Wed, 28 Jul 2021 16:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=i798dkgSTKEvyhlJGJpR1OF3nrWs/dj3Oh02fqmI1rc=; b=nT1rpBqdJV0/w/1ll9+UEGYSO+8JrgD0clJb7wWRCtHUha/btO5xy2nDdztsXNdali 3a2ZnAUrX7E7WUSPoSaAbTyiCwHYP/M7YAMJ6+4U5fcgZN5K9pju5DVaO0PfDHv3kO/G 5tjJZVhKEIFtdJNh3iMKm8kvdxyT5fuHWKzpA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=i798dkgSTKEvyhlJGJpR1OF3nrWs/dj3Oh02fqmI1rc=; b=ImxttQZZCuU8Bkg6h1cWX7S5H+OUEIIXo7tCCn4srFZc1vdhrMOO/pHuv04T3+ZTm0 snM4SdGnfJxtn5Q1FkeL3PjVLdAqxRk/tm2PWMwIcFp4b0HC1d+RFnVUPwvheTgmF6OL IZz9RkODKH+HVG8DjDWLtQSH0c6pU2OQiQ6HyybTXfvqd2SUfKlo/lF8YEw2V7wBbmp+ TAid0MbBxfdUY+go+sPTsOr1yCTnv2vCdneB5YMtaQgmwms2igsaCvjJ8oef09vtOuxK 34AFevj5bqBcn8a/SODHh7M0By7+sBFV/iQur4M1mkgsiv78qzJNTpRNZrlsx0HaCXlG 1Qag== X-Gm-Message-State: AOAM530KslPifofysXoA0gbtGswxGaIuDehUh3Mh7MCqCShCYQni8cGg O3pGstCyggvjhX9fVYxLRtjYwA== X-Google-Smtp-Source: ABdhPJz19R00L9yuhmRHmCvpK1oSEx5DYvYuqcJRboLtQWJuD8Mj18oDfmDyvZ2mJ6IHVMDIgYkyAg== X-Received: by 2002:a05:620a:13f3:: with SMTP id h19mr2394885qkl.164.1627516516041; Wed, 28 Jul 2021 16:55:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id m6sm771615qki.47.2021.07.28.16.55.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jul 2021 16:55:14 -0700 (PDT) Date: Wed, 28 Jul 2021 19:55:13 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , U-Boot Mailing List , Ilias Apalodimas , Pali =?iso-8859-1?Q?Roh=E1r?= , Mark Kettenis Subject: Re: [PATCH v2 7/9] Make EFI_LOADER depend on DM and OF_CONTROL Message-ID: <20210728235513.GJ9379@bill-the-cat> References: <20210702183620.1542680-1-sjg@chromium.org> <20210702183620.1542680-4-sjg@chromium.org> <20210726220735.GA8013@bill-the-cat> <5dba1547-37cc-14f0-1514-1dc337b0d25e@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2bjkoQU/J7v2vW91" Content-Disposition: inline In-Reply-To: <5dba1547-37cc-14f0-1514-1dc337b0d25e@gmx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --2bjkoQU/J7v2vW91 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 29, 2021 at 01:45:49AM +0200, Heinrich Schuchardt wrote: >=20 >=20 > On 7/27/21 12:07 AM, Tom Rini wrote: > > On Fri, Jul 02, 2021 at 12:36:18PM -0600, Simon Glass wrote: > >=20 > > > This feature should never have been made available when driver model > > > or devicetree are disabled. Add these as conditions, so that we don't > > > create even more barriers to migration. > > >=20 > > > Add a note about the substantial size increment associated with this > > > option. > > >=20 > > > Signed-off-by: Simon Glass > > > --- > > >=20 > > > Changes in v2: > > > - Split out new patch to make EFI_LOADER depend on DM and OF_CONTROL > > > - Note the approximate size of this feature in the help > > >=20 > > > lib/efi_loader/Kconfig | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > > > index 6242caceb7f..466abfed300 100644 > > > --- a/lib/efi_loader/Kconfig > > > +++ b/lib/efi_loader/Kconfig > > > @@ -1,6 +1,6 @@ > > > config EFI_LOADER > > > bool "Support running UEFI applications" > > > - depends on OF_LIBFDT && ( \ > > > + depends on OF_LIBFDT && DM && OF_CONTROL && ( \ >=20 > Didn't Tom eliminate all boards without CONFIG_DM? Shouldn't we get rid > of this symbol? No, but I did send out a message about that today as we're very close. Much closer than I had expected us to be. > Are there boards using DM and not OF_CONTROL or OF_CONTROL and not DM? Yes, a few. It's vexpress_aemv8a_semi, warp (fixed by https://patchwork.ozlabs.org/project/uboot/patch/20210402180552.1075997-2-p= brobinson@gmail.com/ so false positive), cm_t335, devkit8000, armadillo-800eva, kzm9g and sniper. > Why are these separate symbols? Isn't this symbol to be eliminated, too? Simon? > lib/efi_loader/efi_disk.c is the only place where we maintain duplicate > code for DM and non-DM. A dependency on CONFIG_BLK (which itself depends > on CONFIG_DM) would make more sense to me. But only in a patch > eliminating the non-BLK code. I just know that off-hand, partition + disk + block has some corner case, but maybe that corner case is unintentional in terms of usage today. > > > ARM && (SYS_CPU =3D arm1136 || \ > > > SYS_CPU =3D arm1176 || \ > > > SYS_CPU =3D armv7 || \ > > > @@ -25,6 +25,8 @@ config EFI_LOADER > > > will expose the UEFI API to a loaded application, enabling it to > > > reuse U-Boot's device drivers. > > >=20 > > > + For ARM 32-bit, this adds about 90KB to the size of U-Boot. > > > + >=20 > There is no unit ISO prefix K. Do you mean KiB? >=20 > 90 KiB may be the value today. Will you update it regularly? Otherwise > don't put a number here. >=20 > I can't see that the effect on size is truly architecture specific. Why > do you refer to 32bit ARM? >=20 > Such a comment would better fit into a documentation chapter on > downsizing U-Boot. Yes, we should probably drop that specific note. --=20 Tom --2bjkoQU/J7v2vW91 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEB7loACgkQFHw5/5Y0 tyxUwwv+McN0zz0dmHd5x/7Lz8jXLkdh1BKjLfHC1CHQeqFeVvGloKxtxqS+zYSn ijcR4wOOxjanKrbl9UcBSU5IWWdpMFb7zOhNpKvyvUMpMhBYNoYAM7i1woKtkU3l kyfIwkuO40ZsZRDKNyDPVi9LQBmKS/Wx5B+0hHAl6E45OnGTmILwEXsZe95EFnCk gRl2QEMlTpCUAnB+iEE9vFDG6zPPiSpbkfMluTwHWUoNPMUdzRc3B4lEGUIxRSlp t/lXS2BdcPiV8/cKEn9MeX8MbalxqXDN2mdmcUr6MgUc+IarHJqm2EOh9IniH4MT GX10v4Yy3QkK0MSiANMcLNVyzeXc8i/LbXxyIffy3ijL9bf4dncr1DtBFbsWcFPw PO5A/rhT3Jgn3PJ/y+tA9XdA1CwThZJJ5iCOLApaGDfEyXtCOeZ3wFEInvy3BkV/ 725M33Jshiq5bRub2AL+c779/wJS8ke4794St6pB49/jeNY+nCUMSkuUd/uQQj/W +0nufUdF =quD2 -----END PGP SIGNATURE----- --2bjkoQU/J7v2vW91--