Hi Kees, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on linus/master v5.14-rc3] [cannot apply to wireless-drivers-next/master wireless-drivers/master next-20210727] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kees-Cook/Introduce-strict-memcpy-bounds-checking/20210728-053749 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 39f9137268ee3df0047706df4e9b7357a40ffc98 config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/6617421fca0f2272593a2659a5cba25bf8249857 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kees-Cook/Introduce-strict-memcpy-bounds-checking/20210728-053749 git checkout 6617421fca0f2272593a2659a5cba25bf8249857 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) drivers/acpi/apei/erst.c:272:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *src @@ got void [noderef] __iomem * @@ drivers/acpi/apei/erst.c:272:13: sparse: expected void *src drivers/acpi/apei/erst.c:272:13: sparse: got void [noderef] __iomem * drivers/acpi/apei/erst.c:275:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *dst @@ got void [noderef] __iomem * @@ drivers/acpi/apei/erst.c:275:13: sparse: expected void *dst drivers/acpi/apei/erst.c:275:13: sparse: got void [noderef] __iomem * drivers/acpi/apei/erst.c:277:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got void *src @@ drivers/acpi/apei/erst.c:277:25: sparse: expected void volatile [noderef] __iomem *addr drivers/acpi/apei/erst.c:277:25: sparse: got void *src drivers/acpi/apei/erst.c:283:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got void *src @@ drivers/acpi/apei/erst.c:283:17: sparse: expected void volatile [noderef] __iomem *addr drivers/acpi/apei/erst.c:283:17: sparse: got void *src drivers/acpi/apei/erst.c:284:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got void *dst @@ drivers/acpi/apei/erst.c:284:17: sparse: expected void volatile [noderef] __iomem *addr drivers/acpi/apei/erst.c:284:17: sparse: got void *dst >> drivers/acpi/apei/erst.c:792:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const * @@ got void [noderef] __iomem *static [toplevel] vaddr @@ drivers/acpi/apei/erst.c:792:9: sparse: expected void const * drivers/acpi/apei/erst.c:792:9: sparse: got void [noderef] __iomem *static [toplevel] vaddr >> drivers/acpi/apei/erst.c:792:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const * @@ got void [noderef] __iomem *static [toplevel] vaddr @@ drivers/acpi/apei/erst.c:792:9: sparse: expected void const * drivers/acpi/apei/erst.c:792:9: sparse: got void [noderef] __iomem *static [toplevel] vaddr drivers/acpi/apei/erst.c:792:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void * @@ got void [noderef] __iomem *static [toplevel] vaddr @@ drivers/acpi/apei/erst.c:792:9: sparse: expected void * drivers/acpi/apei/erst.c:792:9: sparse: got void [noderef] __iomem *static [toplevel] vaddr drivers/acpi/apei/erst.c:793:20: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct cper_record_header *rcd_erange @@ got void [noderef] __iomem *static [toplevel] vaddr @@ drivers/acpi/apei/erst.c:793:20: sparse: expected struct cper_record_header *rcd_erange drivers/acpi/apei/erst.c:793:20: sparse: got void [noderef] __iomem *static [toplevel] vaddr drivers/acpi/apei/erst.c:830:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct cper_record_header *rcd_tmp @@ got void [noderef] __iomem * @@ drivers/acpi/apei/erst.c:830:17: sparse: expected struct cper_record_header *rcd_tmp drivers/acpi/apei/erst.c:830:17: sparse: got void [noderef] __iomem * -- >> drivers/misc/sgi-gru/grukdump.c:60:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const * @@ got void [noderef] __user *[addressable] ubuf @@ drivers/misc/sgi-gru/grukdump.c:60:17: sparse: expected void const * drivers/misc/sgi-gru/grukdump.c:60:17: sparse: got void [noderef] __user *[addressable] ubuf >> drivers/misc/sgi-gru/grukdump.c:60:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const * @@ got void [noderef] __user *[addressable] ubuf @@ drivers/misc/sgi-gru/grukdump.c:60:17: sparse: expected void const * drivers/misc/sgi-gru/grukdump.c:60:17: sparse: got void [noderef] __user *[addressable] ubuf >> drivers/misc/sgi-gru/grukdump.c:60:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void * @@ got void [noderef] __user *[addressable] ubuf @@ drivers/misc/sgi-gru/grukdump.c:60:17: sparse: expected void * drivers/misc/sgi-gru/grukdump.c:60:17: sparse: got void [noderef] __user *[addressable] ubuf drivers/misc/sgi-gru/grukdump.c:129:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct gru_context_configuration_handle *ubufcch @@ got void [noderef] __user *[assigned] ubuf @@ drivers/misc/sgi-gru/grukdump.c:129:17: sparse: expected struct gru_context_configuration_handle *ubufcch drivers/misc/sgi-gru/grukdump.c:129:17: sparse: got void [noderef] __user *[assigned] ubuf drivers/misc/sgi-gru/grukdump.c:192:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *ubuf @@ got void *[addressable] [assigned] buf @@ drivers/misc/sgi-gru/grukdump.c:192:14: sparse: expected void [noderef] __user *ubuf drivers/misc/sgi-gru/grukdump.c:192:14: sparse: got void *[addressable] [assigned] buf drivers/misc/sgi-gru/grukdump.c:193:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *ubufend @@ got void * @@ drivers/misc/sgi-gru/grukdump.c:193:17: sparse: expected void [noderef] __user *ubufend drivers/misc/sgi-gru/grukdump.c:193:17: sparse: got void * vim +792 drivers/acpi/apei/erst.c a08f82d08053fb Huang Ying 2010-05-18 766 a08f82d08053fb Huang Ying 2010-05-18 767 int erst_write(const struct cper_record_header *record) a08f82d08053fb Huang Ying 2010-05-18 768 { a08f82d08053fb Huang Ying 2010-05-18 769 int rc; a08f82d08053fb Huang Ying 2010-05-18 770 unsigned long flags; a08f82d08053fb Huang Ying 2010-05-18 771 struct cper_record_header *rcd_erange; a08f82d08053fb Huang Ying 2010-05-18 772 a08f82d08053fb Huang Ying 2010-05-18 773 if (erst_disable) a08f82d08053fb Huang Ying 2010-05-18 774 return -ENODEV; a08f82d08053fb Huang Ying 2010-05-18 775 a08f82d08053fb Huang Ying 2010-05-18 776 if (memcmp(record->signature, CPER_SIG_RECORD, CPER_SIG_SIZE)) a08f82d08053fb Huang Ying 2010-05-18 777 return -EINVAL; a08f82d08053fb Huang Ying 2010-05-18 778 a08f82d08053fb Huang Ying 2010-05-18 779 if (erst_erange.attr & ERST_RANGE_NVRAM) { 3b38bb5f7f0635 Huang Ying 2010-12-02 780 if (!raw_spin_trylock_irqsave(&erst_lock, flags)) a08f82d08053fb Huang Ying 2010-05-18 781 return -EBUSY; a08f82d08053fb Huang Ying 2010-05-18 782 rc = __erst_write_to_nvram(record); 3b38bb5f7f0635 Huang Ying 2010-12-02 783 raw_spin_unlock_irqrestore(&erst_lock, flags); a08f82d08053fb Huang Ying 2010-05-18 784 return rc; a08f82d08053fb Huang Ying 2010-05-18 785 } a08f82d08053fb Huang Ying 2010-05-18 786 a08f82d08053fb Huang Ying 2010-05-18 787 if (record->record_length > erst_erange.size) a08f82d08053fb Huang Ying 2010-05-18 788 return -EINVAL; a08f82d08053fb Huang Ying 2010-05-18 789 3b38bb5f7f0635 Huang Ying 2010-12-02 790 if (!raw_spin_trylock_irqsave(&erst_lock, flags)) a08f82d08053fb Huang Ying 2010-05-18 791 return -EBUSY; a08f82d08053fb Huang Ying 2010-05-18 @792 memcpy(erst_erange.vaddr, record, record->record_length); a08f82d08053fb Huang Ying 2010-05-18 793 rcd_erange = erst_erange.vaddr; a08f82d08053fb Huang Ying 2010-05-18 794 /* signature for serialization system */ a08f82d08053fb Huang Ying 2010-05-18 795 memcpy(&rcd_erange->persistence_information, "ER", 2); a08f82d08053fb Huang Ying 2010-05-18 796 a08f82d08053fb Huang Ying 2010-05-18 797 rc = __erst_write_to_storage(0); 3b38bb5f7f0635 Huang Ying 2010-12-02 798 raw_spin_unlock_irqrestore(&erst_lock, flags); a08f82d08053fb Huang Ying 2010-05-18 799 a08f82d08053fb Huang Ying 2010-05-18 800 return rc; a08f82d08053fb Huang Ying 2010-05-18 801 } a08f82d08053fb Huang Ying 2010-05-18 802 EXPORT_SYMBOL_GPL(erst_write); a08f82d08053fb Huang Ying 2010-05-18 803 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org